Skip to content

feat: build and publish container image#37

Open
krasilovalex wants to merge 1 commit into
llm-d:mainfrom
krasilovalex:feat/build-image/workflow
Open

feat: build and publish container image#37
krasilovalex wants to merge 1 commit into
llm-d:mainfrom
krasilovalex:feat/build-image/workflow

Conversation

@krasilovalex
Copy link
Copy Markdown

This PR introduces a centralized GitHub Actions workflow for building and pushing container images, following the principles and structure of the llm-d-inference-scheduler repository.

Closes #35

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

🚨 Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

@krasilovalex krasilovalex force-pushed the feat/build-image/workflow branch from 0ffb01b to ebec8bb Compare May 4, 2026 21:17
Signed-off-by: krasilovalex <onexoffalex@gmail.com>
@krasilovalex krasilovalex force-pushed the feat/build-image/workflow branch from ebec8bb to e1d09bd Compare May 4, 2026 21:19
@krasilovalex krasilovalex reopened this May 4, 2026
@krasilovalex
Copy link
Copy Markdown
Author

I have signed the commit using git commit -s, and the log shows the signature, but the action seems to be failing to recognize it. Could you please check it manually?

@nirrozenbaum
Copy link
Copy Markdown
Collaborator

I have signed the commit using git commit -s, and the log shows the signature, but the action seems to be failing to recognize it. Could you please check it manually?

@krasilovalex it looks like your commits are not verified.
have you tried following the guide GitHub Documentation?

@krasilovalex
Copy link
Copy Markdown
Author

Я подписал коммит с помощью git commit -s, и в журнале отображается подпись, но, похоже, действие не распознает ее. Не могли бы вы проверить ее вручную?

@krasilovalex похоже, ваши коммиты не проверены. Вы пробовали следовать инструкциям в документации GitHub?

Thanks @nirrozenbaum. I used -s (lowercase) for a standard DCO sign-off. Does this repository strictly require cryptographic GPG/SSH signatures (-S uppercase) for the 'Verified' badge? If so, I'll set it up and amend the commit.

@nirrozenbaum
Copy link
Copy Markdown
Collaborator

nirrozenbaum commented May 5, 2026

Я подписал коммит с помощью git commit -s, и в журнале отображается подпись, но, похоже, действие не распознает ее. Не могли бы вы проверить ее вручную?

@krasilovalex похоже, ваши коммиты не проверены. Вы пробовали следовать инструкциям в документации GitHub?

Thanks @nirrozenbaum. I used -s (lowercase) for a standard DCO sign-off. Does this repository strictly require cryptographic GPG/SSH signatures (-S uppercase) for the 'Verified' badge? If so, I'll set it up and amend the commit.

following the formal github docs, you should be able to see "verfied" badge on your commits (in commits tab), which is currently missing.
I'm using -s (lowercase) and it works for me. I think it's just a matter of setting the gpg key and then use it in your commits. full instructions are in the git docs.

Comment on lines +7 to +9
required: true
type: string
default: "llm-d-inference-payload-processor"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does required: true while also providing a default do anything weird?

- name: Build and push image
uses: ./.github/actions/docker-build-and-push
with:
docker-file: Dockerfile
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like docker-build-and-push declares docker-file, so this is probably being silently ignored?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Build and Publish Container Image

3 participants