feat: build and publish container image#37
Conversation
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
0ffb01b to
ebec8bb
Compare
Signed-off-by: krasilovalex <onexoffalex@gmail.com>
ebec8bb to
e1d09bd
Compare
|
I have signed the commit using |
@krasilovalex it looks like your commits are not verified. |
Thanks @nirrozenbaum. I used -s (lowercase) for a standard DCO sign-off. Does this repository strictly require cryptographic GPG/SSH signatures (-S uppercase) for the 'Verified' badge? If so, I'll set it up and amend the commit. |
following the formal github docs, you should be able to see "verfied" badge on your commits (in commits tab), which is currently missing. |
| required: true | ||
| type: string | ||
| default: "llm-d-inference-payload-processor" |
There was a problem hiding this comment.
Does required: true while also providing a default do anything weird?
| - name: Build and push image | ||
| uses: ./.github/actions/docker-build-and-push | ||
| with: | ||
| docker-file: Dockerfile |
There was a problem hiding this comment.
It doesn't look like docker-build-and-push declares docker-file, so this is probably being silently ignored?
This PR introduces a centralized GitHub Actions workflow for building and pushing container images, following the principles and structure of the llm-d-inference-scheduler repository.
Closes #35