Skip to content

[Arch] Pulse v5: Stabilize wallet tool wiring — replace direct patches with proper adapter injection #40

@islandbitcoin

Description

@islandbitcoin

Summary

The check_balance tool (and likely other wallet tools) are currently patched to call the Flash API directly rather than going through the proper adapter injection layer. This creates tight coupling and makes testing/maintenance harder.

Current state

  • check_balance patched to query Flash API directly (bypassing WalletPort adapter)
  • Direct patches introduced to work around stub failures during development

Target state

  • All wallet tools route through the proper adapter/port interface
  • WalletPort implementation is injected via DI, not bypassed
  • Adapters are swappable for testing (stub vs real Flash API)

Acceptance criteria

  • WalletPort adapter properly injected in all wallet tool handlers
  • No direct Flash API calls in tool layer
  • Unit tests use stub adapter cleanly
  • No regression on check_balance, send, receive flows

Notes

Hold for Dread go-ahead before implementation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions