Skip to content

Make alarm language and logic consistent #507

@marionbarker

Description

@marionbarker

Issue Description

Most alarms use the logic level >= limit or level <= limit with appropriate language in the .footer string.

However, we discovered some language that does not match the logic.

There are also some alarms where the equal to is not include in the .footer and it is possible the logic might also be different for those cases.

Instances

The pump battery alarm was just added as a copy of the phone battery alarm with PR #496.

In reviewing that PR, we noticed this issue and decided to just merge that PR with the language issue and pick up the string update in a separate PR.

In reviewing other alarm strings, these were identified as worth another look:

  • MissedBolusAlarm
  • COBAlarm
  • RecBolusAlarm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions