[rtl] Clean up iCache Tweak Infection#2379
Merged
Merged
Conversation
Contributor
nasahlpa
commented
Apr 10, 2026
nasahlpa
commented
- Fix a linting issue
- Move the un-XOR to the way hit logic
Linting raised that constant zeros are stored in the `data_tweak_lw_ic1` and `tag_tweak_lw_ic1` FFs. Although this is exactly what we want, we can bypass this linting issue by only storing the relevant bits in the FFs and expand them before appyling the XOR. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
Instead of doing the un-XOR for all ways, just do it for the way we have a hit. This is identical from a functional perspective but is cleaner from an implementation perspective. Signed-off-by: Pascal Nasahl <nasahlpa@lowrisc.org>
vogelpi
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.