From 853891c3bea4f4f5a7bc8fc5ecac2168edbb9e20 Mon Sep 17 00:00:00 2001 From: Matthias Date: Sun, 7 Jun 2026 13:38:13 +0200 Subject: [PATCH 1/2] Pin pnpm to 11.5.2 CI floated on pnpm@latest, causing version drift with local environments and with the allowBuilds config in pnpm-workspace.yaml (which requires pnpm 10.26+). Pin pnpm via package.json's packageManager field and in the withastro/action workflows so CI and local development use the same version. --- .github/workflows/check-links.yml | 2 +- .github/workflows/check-pr-links.yml | 2 +- .github/workflows/deploy.yml | 2 +- package.json | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml index 7f18e8f..3ad9ff9 100644 --- a/.github/workflows/check-links.yml +++ b/.github/workflows/check-links.yml @@ -17,7 +17,7 @@ jobs: - name: Build site uses: withastro/action@v5 with: - package-manager: pnpm@latest + package-manager: pnpm@11.5.2 - name: Link Checker id: lychee diff --git a/.github/workflows/check-pr-links.yml b/.github/workflows/check-pr-links.yml index e41bbc8..3966c64 100644 --- a/.github/workflows/check-pr-links.yml +++ b/.github/workflows/check-pr-links.yml @@ -14,7 +14,7 @@ jobs: - name: Build site uses: withastro/action@v5 with: - package-manager: pnpm@latest + package-manager: pnpm@11.5.2 - name: Check links uses: lycheeverse/lychee-action@v2 diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index e28615d..f23a5ce 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -21,7 +21,7 @@ jobs: - name: Install, build, and upload your site uses: withastro/action@v5 with: - package-manager: pnpm@latest + package-manager: pnpm@11.5.2 deploy: needs: build diff --git a/package.json b/package.json index 607a2fd..499ad16 100644 --- a/package.json +++ b/package.json @@ -3,6 +3,7 @@ "type": "module", "version": "2025.07.16", "private": true, + "packageManager": "pnpm@11.5.2", "scripts": { "dev": "astro dev", "start": "astro dev", From 6a97650fa7497ec276e721ff625e7ed9e6942837 Mon Sep 17 00:00:00 2001 From: Matthias Date: Thu, 11 Jun 2026 12:41:49 +0200 Subject: [PATCH 2/2] Derive pnpm version from package.json in workflows Instead of restating pnpm@11.5.2 in each withastro/action step, omit the package-manager input. The action auto-detects pnpm from pnpm-lock.yaml and pnpm/action-setup reads the version from the packageManager field in package.json, making it the single source of truth (addresses review feedback). --- .github/workflows/check-links.yml | 2 -- .github/workflows/check-pr-links.yml | 2 -- .github/workflows/deploy.yml | 2 -- 3 files changed, 6 deletions(-) diff --git a/.github/workflows/check-links.yml b/.github/workflows/check-links.yml index 3ad9ff9..1cae9f4 100644 --- a/.github/workflows/check-links.yml +++ b/.github/workflows/check-links.yml @@ -16,8 +16,6 @@ jobs: - name: Build site uses: withastro/action@v5 - with: - package-manager: pnpm@11.5.2 - name: Link Checker id: lychee diff --git a/.github/workflows/check-pr-links.yml b/.github/workflows/check-pr-links.yml index 3966c64..b9ec663 100644 --- a/.github/workflows/check-pr-links.yml +++ b/.github/workflows/check-pr-links.yml @@ -13,8 +13,6 @@ jobs: - name: Build site uses: withastro/action@v5 - with: - package-manager: pnpm@11.5.2 - name: Check links uses: lycheeverse/lychee-action@v2 diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index f23a5ce..f8fe0e6 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -20,8 +20,6 @@ jobs: uses: actions/checkout@v5 - name: Install, build, and upload your site uses: withastro/action@v5 - with: - package-manager: pnpm@11.5.2 deploy: needs: build