From 14c81aba102d5ef25c4c0a8d3a74a7fb032f510b Mon Sep 17 00:00:00 2001 From: Diederik de Haas Date: Tue, 1 Apr 2025 17:07:10 +0200 Subject: [PATCH] arm64: pinenote_defconfig: Explicitly enable binfmt options like COREDUMP Previously ``CONFIG_COREDUMP`` was explicitly disabled, while that option is ``default y``, so enabled by default. More over, its help text says the following: This option enables support for performing core dumps. You almost certainly want to say Y here. Not necessary on systems that never need debugging or only ever run flawless code. I think it's safe to say that the PineNote ('currently') does NOT fall in that category ;-) so remove the disablement. While that in itself is enough, due to ``default y``, the Debian kernel has explicitly enabled various options from ``fs/Kconfig.binfmt`` which would be enabled by default. So lets follow suit. Suggested-by: hrdl # on IRC Signed-off-by: Diederik de Haas --- arch/arm64/configs/pinenote_defconfig | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/configs/pinenote_defconfig b/arch/arm64/configs/pinenote_defconfig index c24f75f3ecef53..0a7a3824b6f28e 100644 --- a/arch/arm64/configs/pinenote_defconfig +++ b/arch/arm64/configs/pinenote_defconfig @@ -116,7 +116,6 @@ CONFIG_BLK_DEV_THROTTLING=y # CONFIG_BLK_DEBUG_FS is not set # CONFIG_MQ_IOSCHED_DEADLINE is not set # CONFIG_MQ_IOSCHED_KYBER is not set -# CONFIG_COREDUMP is not set CONFIG_CMA=y CONFIG_CMA_DEBUG=y CONFIG_CMA_DEBUGFS=y @@ -1285,6 +1284,15 @@ CONFIG_DW_WATCHDOG=y CONFIG_FILE_LOCKING=y CONFIG_NETWORK_FILESYSTEMS=y +## +## file: fs/Kconfig.binfmt +## +CONFIG_BINFMT_ELF=y +CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y +CONFIG_BINFMT_SCRIPT=y +CONFIG_BINFMT_MISC=m +CONFIG_COREDUMP=y + ## ## file: fs/cachefiles/Kconfig ##