From 9890be727417d65642c793a1629ad6501c91d038 Mon Sep 17 00:00:00 2001 From: Tuomas Tynkkynen Date: Sat, 20 Jan 2018 23:06:35 +0200 Subject: [PATCH] nox-review: Fix --keep-going Currently e.g. `nox-review --keep-going wip --against HEAD^` fails because extra-args is being set to `[["--keep-going"]]`, that is a list of list containing a string. This crashes nox later on: File "/nix/store/82f7gbp1byi5qp78rjrapzl7z97whjkp-nox-0.0.6/lib/python3.6/site-packages/nox/review.py", line 38, in build_in_path click.echo('Invoking {}'.format(' '.join(command))) TypeError: sequence item 1: expected str instance, list found Remove the extra list to fix the crash. --- nox/review.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nox/review.py b/nox/review.py index 0d31db9..3e1406e 100644 --- a/nox/review.py +++ b/nox/review.py @@ -80,7 +80,7 @@ def cli(ctx, keep_going, dry_run): """Review a change by building the touched commits""" ctx.obj = {'extra-args': []} if keep_going: - ctx.obj['extra-args'].append(['--keep-going']) + ctx.obj['extra-args'].append('--keep-going') ctx.obj['dry_run'] = dry_run