fix: Resolve Dual Dark Mode Conflict — Unify to CSS Variables (#693)#999
Merged
magic-peach merged 1 commit intoMay 23, 2026
Merged
Conversation
|
Someone is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
level:advanced
Contributor
✅ PR Format Check Passed — @Abhi190702Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Abhi190702!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
magic-peach
added
gssoc:approved
Contributor
Author
|
@magic-peach , Hey I would be grateful If you could look onto this |
Owner
|
@Abhi190702 please star the repo |
chavanGaneshDatta
pushed a commit
to chavanGaneshDatta/reframe
that referenced
this pull request
May 23, 2026
…rk: utilities (magic-peach#693) (magic-peach#999) Co-authored-by: zack34567 <varun.ch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #693 — Two conflicting dark mode systems produced different background shades depending on which code path ran first.
Root Cause
The project had two active dark mode systems:
.darkclass inglobals.css(--bg: #0f172a)dark:utility classes (dark:bg-slate-900,dark:bg-gray-800)These produced visually different shades, making the UI look inconsistent on hard refresh vs. theme toggle.
Changes Made
src/app/globals.css:root(light) and.darkvariable definitionssrc/app/layout.tsx<head>before resource hints to apply theme class before first paintsrc/components/ThemeProvider.tsxdarkclass is toggled only on<html>/document.documentElementthemewithlight/darksrc/components/ThemeToggle.tsxdocument.documentElementdark:utility classes from its markupsrc/componentsandsrc/appdark:color utilities with CSS variable classes likebg-[var(--bg)],bg-[var(--surface)],text-[var(--text)],text-[var(--muted)], andborder-[var(--border)]dark:utilities remain insrc/componentsorsrc/appTS/TSX filesTests
Result
#0f172a)dark:color utilities remain in component/page TSX filesTesting
bun run lint✅bunx tsc --noEmit✅bun run build✅rg "dark:" src/components src/app --glob "*.tsx" --glob "*.ts"returns zero results ✅