feat(psc): add has_awards; retire the last CONTRACT_OMITTED_PARAMS entry

Re-vendors the contract now that makegov/tango#2948 merged, which taught the
generator to publish params a viewset reads straight from query_params.

Two consequences, both anticipated:

1. The self-cleaning warning added in this PR fired on its own carve-out —
   "mas_sins: CONTRACT_OMITTED_PARAMS entries no longer needed (the contract
   now publishes them): search". Removed it. The list is now empty, which is
   the goal state; the mechanism stays for the next case.

2. A new real gap surfaced: psc `has_awards` filters (2,526 codes -> 2,243)
   but list_psc did not expose it. It was invisible until #2948 published it.
   Added, sending False explicitly rather than dropping it, since the API
   distinguishes the two.

Note that #2948 also fixed a truthiness bug where has_awards=false filtered
identically to true. Production is still on 4.18.5 and staging is at 4.18.5e,
so until that deploys, has_awards=False returns awards-only results. Verified
live: 2,526 unfiltered, 2,243 for both True and False today.

Gates: conformance exit 0 with no errors, shape coverage 0 gaps. 366 unit
tests pass, 124 integration. mypy strict clean. The one failure,
test_production_smoke::test_search_filters, is a live-API 504 reproduced on
unmodified main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: vdavez

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 - `list_protests()` now accepts `naics_code`, filtering protests by the solicitation's NAICS code. The API has always supported it (verified live: 15,027 protests unfiltered, 12 for `541519`, 2 for `336411`), but `protests` was absent from the conformance checker's resource-to-method map, so the gap was never reported.
+- `list_psc()` now accepts `has_awards`, restricting results to codes with contract award history (2,526 PSC codes unfiltered, 2,243 with awards). `False` is sent explicitly rather than dropped, since the API distinguishes the two. This param has always worked but was invisible to the contract until [makegov/tango#2948](https://github.com/makegov/tango/pull/2948) added the `view_handled_params` declaration for params a viewset reads straight from `query_params`. Note that the same PR fixed a truthiness bug where `has_awards=false` filtered identically to `true`; until it reaches production, passing `has_awards=False` still returns awards-only results.
 
 ### Fixed
 - **The reverse shape-coverage gate was blind to seven resources, and the SDK's schemas had silently drifted behind four of them.** The gate skipped any resource whose contract shape tree was falsy (`if not shape: continue`). Tango published `"shape": null` for `entities`, `opportunities`, `notices`, `protests`, `itdashboard`, `events`, and `news` — five of them because its contract generator crashed on tier-aware viewsets ([makegov/tango#2944](https://github.com/makegov/tango/pull/2944)) — so the gate reported full coverage while checking nothing for them. Re-vendoring the fixed contract surfaced **69 real gaps** (36 fields, 20 expands, 13 flattened expands) across entities, notices, protests, and itdashboard, all now closed by a regenerated overlay.
@@ -20,7 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - **`refresh_contract.py` + `probe_shape_types.py` re-run against the corrected contract.** `contracts/observed_shape_types.json` gained live-sampled types for the five newly-visible resources (entities alone contributes 136 observed paths), so the regenerated overlay resolves their types from real API responses rather than name heuristics.
 
 ### Changed
-- `CONTRACT_OMITTED_PARAMS` now warns when an entry is no longer needed, mirroring how baseline entries are burned down. Added `mas_sins: search` — the API applies it (330 results unfiltered, 0 for a nonsense term, 32 for `office`) but the contract records `filter_params: []`, so the checker would otherwise flag a working parameter as a silent no-op and invite its removal. Dropped `budget/accounts: search`, which makegov/tango#2944's `SearchFilter` extraction now publishes.
+- `CONTRACT_OMITTED_PARAMS` now warns when an entry is no longer needed, mirroring how baseline entries are burned down, and the list is now **empty** — which is the goal state. It briefly held `mas_sins: search`, added because the API applies it (330 results unfiltered, 0 for a nonsense term, 32 for `office`) while the contract recorded `filter_params: []`, so the checker would otherwise have flagged a working parameter as a silent no-op and invited its removal. Both that entry and `budget/accounts: search` were retired by the new warning once [makegov/tango#2944](https://github.com/makegov/tango/pull/2944) and [#2948](https://github.com/makegov/tango/pull/2948) taught the contract generator to publish them. The carve-out mechanism stays for the next such case.
 
 ## [1.3.0] - 2026-07-19
 

contracts/filter_shape_contract.json

@@ -4613,8 +4613,15 @@
       "prefix": "mas_sins",
       "resource_key": "mas_sins",
       "runtime": {
-        "filter_params": [],
-        "filter_params_detail": {},
+        "filter_params": [
+          "search"
+        ],
+        "filter_params_detail": {
+          "search": {
+            "filter_class": "ViewHandledParam",
+            "type": "string"
+          }
+        },
         "ordering_aliases": [],
         "ordering_fields": [],
         "pagination": {
@@ -6882,8 +6889,15 @@
       "prefix": "psc",
       "resource_key": "psc",
       "runtime": {
-        "filter_params": [],
-        "filter_params_detail": {},
+        "filter_params": [
+          "has_awards"
+        ],
+        "filter_params_detail": {
+          "has_awards": {
+            "filter_class": "ViewHandledParam",
+            "type": "boolean"
+          }
+        },
         "ordering_aliases": [],
         "ordering_fields": [],
         "pagination": {

scripts/check_filter_shape_conformance.py

@@ -98,15 +98,11 @@
 # removed once Tango's generator surfaces it — `check_conformance` warns when an
 # entry is no longer needed, so this list cannot quietly rot.
 #
-#   mas_sins `search`: verified 2026-07-20 — 330 results unfiltered vs 0 for a
-#   nonsense term, 32 for "office", 3 for "cloud". The endpoint clearly applies
-#   it, and the contract records `filter_params: []` for the resource.
-#
-# (budget/accounts `search` lived here until 2026-07-20; makegov/tango#2944's
-# SearchFilter extraction now publishes it, so the carve-out was removed.)
-CONTRACT_OMITTED_PARAMS: dict[str, frozenset[str]] = {
-    "mas_sins": frozenset({"search"}),
-}
+# Currently empty, and that is the goal state. Two entries have come and gone:
+# budget/accounts `search` (published by makegov/tango#2944's SearchFilter
+# extraction) and mas_sins `search` (published by makegov/tango#2948's
+# `view_handled_params` declaration). Both were retired by the warning above.
+CONTRACT_OMITTED_PARAMS: dict[str, frozenset[str]] = {}
 
 # SDK-level conveniences that never correspond to API filter params.
 # `sort`/`order` compose into the API's `ordering`; `filters` is the legacy

tango/client.py

@@ -4448,15 +4448,22 @@ def list_psc(
         shape: str | None = None,
         flat: bool = False,
         flat_lists: bool = False,
+        has_awards: bool | None = None,
     ) -> PaginatedResponse[dict[str, Any]]:
-        """List Product Service Codes (`/api/psc/`)."""
+        """List Product Service Codes (`/api/psc/`).
+
+        Args:
+            has_awards: When True, return only codes with contract award history.
+        """
         params: dict[str, Any] = {"page": page, "limit": min(limit, 100)}
         if shape:
             params["shape"] = shape
             if flat:
                 params["flat"] = "true"
             if flat_lists:
                 params["flat_lists"] = "true"
+        if has_awards is not None:
+            params["has_awards"] = "true" if has_awards else "false"
         data = self._get("/api/psc/", params)
         return PaginatedResponse(
             count=int(data.get("count", 0)),

tests/test_client.py

@@ -1949,3 +1949,44 @@ def test_list_protests_omits_unset_naics_code(self, mock_request):
         client.list_protests()
 
         assert "naics_code" not in mock_request.call_args[1]["params"]
+
+
+def _stub_empty_page(mock_request):
+    """Wire a mocked httpx response for an empty paginated result."""
+    mock_response = Mock()
+    mock_response.is_success = True
+    mock_response.status_code = 200
+    mock_response.json.return_value = {
+        "count": 0,
+        "next": None,
+        "previous": None,
+        "results": [],
+    }
+    mock_response.content = b'{"count": 0}'
+    mock_request.return_value = mock_response
+
+
+class TestPscFilters:
+    """`has_awards` reached the SDK only after makegov/tango#2948 published it.
+
+    The param filtered for real but was absent from the contract, so the conformance check had nothing to compare against and the gap went unreported.
+    """
+
+    @patch("tango.client.httpx.Client.request")
+    def test_list_psc_forwards_has_awards_true(self, mock_request):
+        _stub_empty_page(mock_request)
+        TangoClient(api_key="test-key").list_psc(has_awards=True)
+        assert mock_request.call_args[1]["params"]["has_awards"] == "true"
+
+    @patch("tango.client.httpx.Client.request")
+    def test_list_psc_forwards_has_awards_false(self, mock_request):
+        """False must be sent, not dropped — the API distinguishes them."""
+        _stub_empty_page(mock_request)
+        TangoClient(api_key="test-key").list_psc(has_awards=False)
+        assert mock_request.call_args[1]["params"]["has_awards"] == "false"
+
+    @patch("tango.client.httpx.Client.request")
+    def test_list_psc_omits_unset_has_awards(self, mock_request):
+        _stub_empty_page(mock_request)
+        TangoClient(api_key="test-key").list_psc()
+        assert "has_awards" not in mock_request.call_args[1]["params"]