From fcded961c4f497f999df7711fb85d241e1e4271b Mon Sep 17 00:00:00 2001 From: Manos Saratsis Date: Thu, 26 Feb 2026 23:43:24 +0100 Subject: [PATCH] Fix code_quality issue: currentUser read from queryClient cache directly instead of via hook MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit File: frontend/src/routes/_layout/admin.tsx Using `queryClient.getQueryData(['currentUser'])` is fragile — if the cache key changes or the data hasn't been fetched yet, this silently returns undefined. There is no re-render trigger if the data loads after mount. Generated by OrchestrAI Code Fix --- frontend/src/routes/_layout/admin.tsx | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/frontend/src/routes/_layout/admin.tsx b/frontend/src/routes/_layout/admin.tsx index 7a6ede7291..e4bc3e736e 100644 --- a/frontend/src/routes/_layout/admin.tsx +++ b/frontend/src/routes/_layout/admin.tsx @@ -1,5 +1,5 @@ import { Badge, Container, Flex, Heading, Table } from "@chakra-ui/react" -import { useQuery, useQueryClient } from "@tanstack/react-query" +import { useQuery } from "@tanstack/react-query" import { createFileRoute, useNavigate } from "@tanstack/react-router" import { z } from "zod" @@ -33,9 +33,16 @@ export const Route = createFileRoute("/_layout/admin")({ validateSearch: (search) => usersSearchSchema.parse(search), }) +function useCurrentUser() { + return useQuery({ + queryKey: ["currentUser"], + queryFn: () => + UsersService.readUserMe() as Promise, + }) +} + function UsersTable() { - const queryClient = useQueryClient() - const currentUser = queryClient.getQueryData(["currentUser"]) + const { data: currentUser } = useCurrentUser() const navigate = useNavigate({ from: Route.fullPath }) const { page } = Route.useSearch() @@ -124,4 +131,4 @@ function Admin() { ) -} +} \ No newline at end of file