simplification: reduce 8 Qlty smells in pool_ops.py

[marcusquinn]

Qlty Maintainability — .agents/scripts/oauth-pool-lib/pool_ops.py

Smells detected: 8

Rule breakdown

• qlty:file-complexity: 1
• qlty:function-complexity: 4
• qlty:nested-control-flow: 3

This file was flagged by the daily quality sweep for high smell density. The smells are primarily function complexity, nested control flow, and return statement count — all reducible via extract-function refactoring. Prioritise the rules with the highest counts first; they give the biggest grade improvement per edit.

Suggested approach

1. Read the file and identify the highest-complexity functions
2. Extract helper functions to reduce per-function complexity below the threshold (~17)
3. Verify with qlty smells .agents/scripts/oauth-pool-lib/pool_ops.py after each change
4. No behavior changes — pure structural refactoring

Verification

• Syntax check: python3 -c "import ast; ast.parse(open('.agents/scripts/oauth-pool-lib/pool_ops.py').read())" (Python) or node --check .agents/scripts/oauth-pool-lib/pool_ops.py (JS/TS)
• Smell check: qlty smells .agents/scripts/oauth-pool-lib/pool_ops.py --no-snippets --quiet
• No public API changes

Tier

This issue carries tier:thinking by default (t2066, GH#18774). Simplification refactors on high-complexity functions routinely exceed what Sonnet handles reliably, and Haiku cannot handle them at all. Downgrade the tier label only if you have verified the target functions are under cyclomatic 15.

---

To approve or decline, comment on this issue:

• approved — removes the review gate and queues for automated dispatch
• declined: <reason> — closes this issue (include your reason after the colon)

---

aidevops.sh v3.8.24 plugin for OpenCode v1.4.3 with claude-opus-4-6 spent 9m and 37,721 tokens on this as a headless worker.

[github-actions]

Issue held from dispatch. The needs-maintainer-review label prevents the pulse supervisor from dispatching workers for this issue.

When ready to release it for work:

sudo aidevops approve issue 18882

This posts a cryptographic approval comment and removes the label, allowing the pipeline to process the issue on the next pulse cycle.

[marcusquinn]

Maintainer Approval (cryptographically signed)

APPROVE:issue:marcusquinn/aidevops:18882:2026-04-14T18:27:35Z

-----BEGIN SSH SIGNATURE-----
U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgeu2Ii1FVuPun+49v51FONnIskf
TinwsexuL1MNgCwJ8AAAAQYWlkZXZvcHMtYXBwcm92ZQAAAAAAAAAGc2hhNTEyAAAAUwAA
AAtzc2gtZWQyNTUxOQAAAEBYfOgnDjpm69I6kEzjLZ3DmV2t2NBOyWG83QzVMbIgQMZE4Z
EInPf2AVNbwpoKfSDDO2jldcnZCeG/mbbKkJ8K
-----END SSH SIGNATURE-----

This approval was signed with a root-protected SSH key. It cannot be forged by automation.

This issue is now locked. To propose scope changes, open a new issue referencing this one.

[marcusquinn]

DISPATCH_CLAIM nonce=12877544dc2a6cd4618fe8ebd6d65c95 runner=marcusquinn ts=2026-04-14T19:57:33Z max_age_s=1800

[marcusquinn]

Dispatching worker (deterministic).

• Worker PID: 92487
• Model: anthropic/claude-opus-4-6
• Tier: thinking
• Runner: marcusquinn
• Issue: simplification: reduce 8 Qlty smells in pool_ops.py #18882

[marcusquinn]

Premise falsified. Issue cites 8 qlty smells in .agents/scripts/oauth-pool-lib/pool_ops.py (file-complexity, function-complexity, nested-control-flow). The file was already decomposed into per-command modules by PR #18891 (commit 0a28842e3, merged earlier today) — reducing pool_ops.py from 1047 lines to 140 lines and moving cmd_refresh cyclomatic complexity from 72 to ~5. Current smells count: 0, verified with qlty smells --all --no-snippets (pool_ops.py does not appear in output). Not acting.

Closing as duplicate work — the quality sweep that filed this issue ran against a pre-decomposition snapshot.

---

aidevops.sh v3.8.30 plugin for OpenCode v1.4.3 with claude-opus-4-6 spent 1m and 3,393 tokens on this as a headless worker. Solved in 13h 57m.