Problem
In Whatsapp, for example, messages can only be edited for 15 minutes after they are sent.
Currently, there is no feedback to the user when they edit a "too-old" message in a portal; it is only logged.
This could lead them to think the message is edited, but it's not actually edited on the other end of the bridge.
Proposal
- If a user edits an message which is older than
RoomFeatures.EditMaxAge, the user should be notified that the message they tried to edit could not be bridged.
- Ideally, the edit should also be reverted, making the chat more aligned with the bridged chat.
See the line where this check is done here:
|
} else if caps.EditMaxAge != nil && caps.EditMaxAge.Duration > 0 && time.Since(editTarget.Timestamp) > caps.EditMaxAge.Duration { |
|
return EventHandlingResultFailed.WithMSSError(ErrEditTargetTooOld) |
Problem
In Whatsapp, for example, messages can only be edited for 15 minutes after they are sent.
Currently, there is no feedback to the user when they edit a "too-old" message in a portal; it is only logged.
This could lead them to think the message is edited, but it's not actually edited on the other end of the bridge.
Proposal
RoomFeatures.EditMaxAge, the user should be notified that the message they tried to edit could not be bridged.See the line where this check is done here:
go/bridgev2/portal.go
Lines 1278 to 1279 in 3048d2e