Skip to content

No user feedback when matrix-edited message is not sent to remote due to EditMaxAge #404

Description

@Petersmit27

Problem

In Whatsapp, for example, messages can only be edited for 15 minutes after they are sent.
Currently, there is no feedback to the user when they edit a "too-old" message in a portal; it is only logged.
This could lead them to think the message is edited, but it's not actually edited on the other end of the bridge.

Proposal

  • If a user edits an message which is older than RoomFeatures.EditMaxAge, the user should be notified that the message they tried to edit could not be bridged.
  • Ideally, the edit should also be reverted, making the chat more aligned with the bridged chat.

See the line where this check is done here:

go/bridgev2/portal.go

Lines 1278 to 1279 in 3048d2e

} else if caps.EditMaxAge != nil && caps.EditMaxAge.Duration > 0 && time.Since(editTarget.Timestamp) > caps.EditMaxAge.Duration {
return EventHandlingResultFailed.WithMSSError(ErrEditTargetTooOld)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Fields

    No fields configured for Feature.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions