Skip to content

Is there any reason this needs the SPECIFIC three.js version 0.54.0 #8

@chuckhacker

Description

@chuckhacker

Installing all of maxogden's plugins results in three copies of Three.JS (all different versions) as NPM traverses the dependency hierarchy. For example, player-physics requires Three.JS version 0.54.0 (even though just about any Three.JS version has the vector and Object3D classes that it uses). Meanwhile, voxel-engine requires Three.JS version 0.56.0. There should only be one. This happens with other dependencies as well (multiple copies of the same dependency differing in minor version numbers). The problem is that various plugins' package.json files require unnecessarily SPECIFIC versioned dependencies. Unless there is a hard requirement for a very specific version of a dependency, a more permissive version filter should be used (I haven't seen such a requirement in any of the code but all of the package.json files are versioned specifically -- this becomes more of a headache for highly modularized projects like voxel.JS). Overly specific versioned dependencies defeat the purpose of a package manager.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions