Skip to content

Commit ccdf014

Browse files
committed
fixup! STF-322: Add tests for transport-failure retry
1 parent 67c9b42 commit ccdf014

1 file changed

Lines changed: 15 additions & 1 deletion

File tree

src/test/java/com/maxmind/geoip2/WebServiceClientTest.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,13 @@
1515
import static org.junit.jupiter.api.Assertions.assertNull;
1616
import static org.junit.jupiter.api.Assertions.assertThrows;
1717
import static org.junit.jupiter.api.Assertions.assertTrue;
18+
import static org.junit.jupiter.api.Assertions.fail;
1819

1920
import com.github.tomakehurst.wiremock.http.Fault;
2021
import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
2122
import com.github.tomakehurst.wiremock.junit5.WireMockTest;
2223
import com.github.tomakehurst.wiremock.stubbing.Scenario;
24+
import com.github.tomakehurst.wiremock.verification.LoggedRequest;
2325
import com.maxmind.geoip2.exception.AddressNotFoundException;
2426
import com.maxmind.geoip2.exception.AuthenticationException;
2527
import com.maxmind.geoip2.exception.GeoIp2Exception;
@@ -665,7 +667,19 @@ public void testMaxRetriesZeroDisablesRetry() {
665667
assertThrows(Exception.class,
666668
() -> client.insights(InetAddress.getByName("1.2.3.4")));
667669

668-
wireMock.verify(1, getRequestedFor(urlEqualTo(url)));
670+
// DIAGNOSTIC: dump full request details on mismatch so we can
671+
// distinguish JDK-internal retry from h2c upgrade fallback. To be
672+
// reverted once the windows-21 wire-count behavior is understood.
673+
List<LoggedRequest> requests = wireMock.findAll(getRequestedFor(urlEqualTo(url)));
674+
if (requests.size() != 1) {
675+
StringBuilder sb = new StringBuilder("Expected 1 request, got ")
676+
.append(requests.size()).append(":\n");
677+
for (int i = 0; i < requests.size(); i++) {
678+
sb.append("--- Request ").append(i + 1).append(" ---\n")
679+
.append(requests.get(i).toString()).append("\n");
680+
}
681+
fail(sb.toString());
682+
}
669683
}
670684

671685
@Test

0 commit comments

Comments
 (0)