Version 1.0.34 is not building on Ubuntu 19.10

[PanderMusubi]

Version 1.0.34 is not building on Ubuntu 19.10, please see

cd depends
make
...
  CC       fcmatch.lo
fcmatch.c:284:63: error: 'PRI_CHAR_WIDTH_STRONG' undeclared here (not in a function); did you mean 'PRI_CHAR_HEIGHT_STRONG'?
  284 | #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
      |                                                               ^~~~
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
   54 | FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
      | ^~~~~~~~~
fcmatch.c:284:84: error: 'PRI_CHAR_WIDTH_WEAK' undeclared here (not in a function); did you mean 'PRI_CHAR_HEIGHT_WEAK'?
  284 | #define FC_OBJECT(NAME, Type, Cmp) { FC_##NAME##_OBJECT, Cmp, PRI_##NAME##_STRONG, PRI_##NAME##_WEAK },
      |                                                                                    ^~~~
fcobjs.h:54:1: note: in expansion of macro 'FC_OBJECT'
   54 | FC_OBJECT (CHAR_WIDTH,  FcTypeInteger, NULL)
      | ^~~~~~~~~
make[4]: *** [Makefile:613: fcmatch.lo] Error 1
...

See also dogecoin/dogecoin#1553 and other searches for this error.

[PanderMusubi]

Before building can start, also do

cd depends
chmod 764  ./config.guess
chmod 764  ./config.sub

this should also be fixed.

[PanderMusubi]

The build instructions in the REAME.md should start with

cd depends
make
cd ..

[mceme]

check build instructions to Linux :

https://github.com/mceme/ImageCoin/blob/master/doc/build-unix.md

[PanderMusubi]

For the latest commit in git, also this is needed:

chmod 764  ./config.guess && chmod 764  ./config.sub

At the moment, building release 1.0.34 build depends properly but is stuck at:

./configure
checking for Berkeley DB C++ headers... no
configure: error: libdb_cxx headers missing, ImageCoin Core requires this library for wallet functionality (--disable-wallet to disable wallet functionality)

When I follow the instructions and build Berkeley accordingly, that stopts at

make install
In file included from ../dist/../dbinc/mutex_int.h:12,
                 from ../dist/../dbinc/mutex.h:15,
                 from ./db_int.h:884,
                 from ../dist/../cxx/cxx_db.cpp:11:
../dist/../dbinc/atomic.h:179:19: error: definition of ‘int __atomic_compare_exchange(db_atomic_t*, atomic_value_t, atomic_value_t)’ ambiguates built-in declaration ‘bool __atomic_compare_exchange(long unsigned int, volatile void*, void*, void*, int, int)’
  179 | static inline int __atomic_compare_exchange(
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:2018: cxx_db.o] Error 1

and the latest commit is stuck at in building depends with the same error as above:

make QT_NO=1
...
fcmatch.c:284:63: error: 'PRI_CHAR_WIDTH_STRONG' undeclared here (not in a function); did you mean 'PRI_CHAR_HEIGHT_STRONG'?

I have build a lot of Dash wallets, also for ARM, so I know my way around these builds reasonably. As This is a Dash fork, perhaps rebase on a newer version of Dash where these problems also were but have been solved a while ago. I have tried building the latest release and the latest commit on two different machines with the same results. Can you reproduce this?

For stable Ubuntu releases, I'd expect that building this wallet would only involve the standard make in depends and then the normal autogen, configure and make.