File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -39,15 +39,14 @@ struct ValidatedArtifact {
3939struct ValidationReport {
4040 std::vector<ValidatedArtifact> artifacts;
4141
42- // Any artifact PROVEN bad — payloads mixed, or a DT_NEEDED that the
43- // artifact's own loader will not find. Asks the verdict rather than
44- // enumerating states here, so a fifth state cannot be added without this
45- // gate deciding what it means.
46- bool has_blocking_failure () const {
47- return std::ranges::any_of (artifacts, [](auto const & artifact) {
48- return artifact.verdict .blocking ();
49- });
50- }
42+ // NOTE: there is deliberately no `has_blocking_failure()` here.
43+ //
44+ // There used to be a `has_proven_mismatch()`, and nothing ever called it —
45+ // the real gate walks the artifacts in `ninja_backend` so it can name WHICH
46+ // one failed and print its explanation. A second predicate that answers
47+ // "did anything fail" from the same data is the same decision in two
48+ // places, and the one with no callers is the one that silently stops
49+ // agreeing. Ask `verdict.blocking()` per artifact.
5150};
5251
5352struct StoredRuntimeSummary {
You can’t perform that action at this time.
0 commit comments