Skip to content

Commit 9951157

Browse files
committed
test(e2e): don't let wait on the killed holder abort 171 (exit 143)
`wait` on a job we just killed returns 143, and it sat as the last command of an `&&` list under `set -e` — so on Windows the script died the moment the mapping was released, before asserting anything about the build it had just run. Probed the shell semantics directly rather than guessing: the old form exits 143 on Linux too, it only never ran there because HOLDER is empty on POSIX.
1 parent cb7f3df commit 9951157

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

tests/e2e/171_bmi_staging_locked_dest.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,10 @@ set +e
8989
"$MCPP" build -v > build2.log 2>&1
9090
rc=$?
9191
set -e
92-
[[ -n "$HOLDER" ]] && { kill "$HOLDER" 2>/dev/null; wait "$HOLDER" 2>/dev/null; }
92+
# `wait` on a job we just killed returns 143, and under `set -e` that would
93+
# abort the script right here — with the build's own result never asserted.
94+
# (Exactly how this test failed on Windows the first time it got that far.)
95+
[[ -n "$HOLDER" ]] && { kill "$HOLDER" 2>/dev/null || true; wait "$HOLDER" 2>/dev/null || true; }
9396
chmod 644 "$DST" 2>/dev/null || true
9497

9598
if [[ $rc -ne 0 ]]; then

0 commit comments

Comments
 (0)