Commit afca9d5
committed
test(e2e): stop the wine teardown from failing a passing test
`cross-build-test` went red on main at 0006ce6 (run 31336526583) with a log
that ends:
OK
rm: cannot remove '/tmp/tmp.XgyezkVtrY/wineprefix': Directory not empty
The test passed. `wine` leaves a wineserver running after the process it
launched exits, and that server keeps writing into $WINEPREFIX, so the
EXIT trap's `rm -rf` races it. Under `set -e` the failing trap becomes the
script's exit status, so a green test reports as a red job — and the
verdict it reports is about a temp directory, not about mcpp.
Shut the server down and wait for it before deleting, and let cleanup
keep the status the test already earned. Cleanup runs after the verdict is
printed; it has no business changing it.1 parent 0006ce6 commit afca9d5
1 file changed
Lines changed: 22 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
13 | 34 | | |
14 | 35 | | |
15 | 36 | | |
| |||
0 commit comments