Commit ec34195
committed
fix: restore the project's toolchain default, and stop assuming it is installed
mcpp.toml's `[toolchain] default` went from gcc@16.1.0 to llvm@22.1.8 in the
previous commit. Not deliberate -- a local experiment wrote it and `git add -A`
carried it along. The whole repository then built with llvm, and five CI jobs
failed on assertions that name gcc:
toolchain: gcc (cold self-host) grep -q "Resolved gcc@16.1.0"
toolchain: musl + llvm sed expects `default = "gcc@16.1.0"`
integration / e2e 1-2 (linux) `gcc@16.1.0 is not installed`
Verified back to exactly one difference from main: the version.
The e2e job's failure had a second cause worth fixing on its own. It runs
`toolchain default gcc@16.1.0` without ever installing gcc, so it depends on
the sandbox cache happening to carry one from an earlier run. That is not a
property any job should rely on, and this branch's xlings pin bump moved the
whole cache-key prefix, so every shard started cold and hit it. Now installed
explicitly; warm runs pay a lookup.
67 unit tests; e2e 201/86/29/103/179/200 under the restored gcc default.1 parent b87a438 commit ec34195
2 files changed
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
81 | 91 | | |
82 | 92 | | |
83 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
0 commit comments