From d830b9a2f37d98f0612d017f69c905624ae15784 Mon Sep 17 00:00:00 2001 From: ashish Date: Sat, 28 Mar 2026 10:07:26 +0530 Subject: [PATCH 1/6] code updated with new method --- .code-samples.meilisearch.yaml | 2 ++ src/main/java/com/meilisearch/sdk/Client.java | 13 +++++++++++++ .../java/com/meilisearch/sdk/TasksHandler.java | 14 +++++++++++++- 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index 2d42497c..3991a1eb 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -70,6 +70,8 @@ get_all_tasks_1: |- client.getTasks(); get_task_1: |- client.getTask(1); +get_task_documents_1: |- + client.getTaskDocuments(1); delete_tasks_1: |- DeleteTasksQuery query = new DeleteTasksQuery().setUids(new int[] {1, 2}) client.deleteTasks(query); diff --git a/src/main/java/com/meilisearch/sdk/Client.java b/src/main/java/com/meilisearch/sdk/Client.java index 37e250eb..6b92b3ea 100644 --- a/src/main/java/com/meilisearch/sdk/Client.java +++ b/src/main/java/com/meilisearch/sdk/Client.java @@ -299,6 +299,19 @@ public Task getTask(int uid) throws MeilisearchException { return this.tasksHandler.getTask(uid); } + /** + * Retrieves the documents of a task with the specified uid + * + * @param uid Identifier of the requested Task + * @return Meilisearch API response as NDJSON String + * @throws MeilisearchException if an error occurs + * @see API + * specification + */ + public String getTaskDocuments(int uid) throws MeilisearchException { + return this.tasksHandler.getTaskDocuments(uid); + } + /** * Retrieves list of tasks * diff --git a/src/main/java/com/meilisearch/sdk/TasksHandler.java b/src/main/java/com/meilisearch/sdk/TasksHandler.java index 3692d919..4af7c655 100644 --- a/src/main/java/com/meilisearch/sdk/TasksHandler.java +++ b/src/main/java/com/meilisearch/sdk/TasksHandler.java @@ -39,6 +39,19 @@ Task getTask(int taskUid) throws MeilisearchException { return httpClient.get(urlPath, Task.class); } + /** + * Retrieves the documents of a task with the specified task uid + * + * @param taskUid Identifier of the requested Task + * @return String (NDJSON) of documents processed by the task + * @throws MeilisearchException if client request causes an error + */ + String getTaskDocuments(int taskUid) throws MeilisearchException { + URLBuilder urlb = new URLBuilder(); + urlb.addSubroute("tasks").addSubroute(Integer.toString(taskUid)).addSubroute("documents"); + String urlPath = urlb.getURL(); + return httpClient.get(urlPath, String.class); + } /** * Retrieves all tasks from the client * @@ -160,7 +173,6 @@ void waitForTask(int taskUid, int timeoutInMs, int intervalInMs) throws Meilisea elapsedTime = new Date().getTime() - startTime; } } - /** * Retrieves a batch by uid. * From 752048293950428a365e4e7a85b879ef9b0c7873 Mon Sep 17 00:00:00 2001 From: ashish Date: Sat, 28 Mar 2026 13:18:44 +0530 Subject: [PATCH 2/6] junit added by claude --- .../meilisearch/integration/TasksTest.java | 198 ++++++++++++++++++ 1 file changed, 198 insertions(+) diff --git a/src/test/java/com/meilisearch/integration/TasksTest.java b/src/test/java/com/meilisearch/integration/TasksTest.java index 391b57ca..536f1275 100644 --- a/src/test/java/com/meilisearch/integration/TasksTest.java +++ b/src/test/java/com/meilisearch/integration/TasksTest.java @@ -2,6 +2,7 @@ import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.blankOrNullString; +import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.greaterThanOrEqualTo; import static org.hamcrest.Matchers.instanceOf; @@ -14,6 +15,7 @@ import com.meilisearch.integration.classes.AbstractIT; import com.meilisearch.integration.classes.TestData; import com.meilisearch.sdk.Index; +import com.meilisearch.sdk.exceptions.MeilisearchException; import com.meilisearch.sdk.model.*; import com.meilisearch.sdk.utils.Movie; import java.time.Instant; @@ -356,4 +358,200 @@ public void testTasksWithJacksonJsonHandler() throws Exception { assertThat(task.getStatus(), is(equalTo(TaskStatus.ENQUEUED))); } + + /** Test Get Task Documents - Successful case with documents */ + @Test + public void testGetTaskDocumentsSuccess() throws Exception { + String indexUid = "GetTaskDocumentsSuccess"; + Index index = createEmptyIndex(indexUid, "id"); + + // Add documents to the index + String documentsJson = "[{\"id\": 1, \"title\": \"Test Document 1\"}," + + "{\"id\": 2, \"title\": \"Test Document 2\"}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + // Get task documents + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, not(blankOrNullString())); + assertThat(taskDocuments, containsString("id")); + } + + /** Test Get Task Documents - Returns NDJSON format */ + @Test + public void testGetTaskDocumentsFormatNDJSON() throws Exception { + String indexUid = "GetTaskDocumentsFormatNDJSON"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 1, \"name\": \"Alice\"}," + + "{\"id\": 2, \"name\": \"Bob\"}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + // NDJSON format has each object on a separate line + String[] lines = taskDocuments.split("\n"); + assertThat(lines.length, is(greaterThanOrEqualTo(1))); + + // Each line should be a valid JSON object + for (String line : lines) { + if (!line.trim().isEmpty()) { + assertThat(line, containsString("{")); + assertThat(line, containsString("}")); + } + } + } + + /** Test Get Task Documents - Empty result when no documents processed */ + @Test + public void testGetTaskDocumentsEmpty() throws Exception { + String indexUid = "GetTaskDocumentsEmpty"; + TaskInfo taskInfo = client.createIndex(indexUid); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + // Create index task should not have documents + assertThat(taskDocuments, is(notNullValue())); + } + + /** Test Get Task Documents - Multiple documents */ + @Test + public void testGetTaskDocumentsMultipleDocuments() throws Exception { + String indexUid = "GetTaskDocumentsMultipleDocuments"; + Index index = createEmptyIndex(indexUid, "id"); + + String[] documentsList = new String[3]; + for (int i = 1; i <= 3; i++) { + documentsList[i - 1] = "{\"id\": " + i + ", \"title\": \"Document " + i + "\"}"; + } + String documentsJson = "[" + String.join(",", documentsList) + "]"; + + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, not(blankOrNullString())); + } + + /** Test Get Task Documents - With different document types */ + @Test + public void testGetTaskDocumentsWithDifferentDataTypes() throws Exception { + String indexUid = "GetTaskDocumentsWithDifferentDataTypes"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 1, \"title\": \"Test\", \"active\": true, \"score\": 9.5}," + + "{\"id\": 2, \"title\": \"Test2\", \"active\": false, \"score\": 8.2}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, not(blankOrNullString())); + } + + /** Test Get Task Documents - After successful task completion */ + @Test + public void testGetTaskDocumentsAfterTaskCompletion() throws Exception { + String indexUid = "GetTaskDocumentsAfterTaskCompletion"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 100, \"data\": \"Sample Data\"}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + + // Wait for task to complete + client.waitForTask(taskInfo.getTaskUid()); + Task completedTask = client.getTask(taskInfo.getTaskUid()); + + assertThat(completedTask.getStatus(), is(equalTo(TaskStatus.SUCCEEDED))); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + } + + /** Test Get Task Documents - Returns instance of String */ + @Test + public void testGetTaskDocumentsReturnsString() throws Exception { + String indexUid = "GetTaskDocumentsReturnsString"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 1, \"content\": \"Test Content\"}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(instanceOf(String.class))); + } + + /** Test Get Task Documents - With complex nested documents */ + @Test + public void testGetTaskDocumentsWithNestedDocuments() throws Exception { + String indexUid = "GetTaskDocumentsWithNestedDocuments"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 1, \"author\": {\"name\": \"John\", \"email\": \"john@example.com\"}, " + + "\"tags\": [\"tech\", \"java\"]}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, not(blankOrNullString())); + } + + /** Test Get Task Documents - Throws exception for invalid task uid */ + @Test + public void testGetTaskDocumentsInvalidTaskUid() throws Exception { + // Try to get documents for a non-existent task uid + assertThrows(MeilisearchException.class, () -> client.getTaskDocuments(999999)); + } + + /** Test Get Task Documents - With bulk document addition */ + @Test + public void testGetTaskDocumentsWithBulkDocuments() throws Exception { + String indexUid = "GetTaskDocumentsWithBulkDocuments"; + Index index = createEmptyIndex(indexUid, "id"); + + // Create a bulk of documents + StringBuilder documentsBuilder = new StringBuilder("["); + for (int i = 1; i <= 10; i++) { + if (i > 1) documentsBuilder.append(","); + documentsBuilder.append("{\"id\": ").append(i).append(", \"value\": \"Item ").append(i).append("\"}"); + } + documentsBuilder.append("]"); + + TaskInfo taskInfo = index.addDocuments(documentsBuilder.toString()); + client.waitForTask(taskInfo.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, not(blankOrNullString())); + } + + /** Test Get Task Documents - Consistency check */ + @Test + public void testGetTaskDocumentsConsistency() throws Exception { + String indexUid = "GetTaskDocumentsConsistency"; + Index index = createEmptyIndex(indexUid, "id"); + + String documentsJson = "[{\"id\": 1, \"title\": \"Consistent Test\"}]"; + TaskInfo taskInfo = index.addDocuments(documentsJson); + client.waitForTask(taskInfo.getTaskUid()); + + // Get documents multiple times to ensure consistency + String taskDocuments1 = client.getTaskDocuments(taskInfo.getTaskUid()); + String taskDocuments2 = client.getTaskDocuments(taskInfo.getTaskUid()); + + assertThat(taskDocuments1, is(equalTo(taskDocuments2))); + } } From ebc3439cfc2a02c4d32d4c742d6bfe40a93fd749 Mon Sep 17 00:00:00 2001 From: ashish Date: Sat, 28 Mar 2026 13:25:05 +0530 Subject: [PATCH 3/6] review fix --- src/test/java/com/meilisearch/integration/TasksTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/meilisearch/integration/TasksTest.java b/src/test/java/com/meilisearch/integration/TasksTest.java index 536f1275..20a18455 100644 --- a/src/test/java/com/meilisearch/integration/TasksTest.java +++ b/src/test/java/com/meilisearch/integration/TasksTest.java @@ -512,7 +512,8 @@ public void testGetTaskDocumentsWithNestedDocuments() throws Exception { @Test public void testGetTaskDocumentsInvalidTaskUid() throws Exception { // Try to get documents for a non-existent task uid - assertThrows(MeilisearchException.class, () -> client.getTaskDocuments(999999)); + int invalidTaskUid = Integer.MAX_VALUE; + assertThrows(MeilisearchException.class, () -> client.getTaskDocuments(invalidTaskUid)); } /** Test Get Task Documents - With bulk document addition */ From a1664feea69427b3d76c3bf1449706ddcb95fd0b Mon Sep 17 00:00:00 2001 From: ashish Date: Mon, 30 Mar 2026 12:05:31 +0530 Subject: [PATCH 4/6] test cases --- .../meilisearch/integration/ClientTest.java | 21 ++ .../meilisearch/integration/TasksTest.java | 199 ------------------ 2 files changed, 21 insertions(+), 199 deletions(-) diff --git a/src/test/java/com/meilisearch/integration/ClientTest.java b/src/test/java/com/meilisearch/integration/ClientTest.java index 62a31311..ce1fcb14 100644 --- a/src/test/java/com/meilisearch/integration/ClientTest.java +++ b/src/test/java/com/meilisearch/integration/ClientTest.java @@ -376,4 +376,25 @@ public void testCompactWithDocuments() throws Exception { assertThat(index.getDocument("1", Movie.class).getTitle(), is(equalTo("Document1"))); assertThat(index.getDocument("2", Movie.class).getTitle(), is(equalTo("Document2"))); } + + /** Test getTaskDocuments */ + @Test + public void testGetTaskDocuments() throws Exception { + String indexUid = "GetTaskDocuments"; + Index index = createEmptyIndex(indexUid, this.primaryKey); + + TaskInfo addTask = + index.addDocuments( + "[{" + + "\"id\": 1," + + "\"title\": \"Document1\"" + + "}]"); + index.waitForTask(addTask.getTaskUid()); + + String taskDocuments = client.getTaskDocuments(addTask.getTaskUid()); + + assertThat(taskDocuments, is(notNullValue())); + assertThat(taskDocuments, containsString("\"id\"")); + } + } diff --git a/src/test/java/com/meilisearch/integration/TasksTest.java b/src/test/java/com/meilisearch/integration/TasksTest.java index 20a18455..391b57ca 100644 --- a/src/test/java/com/meilisearch/integration/TasksTest.java +++ b/src/test/java/com/meilisearch/integration/TasksTest.java @@ -2,7 +2,6 @@ import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.blankOrNullString; -import static org.hamcrest.Matchers.containsString; import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.greaterThanOrEqualTo; import static org.hamcrest.Matchers.instanceOf; @@ -15,7 +14,6 @@ import com.meilisearch.integration.classes.AbstractIT; import com.meilisearch.integration.classes.TestData; import com.meilisearch.sdk.Index; -import com.meilisearch.sdk.exceptions.MeilisearchException; import com.meilisearch.sdk.model.*; import com.meilisearch.sdk.utils.Movie; import java.time.Instant; @@ -358,201 +356,4 @@ public void testTasksWithJacksonJsonHandler() throws Exception { assertThat(task.getStatus(), is(equalTo(TaskStatus.ENQUEUED))); } - - /** Test Get Task Documents - Successful case with documents */ - @Test - public void testGetTaskDocumentsSuccess() throws Exception { - String indexUid = "GetTaskDocumentsSuccess"; - Index index = createEmptyIndex(indexUid, "id"); - - // Add documents to the index - String documentsJson = "[{\"id\": 1, \"title\": \"Test Document 1\"}," + - "{\"id\": 2, \"title\": \"Test Document 2\"}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - // Get task documents - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, not(blankOrNullString())); - assertThat(taskDocuments, containsString("id")); - } - - /** Test Get Task Documents - Returns NDJSON format */ - @Test - public void testGetTaskDocumentsFormatNDJSON() throws Exception { - String indexUid = "GetTaskDocumentsFormatNDJSON"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 1, \"name\": \"Alice\"}," + - "{\"id\": 2, \"name\": \"Bob\"}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - // NDJSON format has each object on a separate line - String[] lines = taskDocuments.split("\n"); - assertThat(lines.length, is(greaterThanOrEqualTo(1))); - - // Each line should be a valid JSON object - for (String line : lines) { - if (!line.trim().isEmpty()) { - assertThat(line, containsString("{")); - assertThat(line, containsString("}")); - } - } - } - - /** Test Get Task Documents - Empty result when no documents processed */ - @Test - public void testGetTaskDocumentsEmpty() throws Exception { - String indexUid = "GetTaskDocumentsEmpty"; - TaskInfo taskInfo = client.createIndex(indexUid); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - // Create index task should not have documents - assertThat(taskDocuments, is(notNullValue())); - } - - /** Test Get Task Documents - Multiple documents */ - @Test - public void testGetTaskDocumentsMultipleDocuments() throws Exception { - String indexUid = "GetTaskDocumentsMultipleDocuments"; - Index index = createEmptyIndex(indexUid, "id"); - - String[] documentsList = new String[3]; - for (int i = 1; i <= 3; i++) { - documentsList[i - 1] = "{\"id\": " + i + ", \"title\": \"Document " + i + "\"}"; - } - String documentsJson = "[" + String.join(",", documentsList) + "]"; - - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, not(blankOrNullString())); - } - - /** Test Get Task Documents - With different document types */ - @Test - public void testGetTaskDocumentsWithDifferentDataTypes() throws Exception { - String indexUid = "GetTaskDocumentsWithDifferentDataTypes"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 1, \"title\": \"Test\", \"active\": true, \"score\": 9.5}," + - "{\"id\": 2, \"title\": \"Test2\", \"active\": false, \"score\": 8.2}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, not(blankOrNullString())); - } - - /** Test Get Task Documents - After successful task completion */ - @Test - public void testGetTaskDocumentsAfterTaskCompletion() throws Exception { - String indexUid = "GetTaskDocumentsAfterTaskCompletion"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 100, \"data\": \"Sample Data\"}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - - // Wait for task to complete - client.waitForTask(taskInfo.getTaskUid()); - Task completedTask = client.getTask(taskInfo.getTaskUid()); - - assertThat(completedTask.getStatus(), is(equalTo(TaskStatus.SUCCEEDED))); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - } - - /** Test Get Task Documents - Returns instance of String */ - @Test - public void testGetTaskDocumentsReturnsString() throws Exception { - String indexUid = "GetTaskDocumentsReturnsString"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 1, \"content\": \"Test Content\"}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(instanceOf(String.class))); - } - - /** Test Get Task Documents - With complex nested documents */ - @Test - public void testGetTaskDocumentsWithNestedDocuments() throws Exception { - String indexUid = "GetTaskDocumentsWithNestedDocuments"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 1, \"author\": {\"name\": \"John\", \"email\": \"john@example.com\"}, " + - "\"tags\": [\"tech\", \"java\"]}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, not(blankOrNullString())); - } - - /** Test Get Task Documents - Throws exception for invalid task uid */ - @Test - public void testGetTaskDocumentsInvalidTaskUid() throws Exception { - // Try to get documents for a non-existent task uid - int invalidTaskUid = Integer.MAX_VALUE; - assertThrows(MeilisearchException.class, () -> client.getTaskDocuments(invalidTaskUid)); - } - - /** Test Get Task Documents - With bulk document addition */ - @Test - public void testGetTaskDocumentsWithBulkDocuments() throws Exception { - String indexUid = "GetTaskDocumentsWithBulkDocuments"; - Index index = createEmptyIndex(indexUid, "id"); - - // Create a bulk of documents - StringBuilder documentsBuilder = new StringBuilder("["); - for (int i = 1; i <= 10; i++) { - if (i > 1) documentsBuilder.append(","); - documentsBuilder.append("{\"id\": ").append(i).append(", \"value\": \"Item ").append(i).append("\"}"); - } - documentsBuilder.append("]"); - - TaskInfo taskInfo = index.addDocuments(documentsBuilder.toString()); - client.waitForTask(taskInfo.getTaskUid()); - - String taskDocuments = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, not(blankOrNullString())); - } - - /** Test Get Task Documents - Consistency check */ - @Test - public void testGetTaskDocumentsConsistency() throws Exception { - String indexUid = "GetTaskDocumentsConsistency"; - Index index = createEmptyIndex(indexUid, "id"); - - String documentsJson = "[{\"id\": 1, \"title\": \"Consistent Test\"}]"; - TaskInfo taskInfo = index.addDocuments(documentsJson); - client.waitForTask(taskInfo.getTaskUid()); - - // Get documents multiple times to ensure consistency - String taskDocuments1 = client.getTaskDocuments(taskInfo.getTaskUid()); - String taskDocuments2 = client.getTaskDocuments(taskInfo.getTaskUid()); - - assertThat(taskDocuments1, is(equalTo(taskDocuments2))); - } } From 9dae2d9c368eee6e360739991470acc18c6a9532 Mon Sep 17 00:00:00 2001 From: ashish Date: Mon, 30 Mar 2026 12:31:19 +0530 Subject: [PATCH 5/6] test cases --- .../java/com/meilisearch/integration/ClientTest.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/meilisearch/integration/ClientTest.java b/src/test/java/com/meilisearch/integration/ClientTest.java index ce1fcb14..61b01985 100644 --- a/src/test/java/com/meilisearch/integration/ClientTest.java +++ b/src/test/java/com/meilisearch/integration/ClientTest.java @@ -390,11 +390,17 @@ public void testGetTaskDocuments() throws Exception { + "\"title\": \"Document1\"" + "}]"); index.waitForTask(addTask.getTaskUid()); - String taskDocuments = client.getTaskDocuments(addTask.getTaskUid()); assertThat(taskDocuments, is(notNullValue())); - assertThat(taskDocuments, containsString("\"id\"")); + String[] lines = taskDocuments.split("\n"); + assertThat(lines.length, is(greaterThan(0))); + JsonObject firstDocument = JsonParser.parseString(lines[0]).getAsJsonObject(); + assertThat(firstDocument.has("id"), is(true)); + assertThat(firstDocument.has("title"), is(true)); + assertThat(firstDocument.get("id").getAsInt(), is(equalTo(1))); + assertThat(firstDocument.get("title").getAsString(), is(equalTo("Document1"))); + } } From d0158481be08d15fb432448ded15500c6c3249ff Mon Sep 17 00:00:00 2001 From: ashish Date: Mon, 30 Mar 2026 12:55:02 +0530 Subject: [PATCH 6/6] test cases --- src/main/java/com/meilisearch/sdk/SearchRequest.java | 1 + src/main/java/com/meilisearch/sdk/SettingsHandler.java | 1 + src/main/java/com/meilisearch/sdk/TasksHandler.java | 2 ++ .../java/com/meilisearch/sdk/json/JacksonJsonHandler.java | 4 +++- src/test/java/com/meilisearch/integration/ClientTest.java | 8 +------- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/meilisearch/sdk/SearchRequest.java b/src/main/java/com/meilisearch/sdk/SearchRequest.java index 43e043cc..b70997f6 100644 --- a/src/main/java/com/meilisearch/sdk/SearchRequest.java +++ b/src/main/java/com/meilisearch/sdk/SearchRequest.java @@ -46,6 +46,7 @@ public class SearchRequest { protected Hybrid hybrid; protected Double[] vector; protected Boolean retrieveVectors; + /** * Constructor for SearchRequest for building search queries with the default values: offset: 0, * limit: 20, attributesToRetrieve: ["*"], attributesToCrop: null, cropLength: 200, diff --git a/src/main/java/com/meilisearch/sdk/SettingsHandler.java b/src/main/java/com/meilisearch/sdk/SettingsHandler.java index 1a20056b..ec8102f9 100644 --- a/src/main/java/com/meilisearch/sdk/SettingsHandler.java +++ b/src/main/java/com/meilisearch/sdk/SettingsHandler.java @@ -423,6 +423,7 @@ TaskInfo updateSortableAttributesSettings(String uid, String[] sortableAttribute : sortableAttributes, TaskInfo.class); } + /** * Resets the sortable attributes of the index * diff --git a/src/main/java/com/meilisearch/sdk/TasksHandler.java b/src/main/java/com/meilisearch/sdk/TasksHandler.java index 4af7c655..e2e03cad 100644 --- a/src/main/java/com/meilisearch/sdk/TasksHandler.java +++ b/src/main/java/com/meilisearch/sdk/TasksHandler.java @@ -52,6 +52,7 @@ String getTaskDocuments(int taskUid) throws MeilisearchException { String urlPath = urlb.getURL(); return httpClient.get(urlPath, String.class); } + /** * Retrieves all tasks from the client * @@ -173,6 +174,7 @@ void waitForTask(int taskUid, int timeoutInMs, int intervalInMs) throws Meilisea elapsedTime = new Date().getTime() - startTime; } } + /** * Retrieves a batch by uid. * diff --git a/src/main/java/com/meilisearch/sdk/json/JacksonJsonHandler.java b/src/main/java/com/meilisearch/sdk/json/JacksonJsonHandler.java index 3031fa6d..29d269b1 100644 --- a/src/main/java/com/meilisearch/sdk/json/JacksonJsonHandler.java +++ b/src/main/java/com/meilisearch/sdk/json/JacksonJsonHandler.java @@ -29,7 +29,9 @@ public JacksonJsonHandler() { registerFilterableAttributesModule(this.mapper); } - /** @param mapper ObjectMapper */ + /** + * @param mapper ObjectMapper + */ public JacksonJsonHandler(ObjectMapper mapper) { this.mapper = mapper; registerFilterableAttributesModule(this.mapper); diff --git a/src/test/java/com/meilisearch/integration/ClientTest.java b/src/test/java/com/meilisearch/integration/ClientTest.java index 61b01985..0dfad088 100644 --- a/src/test/java/com/meilisearch/integration/ClientTest.java +++ b/src/test/java/com/meilisearch/integration/ClientTest.java @@ -384,11 +384,7 @@ public void testGetTaskDocuments() throws Exception { Index index = createEmptyIndex(indexUid, this.primaryKey); TaskInfo addTask = - index.addDocuments( - "[{" - + "\"id\": 1," - + "\"title\": \"Document1\"" - + "}]"); + index.addDocuments("[{" + "\"id\": 1," + "\"title\": \"Document1\"" + "}]"); index.waitForTask(addTask.getTaskUid()); String taskDocuments = client.getTaskDocuments(addTask.getTaskUid()); @@ -400,7 +396,5 @@ public void testGetTaskDocuments() throws Exception { assertThat(firstDocument.has("title"), is(true)); assertThat(firstDocument.get("id").getAsInt(), is(equalTo(1))); assertThat(firstDocument.get("title").getAsString(), is(equalTo("Document1"))); - } - }