Skip to content

Commit d8034ca

Browse files
dmealingclaude
andcommitted
CLEANUP: Replace System.out with Proper SLF4J Logging
Replace all System.out console output in production code with proper SLF4J logging: PROVIDER REGISTRATION MESSAGES (7 files): • AttributeTypesMetaDataProvider: System.out → log.info • CoreTypeMetaDataProvider: System.out → log.info • FieldTypesMetaDataProvider: System.out → log.info • KeyTypesMetaDataProvider: System.out → log.info • ValidatorTypesMetaDataProvider: System.out → log.info • OMMetaDataProvider: System.out → log.info DEBUG MESSAGES (1 file): • ExpressionParser: System.out → log.debug for parsing trace messages TECHNICAL IMPROVEMENTS: • Added SLF4J Logger declarations to all affected classes • Used parameterized logging for better performance: log.debug("{} {}", var1, var2) • Maintained message content while improving logging framework consistency • Test files and example applications retain System.out (appropriate for demonstrations) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent cab63b1 commit d8034ca

7 files changed

Lines changed: 35 additions & 8 deletions

File tree

metadata/src/main/java/com/draagon/meta/attr/AttributeTypesMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.draagon.meta.registry.MetaDataRegistry;
44
import com.draagon.meta.registry.MetaDataTypeProvider;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
/**
79
* Attribute Types MetaData provider that registers all concrete attribute type implementations.
@@ -29,6 +31,8 @@
2931
*/
3032
public class AttributeTypesMetaDataProvider implements MetaDataTypeProvider {
3133

34+
private static final Logger log = LoggerFactory.getLogger(AttributeTypesMetaDataProvider.class);
35+
3236
@Override
3337
public void registerTypes(MetaDataRegistry registry) {
3438
// FIRST: Register the base attribute type that all others inherit from
@@ -44,7 +48,7 @@ public void registerTypes(MetaDataRegistry registry) {
4448
ClassAttribute.registerTypes(registry);
4549
PropertiesAttribute.registerTypes(registry);
4650

47-
System.out.println("Info: Attribute types registered via provider");
51+
log.info("Attribute types registered via provider");
4852
}
4953

5054
@Override

metadata/src/main/java/com/draagon/meta/core/CoreTypeMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import com.draagon.meta.MetaData;
44
import com.draagon.meta.registry.MetaDataRegistry;
55
import com.draagon.meta.registry.MetaDataTypeProvider;
6+
import org.slf4j.Logger;
7+
import org.slf4j.LoggerFactory;
68

79
/**
810
* Core Type MetaData provider that registers the fundamental base types.
@@ -24,12 +26,14 @@
2426
*/
2527
public class CoreTypeMetaDataProvider implements MetaDataTypeProvider {
2628

29+
private static final Logger log = LoggerFactory.getLogger(CoreTypeMetaDataProvider.class);
30+
2731
@Override
2832
public void registerTypes(MetaDataRegistry registry) {
2933
// Register the fundamental metadata.base type that all others inherit from
3034
MetaData.registerTypes(registry);
3135

32-
System.out.println("Info: Core base types registered via provider");
36+
log.info("Core base types registered via provider");
3337
}
3438

3539
@Override

metadata/src/main/java/com/draagon/meta/field/FieldTypesMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.draagon.meta.registry.MetaDataRegistry;
44
import com.draagon.meta.registry.MetaDataTypeProvider;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
/**
79
* Field Types MetaData provider that registers all concrete field type implementations.
@@ -31,6 +33,8 @@
3133
*/
3234
public class FieldTypesMetaDataProvider implements MetaDataTypeProvider {
3335

36+
private static final Logger log = LoggerFactory.getLogger(FieldTypesMetaDataProvider.class);
37+
3438
@Override
3539
public void registerTypes(MetaDataRegistry registry) {
3640
// FIRST: Register the base field type that all others inherit from
@@ -48,7 +52,7 @@ public void registerTypes(MetaDataRegistry registry) {
4852
ByteField.registerTypes(registry);
4953
ShortField.registerTypes(registry);
5054

51-
System.out.println("Info: Field types registered via provider");
55+
log.info("Field types registered via provider");
5256
}
5357

5458
@Override

metadata/src/main/java/com/draagon/meta/key/KeyTypesMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.draagon.meta.registry.MetaDataRegistry;
44
import com.draagon.meta.registry.MetaDataTypeProvider;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
/**
79
* Key Types MetaData provider that registers all concrete key type implementations.
@@ -24,6 +26,8 @@
2426
*/
2527
public class KeyTypesMetaDataProvider implements MetaDataTypeProvider {
2628

29+
private static final Logger log = LoggerFactory.getLogger(KeyTypesMetaDataProvider.class);
30+
2731
@Override
2832
public void registerTypes(MetaDataRegistry registry) {
2933
// FIRST: Register the base key type that all others inherit from
@@ -34,7 +38,7 @@ public void registerTypes(MetaDataRegistry registry) {
3438
ForeignKey.registerTypes(registry);
3539
SecondaryKey.registerTypes(registry);
3640

37-
System.out.println("Info: Key types registered via provider");
41+
log.info("Key types registered via provider");
3842
}
3943

4044
@Override

metadata/src/main/java/com/draagon/meta/validator/ValidatorTypesMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.draagon.meta.registry.MetaDataRegistry;
44
import com.draagon.meta.registry.MetaDataTypeProvider;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
/**
79
* Validator Types MetaData provider that registers all concrete validator type implementations.
@@ -26,6 +28,8 @@
2628
*/
2729
public class ValidatorTypesMetaDataProvider implements MetaDataTypeProvider {
2830

31+
private static final Logger log = LoggerFactory.getLogger(ValidatorTypesMetaDataProvider.class);
32+
2933
@Override
3034
public void registerTypes(MetaDataRegistry registry) {
3135
// FIRST: Register the base validator type that all others inherit from
@@ -38,7 +42,7 @@ public void registerTypes(MetaDataRegistry registry) {
3842
NumericValidator.registerTypes(registry);
3943
ArrayValidator.registerTypes(registry);
4044

41-
System.out.println("Info: Validator types registered via provider");
45+
log.info("Validator types registered via provider");
4246
}
4347

4448
@Override

om/src/main/java/com/draagon/meta/manager/exp/parser/ExpressionParser.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,12 @@
1010
import com.draagon.meta.field.LongField;
1111
import com.draagon.meta.field.StringField;
1212
import com.draagon.meta.manager.exp.Expression;
13+
import org.slf4j.Logger;
14+
import org.slf4j.LoggerFactory;
1315

1416
public class ExpressionParser
1517
{
18+
private static final Logger log = LoggerFactory.getLogger(ExpressionParser.class);
1619
private static ExpressionParser instance = null;
1720

1821
protected class ExpResult
@@ -108,7 +111,7 @@ else if ( c == 'o' && isOr( str, x )){
108111
//if ( str.charAt( r.getEnd() ) != ')' )
109112
x = r.getEnd();
110113

111-
System.out.println( "END: [" + str.charAt( x ) + "] " + str.substring( x ));
114+
log.debug("END: [{}] {}", str.charAt(x), str.substring(x));
112115

113116
n = x;
114117
}
@@ -268,6 +271,6 @@ public static void main( String [] args ) throws ExpressionParseError
268271
mc.addMetaField( d );
269272

270273
Expression exp = ExpressionParser.getInstance().parse( mc, "( time > = '10/12/2006 14:55' and ( ( id = 5 or name = 'test me!' ) and value <> 20))" );
271-
System.out.println( "EXPRESSION: " + exp );
274+
log.debug("EXPRESSION: {}", exp);
272275
}
273276
}

om/src/main/java/com/draagon/meta/object/managed/OMMetaDataProvider.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import com.draagon.meta.registry.MetaDataRegistry;
44
import com.draagon.meta.registry.MetaDataTypeProvider;
5+
import org.slf4j.Logger;
6+
import org.slf4j.LoggerFactory;
57

68
/**
79
* OM (Object Manager) MetaData provider that registers managed object types.
@@ -22,12 +24,14 @@
2224
*/
2325
public class OMMetaDataProvider implements MetaDataTypeProvider {
2426

27+
private static final Logger log = LoggerFactory.getLogger(OMMetaDataProvider.class);
28+
2529
@Override
2630
public void registerTypes(MetaDataRegistry registry) {
2731
// Register managed object type
2832
ManagedMetaObject.registerTypes(registry);
2933

30-
System.out.println("Info: OM managed types registered via provider");
34+
log.info("OM managed types registered via provider");
3135
}
3236

3337
@Override

0 commit comments

Comments
 (0)