Skip to content

Commit 486b02b

Browse files
dmealingclaude
andcommitted
docs(java-metadata): fix stale 'static self-registration' comments
Pre-merge review follow-up: three comments still described the removed self-registering static{} blocks. Reword to point at the ServiceLoader provider path so they no longer contradict the anti-cycle notes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 1603967 commit 486b02b

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

server/java/metadata/src/main/java/com/metaobjects/MetaData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public class MetaData implements Cloneable, Serializable {
128128
/** Root metadata subtype for the tree-root node (MetaRoot) */
129129
public static final String SUBTYPE_ROOT = "root";
130130

131-
// Unified registry self-registration for root metadata type
131+
// Registered via CoreTypeMetaDataProvider on the ServiceLoader bootstrap.
132132
/**
133133
* Register MetaData as metadata.base with abstract requirements constraints.
134134
* This creates metadata.base which defines metadata file structure and enforces
@@ -372,7 +372,7 @@ public MetaData(String type, String subType, String name ) {
372372

373373
// ========== ENHANCED TYPE SYSTEM METHODS ==========
374374

375-
// Type definition methods removed - using unified registry with static self-registration
375+
// Type definition methods removed - using unified registry via ServiceLoader providers
376376

377377
/**
378378
* Validate MetaData name during construction

server/java/metadata/src/main/java/com/metaobjects/MetaRoot.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,14 @@ public class MetaRoot extends MetaData {
6969

7070
/**
7171
* Registers the metadata.root type with the supplied registry.
72-
* Provided for parity with {@link MetaData#registerTypes(MetaDataRegistry)};
73-
* the static initializer already self-registers against the singleton.
72+
* Invoked via CoreTypeMetaDataProvider on the ServiceLoader bootstrap.
7473
*
7574
* @param registry the registry to register with
7675
*/
7776
public static void registerTypes(MetaDataRegistry registry) {
7877
try {
79-
// Idempotent: the static block (singleton) and the ServiceLoader
80-
// bootstrap (CoreTypeMetaDataProvider, for isolated registries) both
81-
// call this; skip if metadata.root is already registered.
78+
// Idempotent: skip if metadata.root is already registered (the
79+
// provider may run against a registry that already has it).
8280
if (registry.isRegistered(TYPE_METADATA, SUBTYPE_ROOT)) {
8381
return;
8482
}

0 commit comments

Comments
 (0)