test(ts): YAML conformance fixtures (ADR-0006 D4)

dmealing · claude · dmealing · commit 53b2d5d15df5 · 2026-05-24T16:11:46.000-04:00
YAML is a TS-only authoring front-end, so its conformance corpus lives in this package — not under the repo-root fixtures/conformance/ corpus consumed by Java/Python/C#. Six fixtures cover the D1 desugar happy paths and the D2 + ERR_RESERVED_ATTR error paths: - yaml-sigil-free-attrs: bare @column/@objectRef/@storage/@required/@fields authored without `@` lower to canonical @-prefixed attrs. - yaml-mixed-bare-and-prefixed: an already-`@`-prefixed attr coexists with bare attrs (backward-compat accept-both). - yaml-array-suffix: `field.long[]` → canonical `field.long` + isArray: true. - error-yaml-coerced-bool-in-string: `column: TRUE` → ERR_YAML_COERCION. - error-yaml-coerced-num-in-enum: unquoted 42 in @values → ERR_YAML_COERCION + ERR_BAD_ATTR_VALUE (the coerced "42" then fails the enum identifier pattern). - error-yaml-reserved-as-attr: `@isArray` in YAML still triggers ERR_RESERVED_ATTR (the JSON corollary applies after desugar). The harness auto-discovers fixture directories — adding one adds a test. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-bool-in-string/expected-errors.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-bool-in-string/expected-errors.json
@@ -0,0 +1,3 @@
+[
+  { "code": "ERR_YAML_COERCION" }
+]
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-bool-in-string/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-bool-in-string/input.yaml
@@ -0,0 +1,8 @@
+metadata:
+  children:
+    - object.entity:
+        name: Product
+        children:
+          - field.string:
+              name: active
+              column: TRUE
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-num-in-enum/expected-errors.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-num-in-enum/expected-errors.json
@@ -0,0 +1,4 @@
+[
+  { "code": "ERR_YAML_COERCION" },
+  { "code": "ERR_BAD_ATTR_VALUE" }
+]
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-num-in-enum/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-coerced-num-in-enum/input.yaml
@@ -0,0 +1,8 @@
+metadata:
+  children:
+    - object.entity:
+        name: Product
+        children:
+          - field.enum:
+              name: status
+              values: ["DRAFT", 42, "PUBLISHED"]
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-reserved-as-attr/expected-errors.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-reserved-as-attr/expected-errors.json
@@ -0,0 +1,3 @@
+[
+  { "code": "ERR_RESERVED_ATTR" }
+]
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-reserved-as-attr/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/error-yaml-reserved-as-attr/input.yaml
@@ -0,0 +1,5 @@
+metadata:
+  children:
+    - object.entity:
+        name: Product
+        "@isArray": true
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-array-suffix/expected.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-array-suffix/expected.json
@@ -0,0 +1,19 @@
+{
+  "metadata.root": {
+    "children": [
+      {
+        "object.entity": {
+          "name": "Program",
+          "children": [
+            {
+              "field.long": {
+                "name": "weekIds",
+                "isArray": true
+              }
+            }
+          ]
+        }
+      }
+    ]
+  }
+}
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-array-suffix/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-array-suffix/input.yaml
@@ -0,0 +1,6 @@
+metadata:
+  children:
+    - object.entity:
+        name: Program
+        children:
+          - field.long[]: weekIds
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-mixed-bare-and-prefixed/expected.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-mixed-bare-and-prefixed/expected.json
@@ -0,0 +1,21 @@
+{
+  "metadata.root": {
+    "package": "acme",
+    "children": [
+      {
+        "object.entity": {
+          "name": "Product",
+          "children": [
+            {
+              "field.object": {
+                "name": "address",
+                "@objectRef": "Address",
+                "@storage": "flattened"
+              }
+            }
+          ]
+        }
+      }
+    ]
+  }
+}
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-mixed-bare-and-prefixed/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-mixed-bare-and-prefixed/input.yaml
@@ -0,0 +1,10 @@
+metadata:
+  package: acme
+  children:
+    - object.entity:
+        name: Product
+        children:
+          - field.object:
+              name: address
+              "@objectRef": Address
+              storage: flattened
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-sigil-free-attrs/expected.json b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-sigil-free-attrs/expected.json
@@ -0,0 +1,36 @@
+{
+  "metadata.root": {
+    "package": "acme::shop",
+    "children": [
+      {
+        "object.entity": {
+          "name": "Product",
+          "children": [
+            {
+              "field.string": {
+                "name": "sku",
+                "@column": "sku_code",
+                "@required": true
+              }
+            },
+            {
+              "field.object": {
+                "name": "address",
+                "@objectRef": "Address",
+                "@storage": "flattened"
+              }
+            },
+            {
+              "identity.primary": {
+                "name": "pk",
+                "@fields": [
+                  "sku"
+                ]
+              }
+            }
+          ]
+        }
+      }
+    ]
+  }
+}
diff --git a/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-sigil-free-attrs/input.yaml b/server/typescript/packages/metadata/test/fixtures/yaml-conformance/yaml-sigil-free-attrs/input.yaml
@@ -0,0 +1,17 @@
+metadata:
+  package: acme::shop
+  children:
+    - object.entity:
+        name: Product
+        children:
+          - field.string:
+              name: sku
+              column: sku_code
+              required: true
+          - field.object:
+              name: address
+              objectRef: Address
+              storage: flattened
+          - identity.primary:
+              name: pk
+              fields: ["sku"]
diff --git a/server/typescript/packages/metadata/test/yaml-conformance.test.ts b/server/typescript/packages/metadata/test/yaml-conformance.test.ts
@@ -0,0 +1,123 @@
+// YAML conformance harness (TS-only, ADR-0006 D4).
+//
+// YAML is a TS-only authoring front-end (canonical JSON is the cross-language
+// interchange), so its conformance corpus lives in this package — never under
+// the repo-root `fixtures/conformance/` corpus, which the Java/Python/C# ports
+// also consume.
+//
+// Each fixture directory under test/fixtures/yaml-conformance/ contains:
+//   - input.yaml                                        (required)
+//   - expected.json   (happy-path → canonical-serialized output must match)
+//   - expected-errors.json   (error-path → emitted ParseError codes must match)
+//
+// Exactly one of expected.json / expected-errors.json must be present per
+// fixture. Adding a directory under test/fixtures/yaml-conformance/ adds two
+// tests automatically (a parse run + the appropriate comparison).
+
+import { test, expect } from "bun:test";
+import { readdir, readFile, stat } from "node:fs/promises";
+import { join } from "node:path";
+import { FileMetaDataLoader } from "../src/core/file-meta-data-loader.js";
+import { InMemorySource } from "../src/loader/meta-data-source.js";
+import { canonicalSerialize } from "../src/serializer-json.js";
+import type { ParseError } from "../src/errors.js";
+
+const CORPUS = join(import.meta.dir, "fixtures/yaml-conformance");
+
+interface YamlFixture {
+  name: string;
+  input: string;
+  expected:
+    | { kind: "canonical"; json: string }
+    | { kind: "errors"; codes: string[] };
+}
+
+async function discoverYamlFixtures(corpus: string): Promise<YamlFixture[]> {
+  const entries = (await readdir(corpus)).sort();
+  const fixtures: YamlFixture[] = [];
+  for (const entry of entries) {
+    const path = join(corpus, entry);
+    const st = await stat(path);
+    if (!st.isDirectory()) continue;
+    const input = await readFile(join(path, "input.yaml"), "utf8");
+
+    // Prefer expected-errors.json when present; else canonical expected.json.
+    let expectedErrorsRaw: string | undefined;
+    try {
+      expectedErrorsRaw = await readFile(join(path, "expected-errors.json"), "utf8");
+    } catch {
+      // not an error-path fixture
+    }
+    let expectedJsonRaw: string | undefined;
+    try {
+      expectedJsonRaw = await readFile(join(path, "expected.json"), "utf8");
+    } catch {
+      // not a happy-path fixture
+    }
+
+    if (expectedErrorsRaw !== undefined && expectedJsonRaw !== undefined) {
+      throw new Error(
+        `Fixture '${entry}' has both expected.json and expected-errors.json — one only.`,
+      );
+    }
+    if (expectedErrorsRaw !== undefined) {
+      const codes = (JSON.parse(expectedErrorsRaw) as { code: string }[]).map((e) => e.code);
+      fixtures.push({ name: entry, input, expected: { kind: "errors", codes } });
+    } else if (expectedJsonRaw !== undefined) {
+      fixtures.push({
+        name: entry,
+        input,
+        expected: { kind: "canonical", json: expectedJsonRaw },
+      });
+    } else {
+      throw new Error(
+        `Fixture '${entry}' has neither expected.json nor expected-errors.json.`,
+      );
+    }
+  }
+  return fixtures;
+}
+
+async function loadYaml(yaml: string): Promise<{
+  root: import("../src/shared/meta-root.js").MetaRoot;
+  errors: Error[];
+}> {
+  const loader = new FileMetaDataLoader();
+  const result = await loader.load([
+    new InMemorySource(yaml, { id: "input.yaml", format: "yaml" }),
+  ]);
+  return { root: result.root, errors: result.errors };
+}
+
+const fixtures = await discoverYamlFixtures(CORPUS);
+
+for (const fix of fixtures) {
+  test(`yaml-conformance: ${fix.name}`, async () => {
+    const { root, errors } = await loadYaml(fix.input);
+
+    if (fix.expected.kind === "canonical") {
+      // Happy-path: no errors and the canonical serialization must match.
+      if (errors.length > 0) {
+        const codes = errors.map((e) => (e as ParseError).code ?? "(no code)").join(", ");
+        throw new Error(
+          `${fix.name}: expected no errors but got [${codes}]: ` +
+            errors.map((e) => e.message).join("\n  "),
+        );
+      }
+      const got = canonicalSerialize(root);
+      expect(got).toBe(fix.expected.json);
+    } else {
+      // Error-path: the set of emitted ERR_ codes (deduplicated, sorted) must
+      // exactly equal the expected set. This is a *set* match, not multiset —
+      // multiple identical codes is normal (one per offending node).
+      // Widen both sides to `string[]` so toEqual's NoInfer narrowing does not
+      // pick the ErrorCode union on one side and reject the file-loaded
+      // string[] on the other.
+      const gotCodes: string[] = Array.from(
+        new Set(errors.map((e) => (e as ParseError).code ?? "(no code)")),
+      ).sort();
+      const wantCodes: string[] = Array.from(new Set(fix.expected.codes)).sort();
+      expect(gotCodes).toEqual(wantCodes);
+    }
+  });
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[`
	`2`	`+ { "code": "ERR_YAML_COERCION" }`
	`3`	`+]`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +[
 +  { "code": "ERR_YAML_COERCION" },
 +  { "code": "ERR_BAD_ATTR_VALUE" }
 +]
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[`
	`2`	`+ { "code": "ERR_RESERVED_ATTR" }`
	`3`	`+]`