feat(metadata): SP-G Java recon Unit6b-fin/6c — exclude @object/@objectadapter binding facets + refactor field-validation to validator children

dmealing · claude · dmealing · commit 5d173c8e585b · 2026-06-03T05:49:46.000-04:00
Part A (Unit 6b-finish): exclude the two per-port type-BINDING facets @object (ADR-0001 class-FQN type binding for OO ports) and @objectadapter (ADR-0005 hybrid value-access seam) from the registry manifest. These are the same category as the already-excluded native type bindings — legitimate per-port binding mechanisms, not cross-port logical vocabulary. Added 'object' + 'objectAdapter' to the shared per-type-attr exclusion set in all 4 emitters (TS/C#/Python no-op; filters Java's object.* binding attrs); they stay REGISTERED in Java (load-bearing runtime mechanisms read by the value-access representation, IO readers, and OMDB). README EXCLUDED list documents them alongside the native-type-bindings entry. object.* rows now match the canonical (residual only the object.base db* set → Unit 7). Part B (Unit 6c): refactor Java's field-level validation attrs to the cross-port validator-children form. Dropped the redundant/vestigial field-level registrations: @pattern/@minlength (string), @minValue/@MaxValue (int/long/ float/double/decimal), @format/@dateFormat/@minDate/@maxDate (date), @format/@minTime/@maxtime (time), @dateFormat/@minDate/@maxDate (timestamp), and field-level @Locale (currency). Investigation confirmed NONE are read by codegen/runtime/loader: codegen-spring/codegen-kotlin already emit validation from validator CHILD nodes (validator.regex @pattern, validator.length @min/@max, validator.numeric @min/@max) per the SP-C validator-parity work, so the field-level attrs were a redundant second path; the temporal-format / currency-locale attrs were vestigial (no canonical peer, no consumer — the currency @Locale wire contract lives on view.currency). Kept the canonical per-field attrs maxLength/precision/scale/currency. Constants retained (harmless; referenced by tests). Migrated the orphaned valid-complete-metadata.json example + the embedded test metadata to validator-children form; updated the registration-assertion tests to assert NAMED-requirement absence (field.base's open wildcard attr policy still accepts arbitrary attrs via acceptsChild). field.* rows now match the canonical (residual only the physical db* set → Unit 7). Java metadata 926/926 green; codegen-base/codegen-spring/codegen-kotlin/omdb BUILD SUCCESS; TS/C#/Python registry-conformance still byte-green (no-op). Gated RegistryManifestConformanceTest stays @ignore (Unit 8); un-skipped locally to confirm object.* + field.* now match canonical and the residual is ONLY the physical db* set (dbType/dbIndex/dbLength/dbNullable/dbForeignKey/dbPrecision/ dbScale/dbUnique/dbSequenceName/dbIndexName/dbTablespace/previousName — Unit 7), then re-skipped. Gate Javadoc updated accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
diff --git a/fixtures/registry-conformance/README.md b/fixtures/registry-conformance/README.md
@@ -105,6 +105,16 @@ deferral.
 - Node factory / `NodeConstructor` / Java `Class` — per-port physical wiring.
 - Native type bindings (Java `DataTypes` value-class, TS native TS-type, EF/CLR
   types, the coarse `DataType` classification) — physical, per-port.
+- **The per-port type-binding facets `@object` + `@objectAdapter`** — `@object`
+  is the ADR-0001 class-FQN type binding for OO ports (the Java runtime resolves
+  an object's native class from this attr) and `@objectAdapter` is the ADR-0005
+  hybrid value-access seam. These are the same category as the native type
+  bindings above — legitimate per-port BINDING mechanisms, not cross-port logical
+  vocabulary. Java registers them as per-type attrs on `object.*` (load-bearing
+  runtime mechanisms read by the value-access representation, IO readers, and
+  OMDB — kept registered in Java); the emitter filters them by name from each
+  type's `attrs` list (uniform across all four emitters; a no-op for
+  TS/C#/Python, which never register them). See SP-G Unit 6b-finish.
 - Codegen targets/options.
 - The TS-only `D1` dialect and any other documented port-unique surface.
 - Ordering (we sort everything).
diff --git a/server/csharp/MetaObjects/RegistryManifest.cs b/server/csharp/MetaObjects/RegistryManifest.cs
@@ -50,14 +50,20 @@ public static class RegistryManifest
     private const string AttrNameImplements = "implements";
     private const string AttrNameIsInterface = "isInterface";
 
-    /// <summary>Per-type attr names filtered from a type's <c>attrs</c> list (structural / OO-shape keywords + the description commonAttr).</summary>
+    /// <summary>The two per-port type-BINDING facet attr names: <c>object</c> (ADR-0001 class-FQN type binding for OO ports) and <c>objectAdapter</c> (ADR-0005 hybrid value-access seam). Same category as the excluded native type bindings — legitimate per-port binding mechanisms, not cross-port logical vocabulary. No-op for C# (never registers them); the filter drops Java's per-type <c>object.*</c> registrations. See SP-G Unit 6b-finish.</summary>
+    private const string AttrNameObject = "object";
+    private const string AttrNameObjectAdapter = "objectAdapter";
+
+    /// <summary>Per-type attr names filtered from a type's <c>attrs</c> list (structural / OO-shape keywords + the per-port type-binding facets <c>object</c>/<c>objectAdapter</c> + the description commonAttr).</summary>
     private static readonly HashSet<string> ExcludedPerTypeAttrNames = new(StringComparer.Ordinal)
     {
         Structural.RESERVED_KEY_IS_ARRAY,
         AttrNameIsAbstract,
         Structural.RESERVED_KEY_EXTENDS,
         AttrNameImplements,
         AttrNameIsInterface,
+        AttrNameObject,
+        AttrNameObjectAdapter,
         DocumentationConstants.DOC_ATTR_DESCRIPTION,
     };
 
diff --git a/server/java/codegen-base/src/test/resources/schema-validation/valid-complete-metadata.json b/server/java/codegen-base/src/test/resources/schema-validation/valid-complete-metadata.json
@@ -27,7 +27,6 @@
                 "name": "username",
                 "subType": "string",
                 "@maxLength": 50,
-                "@pattern": "^[a-zA-Z0-9_]+$",
                 "children": [
                   {
                     "attr": {
@@ -97,16 +96,7 @@
             {
               "field": {
                 "name": "createdDate",
-                "subType": "date",
-                "children": [
-                  {
-                    "attr": {
-                      "name": "format",
-                      "subType": "string",
-                      "value": "yyyy-MM-dd"
-                    }
-                  }
-                ]
+                "subType": "date"
               }
             },
             {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/CurrencyField.java b/server/java/metadata/src/main/java/com/metaobjects/field/CurrencyField.java
@@ -38,16 +38,17 @@ public static void registerTypes(MetaDataRegistry registry) {
         try {
             registry.registerType(CurrencyField.class, def -> {
                 def.type(TYPE_FIELD).subType(SUBTYPE_CURRENCY)
-                   .description("Currency field — integer minor units; carries @currency (ISO 4217) and optional @locale")
+                   .description("Currency field — integer minor units; carries @currency (ISO 4217)")
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
                 def.optionalAttributeWithConstraints(ATTR_CURRENCY)
                    .ofType(StringAttribute.SUBTYPE_STRING)
                    .asSingle();
 
-                def.optionalAttributeWithConstraints(ATTR_LOCALE)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();
+                // @currency is the one canonical (cross-port) currency field attr. The
+                // currency presentation @locale (BCP 47) wire contract lives on the
+                // view.currency child, not the field — the field-level @locale had no
+                // canonical peer and no consumer; dropped SP-G Unit 6c.
             });
             if (log != null) log.debug("Registered CurrencyField type with unified registry");
         } catch (Exception e) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/DateField.java b/server/java/metadata/src/main/java/com/metaobjects/field/DateField.java
@@ -44,25 +44,14 @@ public DateField( String name ) {
     public static void registerTypes(MetaDataRegistry registry) {
         registry.registerType(DateField.class, def -> {
             def.type(TYPE_FIELD).subType(SUBTYPE_DATE)
-               .description("Date field with format and range validation")
+               .description("Date field")
                .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-            // DATE-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-            def.optionalAttributeWithConstraints(ATTR_DATE_FORMAT)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_FORMAT)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_MIN_DATE)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_MAX_DATE)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
+            // No date-specific per-field attrs in the cross-port vocabulary: the
+            // field-level @format/@dateFormat (presentation) and @minDate/@maxDate
+            // (range) attrs had no canonical peer and no consumer (codegen / runtime /
+            // loader) — vestigial. Range validation is expressed via a validator child
+            // (validator.numeric @min/@max); dropped SP-G Unit 6c.
         });
 
         if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/DecimalField.java b/server/java/metadata/src/main/java/com/metaobjects/field/DecimalField.java
@@ -61,13 +61,10 @@ public static void registerTypes(MetaDataRegistry registry) {
                    .ofType(IntAttribute.SUBTYPE_INT)
                    .asSingle();   // Decimal places (e.g., 2)
 
-                def.optionalAttributeWithConstraints(ATTR_MIN_VALUE)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();   // String to preserve precision
-
-                def.optionalAttributeWithConstraints(ATTR_MAX_VALUE)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();   // String to preserve precision
+                // precision + scale are the canonical (cross-port) decimal attrs.
+                // Range validation is expressed via a validator.numeric @min/@max
+                // CHILD node (the cross-port form), not field-level @minValue/@maxValue
+                // attrs (dropped SP-G Unit 6c — validation emits from validator children).
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/DoubleField.java b/server/java/metadata/src/main/java/com/metaobjects/field/DoubleField.java
@@ -55,14 +55,9 @@ public static void registerTypes(MetaDataRegistry registry) {
                    // INHERIT FROM BASE FIELD
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-                // DOUBLE-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-                def.optionalAttributeWithConstraints(ATTR_MIN_VALUE)
-                   .ofType(DoubleAttribute.SUBTYPE_DOUBLE)
-                   .asSingle();
-
-                def.optionalAttributeWithConstraints(ATTR_MAX_VALUE)
-                   .ofType(DoubleAttribute.SUBTYPE_DOUBLE)
-                   .asSingle();
+                // Range validation is expressed via a validator.numeric @min/@max
+                // CHILD node (the cross-port form), not field-level @minValue/@maxValue
+                // attrs (dropped SP-G Unit 6c — validation emits from validator children).
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/FloatField.java b/server/java/metadata/src/main/java/com/metaobjects/field/FloatField.java
@@ -43,14 +43,9 @@ public static void registerTypes(MetaDataRegistry registry) {
                .description("Float field with range validation")
                .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-            // FLOAT-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-            def.optionalAttributeWithConstraints(ATTR_MIN_VALUE)
-               .ofType(DoubleAttribute.SUBTYPE_DOUBLE)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_MAX_VALUE)
-               .ofType(DoubleAttribute.SUBTYPE_DOUBLE)
-               .asSingle();
+            // Range validation is expressed via a validator.numeric @min/@max
+            // CHILD node (the cross-port form), not field-level @minValue/@maxValue
+            // attrs (dropped SP-G Unit 6c — validation emits from validator children).
         });
     }
 
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/IntegerField.java b/server/java/metadata/src/main/java/com/metaobjects/field/IntegerField.java
@@ -46,14 +46,11 @@ public static void registerTypes(MetaDataRegistry registry) {
                    // INHERIT FROM BASE FIELD
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-                // INTEGER-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-                def.optionalAttributeWithConstraints(ATTR_MIN_VALUE)
-                   .ofType(IntAttribute.SUBTYPE_INT)
-                   .asSingle();
-
-                def.optionalAttributeWithConstraints(ATTR_MAX_VALUE)
-                   .ofType(IntAttribute.SUBTYPE_INT)
-                   .asSingle();
+                // Range validation is expressed via a validator.numeric @min/@max
+                // CHILD node (the cross-port form), not field-level @minValue/@maxValue
+                // attrs. The redundant field-level registrations were dropped in
+                // SP-G Unit 6c (validation already emits from validator children per
+                // the SP-C validator-parity work).
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/LongField.java b/server/java/metadata/src/main/java/com/metaobjects/field/LongField.java
@@ -46,14 +46,9 @@ public static void registerTypes(MetaDataRegistry registry) {
                    // INHERIT FROM BASE FIELD
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-                // LONG-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-                def.optionalAttributeWithConstraints(ATTR_MIN_VALUE)
-                   .ofType(LongAttribute.SUBTYPE_LONG)
-                   .asSingle();
-
-                def.optionalAttributeWithConstraints(ATTR_MAX_VALUE)
-                   .ofType(LongAttribute.SUBTYPE_LONG)
-                   .asSingle();
+                // Range validation is expressed via a validator.numeric @min/@max
+                // CHILD node (the cross-port form), not field-level @minValue/@maxValue
+                // attrs (dropped SP-G Unit 6c — validation emits from validator children).
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/StringField.java b/server/java/metadata/src/main/java/com/metaobjects/field/StringField.java
@@ -59,26 +59,15 @@ public static void registerTypes(MetaDataRegistry registry) {
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
                 // STRING-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-                def.optionalAttributeWithConstraints(ATTR_PATTERN)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .withCustom(value -> {
-                       if (value == null) return true;
-                       try {
-                           // Validate that the pattern is a valid regex
-                           java.util.regex.Pattern.compile(value.toString());
-                           return true;
-                       } catch (java.util.regex.PatternSyntaxException e) {
-                           return false;
-                       }
-                   });
-
+                // maxLength is the one canonical (cross-port) string attr. Field-level
+                // validation (pattern / min-length) is expressed via validator CHILD
+                // nodes (validator.regex @pattern, validator.length @min/@max) — the
+                // cross-port form. The redundant field-level @pattern / @minLength
+                // registrations were dropped in SP-G Unit 6c (validation already emits
+                // from validator children per the SP-C validator-parity work).
                 def.optionalAttributeWithConstraints(ATTR_MAX_LENGTH)
                    .ofType(IntAttribute.SUBTYPE_INT)
                    .asSingle();
-
-                def.optionalAttributeWithConstraints(ATTR_MIN_LENGTH)
-                   .ofType(IntAttribute.SUBTYPE_INT)
-                   .asSingle();
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/TimeField.java b/server/java/metadata/src/main/java/com/metaobjects/field/TimeField.java
@@ -80,18 +80,11 @@ public static void registerTypes(MetaDataRegistry registry) {
                    // INHERIT FROM BASE FIELD
                    .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-                // TIME-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
-                def.optionalAttributeWithConstraints(ATTR_FORMAT)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();     // Time format pattern
-
-                def.optionalAttributeWithConstraints(ATTR_MIN_TIME)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();     // Minimum time constraint
-
-                def.optionalAttributeWithConstraints(ATTR_MAX_TIME)
-                   .ofType(StringAttribute.SUBTYPE_STRING)
-                   .asSingle();     // Maximum time constraint
+                // No time-specific per-field attrs in the cross-port vocabulary: the
+                // field-level @format (presentation) and @minTime/@maxTime (range)
+                // attrs had no canonical peer and no consumer (codegen / runtime /
+                // loader) — vestigial. Range validation is expressed via a validator
+                // child (validator.numeric @min/@max); dropped SP-G Unit 6c.
             });
 
             if (log != null) {
diff --git a/server/java/metadata/src/main/java/com/metaobjects/field/TimestampField.java b/server/java/metadata/src/main/java/com/metaobjects/field/TimestampField.java
@@ -46,22 +46,15 @@ public static void registerTypes(MetaDataRegistry registry) {
                .description("Timestamp field with date/time and precision validation")
                .inheritsFrom(TYPE_FIELD, SUBTYPE_BASE);
 
-            // TIMESTAMP-SPECIFIC ATTRIBUTES WITH FLUENT CONSTRAINTS
+            // precision is the one canonical (cross-port) timestamp attr.
             def.optionalAttributeWithConstraints(ATTR_PRECISION)
                .ofType(IntAttribute.SUBTYPE_INT)
                .asSingle();
 
-            def.optionalAttributeWithConstraints(ATTR_DATE_FORMAT)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_MIN_DATE)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
-
-            def.optionalAttributeWithConstraints(ATTR_MAX_DATE)
-               .ofType(StringAttribute.SUBTYPE_STRING)
-               .asSingle();
+            // The field-level @dateFormat (presentation) and @minDate/@maxDate (range)
+            // attrs had no canonical peer and no consumer (codegen / runtime / loader)
+            // — vestigial. Range validation is expressed via a validator child
+            // (validator.numeric @min/@max); dropped SP-G Unit 6c.
         });
     }
 
diff --git a/server/java/metadata/src/main/java/com/metaobjects/registry/RegistryManifest.java b/server/java/metadata/src/main/java/com/metaobjects/registry/RegistryManifest.java
@@ -99,13 +99,25 @@ private RegistryManifest() {
      * REGISTERED (the loader must accept an authored {@code extends:}). Filtered
      * ONLY per-type — {@code description} remains in the {@code commonAttrs}
      * block. See SP-G analysis C-2/C-3 (Unit 6b).
+     *
+     * <p>Also excludes the two per-port type-BINDING facets {@code object}
+     * (ADR-0001 class-FQN type binding for OO ports — the runtime resolves an
+     * object's native class from this attr) and {@code objectAdapter} (ADR-0005
+     * hybrid value-access seam). These are the same category as the already-
+     * excluded native type bindings — legitimate per-port binding mechanisms, not
+     * cross-port logical vocabulary. They stay REGISTERED in Java (load-bearing
+     * runtime mechanisms read by the value-access representation, IO readers, and
+     * OMDB); the filter only drops them from the manifest. No-op for TS/C#/Python
+     * (which never register them as per-type attrs). See SP-G Unit 6b-finish.
      */
     private static final Set<String> EXCLUDED_PER_TYPE_ATTR_NAMES = Set.of(
             MetaField.ATTR_IS_ARRAY,
             MetaData.ATTR_IS_ABSTRACT,
             com.metaobjects.object.MetaObject.ATTR_EXTENDS,
             com.metaobjects.object.MetaObject.ATTR_IMPLEMENTS,
             com.metaobjects.object.MetaObject.ATTR_IS_INTERFACE,
+            com.metaobjects.object.MetaObject.ATTR_OBJECT,
+            com.metaobjects.object.AbstractObjectRepresentation.ATTR_OBJECT_ADAPTER,
             MetaData.ATTR_DESCRIPTION);
 
     /**
diff --git a/server/java/metadata/src/test/java/com/metaobjects/constraint/UnifiedConstraintSystemTest.java b/server/java/metadata/src/test/java/com/metaobjects/constraint/UnifiedConstraintSystemTest.java
@@ -90,14 +90,20 @@ public void testStringFieldConstraints() {
         // Test that StringField constraints are properly loaded in consolidated registry
         var allConstraints = getSharedRegistry().getAllValidationConstraints();
 
-        // Look for StringField-specific constraints with actual generated IDs
+        // Look for StringField-specific constraints with actual generated IDs.
+        // maxLength is the StringField-specific (cross-port canonical) attr. The
+        // field-level @pattern attr (and its auto-generated custom constraint) was
+        // dropped in SP-G Unit 6c — pattern validation is expressed via validator.regex
+        // children — so no field.string.pattern.custom constraint is generated.
         boolean foundMaxLengthPlacement = allConstraints.stream()
             .anyMatch(c -> c.getConstraintId().contains("stringfield.maxlength"));
-        boolean foundPatternPlacement = allConstraints.stream()
-            .anyMatch(c -> c.getConstraintId().contains("field.string.pattern.custom"));
 
         assertTrue("Should find StringField maxLength placement constraint", foundMaxLengthPlacement);
-        assertTrue("Should find StringField pattern placement constraint", foundPatternPlacement);
+
+        boolean foundPatternPlacement = allConstraints.stream()
+            .anyMatch(c -> c.getConstraintId().contains("field.string.pattern.custom"));
+        assertFalse("Should NOT find a field-level StringField pattern constraint "
+            + "(validation moved to validator.regex children — SP-G Unit 6c)", foundPatternPlacement);
 
         boolean foundFieldNamingValidation = allConstraints.stream()
             .anyMatch(c -> c.getConstraintId().contains("field.naming.pattern"));
diff --git a/server/java/metadata/src/test/java/com/metaobjects/field/UnifiedFieldRegistryTest.java b/server/java/metadata/src/test/java/com/metaobjects/field/UnifiedFieldRegistryTest.java
diff --git a/server/java/metadata/src/test/java/com/metaobjects/registry/RegistryManifestConformanceTest.java b/server/java/metadata/src/test/java/com/metaobjects/registry/RegistryManifestConformanceTest.java
diff --git a/server/java/metadata/src/test/java/com/metaobjects/registry/TypeDefinitionInheritanceTest.java b/server/java/metadata/src/test/java/com/metaobjects/registry/TypeDefinitionInheritanceTest.java
diff --git a/server/java/metadata/src/test/java/com/metaobjects/registry/UnifiedRegistryTest.java b/server/java/metadata/src/test/java/com/metaobjects/registry/UnifiedRegistryTest.java
diff --git a/server/python/src/metaobjects/registry_manifest.py b/server/python/src/metaobjects/registry_manifest.py
diff --git a/server/typescript/packages/metadata/src/registry-manifest-exclusions.ts b/server/typescript/packages/metadata/src/registry-manifest-exclusions.ts
