fix(codegen-ts-react): validate edits against UpdateSchema, not InsertSchema (#227)

The generated form takes defaultValues (edit is a first-class mode) but resolved
EVERY submit against InsertSchema. InsertSchema optionals are .optional() --
absent ok, null REJECTED -- while an edit is seeded from a real row whose unset
optional columns are all null. So editing any row holding a NULL optional was
blocked outright: 'Invalid input' appeared on fields the user never touched,
handleSubmit never fired, and the save silently did nothing. Since most rows have
at least one unset optional, this broke most edits.

The resolver now switches on the same defaultValues presence that already
distinguishes create from edit everywhere else in the template. This is the
semantically right pairing regardless: an edit submits a PATCH, so it validates
against the PATCH schema -- UpdateSchema (.optional().nullable()) still enforces
min/max/enum on present keys, it just doesn't demand required keys the PATCH
isn't sending (FR-035 present-key). TPH forms get the same .omit(discriminator)
treatment on both schemas.

Generated-output change: regenerate to pick it up; three-way merge preserves
hand-edits. TS-only -- no other port generates forms.

Rejected: normalizing null -> "" in defaultValues (destroys the was-null vs
was-empty distinction #223's tristate needs, and feeds "" to controls like
view.image that expect string | null), and loosening InsertSchema optionals to
.nullable() (weakens create-path validation for every consumer, including the
server route, to paper over a client-side mode-selection bug).

Closes #227

Author: dmealing

examples/advanced-modeling/src/generated/Author.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Author (Author)
 // Customize via Author.extra.tsx (custom layouts, per-field components, etc.).
-import { Author, AuthorInsertSchema } from "./Author";
+import { Author, AuthorInsertSchema, AuthorUpdateSchema } from "./Author";
 import type { Author as AuthorRow } from "./Author";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface AuthorFormProps {
 export function AuthorForm(props: AuthorFormProps): ReactElement {
   const form = useEntityForm(
     Author,
-    AuthorInsertSchema,
+    props.defaultValues !== undefined ? AuthorUpdateSchema : AuthorInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

examples/advanced-modeling/src/generated/Lesson.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Lesson (Lesson)
 // Customize via Lesson.extra.tsx (custom layouts, per-field components, etc.).
-import { Lesson, LessonInsertSchema } from "./Lesson";
+import { Lesson, LessonInsertSchema, LessonUpdateSchema } from "./Lesson";
 import type { Lesson as LessonRow } from "./Lesson";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface LessonFormProps {
 export function LessonForm(props: LessonFormProps): ReactElement {
   const form = useEntityForm(
     Lesson,
-    LessonInsertSchema,
+    props.defaultValues !== undefined ? LessonUpdateSchema : LessonInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

examples/advanced-modeling/src/generated/Program.form.tsx

@@ -4,7 +4,7 @@
 import { ImageUpload } from "@metaobjectsdev/react";
 import { useFieldArray } from "react-hook-form";
 import { Controller } from "react-hook-form";
-import { Program, ProgramInsertSchema } from "./Program";
+import { Program, ProgramInsertSchema, ProgramUpdateSchema } from "./Program";
 import type { Program as ProgramRow } from "./Program";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -30,7 +30,7 @@ export interface ProgramFormProps {
 export function ProgramForm(props: ProgramFormProps): ReactElement {
   const form = useEntityForm(
     Program,
-    ProgramInsertSchema,
+    props.defaultValues !== undefined ? ProgramUpdateSchema : ProgramInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   const syllabusArray = useFieldArray({ control: form.control, name: "syllabus" as never });

examples/advanced-modeling/src/generated/Purchase.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Purchase (Purchase)
 // Customize via Purchase.extra.tsx (custom layouts, per-field components, etc.).
-import { Purchase, PurchaseInsertSchema } from "./Purchase";
+import { Purchase, PurchaseInsertSchema, PurchaseUpdateSchema } from "./Purchase";
 import type { Purchase as PurchaseRow } from "./Purchase";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface PurchaseFormProps {
 export function PurchaseForm(props: PurchaseFormProps): ReactElement {
   const form = useEntityForm(
     Purchase,
-    PurchaseInsertSchema,
+    props.defaultValues !== undefined ? PurchaseUpdateSchema : PurchaseInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

server/typescript/packages/codegen-ts-react/src/templates/form-file.ts

@@ -308,9 +308,21 @@ export function renderFormFile(entity: MetaObject, ctx: RenderContext): string {
   // doesn't require a field the user never fills.
   const tphPin = tphDiscriminatorPin(entity);
   const fields = visibleFields(entity, tphPin?.fieldName);
-  const formSchema = tphPin !== undefined
-    ? `${entityName}InsertSchema.omit({ ${tphPin.fieldName}: true })`
-    : `${entityName}InsertSchema`;
+  // #227: the resolver must match the MODE. `defaultValues` is what distinguishes
+  // edit from create everywhere else in this template, so it selects the schema too.
+  // InsertSchema's optionals are `.optional()` (absent ok, null REJECTED); an edit is
+  // seeded from a real row where every unset optional column is `null`, so validating
+  // an edit against InsertSchema fails on untouched fields and handleSubmit never
+  // fires — the save silently does nothing. UpdateSchema is `.optional().nullable()`,
+  // and is the semantically right pairing anyway: an edit submits a PATCH, so it
+  // validates against the PATCH schema (still enforcing min/max/enum on present keys,
+  // just not demanding required keys the PATCH isn't sending — FR-035 present-key).
+  const omitTph = (schema: string) => tphPin !== undefined
+    ? `${schema}.omit({ ${tphPin.fieldName}: true })`
+    : schema;
+  const insertSchema = omitTph(`${entityName}InsertSchema`);
+  const updateSchema = omitTph(`${entityName}UpdateSchema`);
+  const formSchema = `props.defaultValues !== undefined ? ${updateSchema} : ${insertSchema}`;
 
   const ReactElementSym = imp("t:ReactElement@react");
   const SubmitHandlerSym = imp("t:SubmitHandler@react-hook-form");
@@ -456,6 +468,7 @@ ${control}
 import {
   ${entityName},
   ${entityName}InsertSchema,
+  ${entityName}UpdateSchema,
 } from ${JSON.stringify(entityFileSpec)};
 import type { ${entityName} as ${entityName}Row } from ${JSON.stringify(entityFileSpec)};
 ${useFieldArrayImport}${imageImports}`;

server/typescript/packages/codegen-ts-react/test/form-view-dispatch.test.ts

@@ -139,3 +139,23 @@ describe("form controls — view-kind dispatch", () => {
     expect(out).toContain('className="metaobjects-form-submit"');
   });
 });
+
+// #227 — the resolver must match the MODE. A generated form takes `defaultValues`
+// (edit mode is first-class), but every submit used to resolve against InsertSchema.
+// InsertSchema optionals are `.optional()` — absent ok, null REJECTED — while an edit
+// is seeded from a real row whose unset optional columns are all `null`. So editing any
+// row with a NULL optional was blocked outright: errors appeared on untouched fields,
+// handleSubmit never fired, and the save silently did nothing.
+describe("form schema is mode-aware (#227)", () => {
+  test("selects UpdateSchema when defaultValues is present, InsertSchema otherwise", async () => {
+    const { root, report } = await loadModel();
+    const out = renderFormFile(report, ctxFor(root));
+
+    // The mode signal is the same `defaultValues` presence used for seeding.
+    expect(out).toContain("props.defaultValues !== undefined ? ReportUpdateSchema : ReportInsertSchema");
+    // ...and the update schema must actually be imported, or the emitted file won't compile.
+    expect(out).toContain("ReportUpdateSchema");
+    // Regression guard: an unconditional InsertSchema resolver is the bug.
+    expect(out).not.toMatch(/useEntityForm\(\s*Report,\s*ReportInsertSchema\s*,/);
+  });
+});

server/typescript/packages/codegen-ts/test/golden/__snapshots__/package/Tag.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Tag (Tag)
 // Customize via Tag.extra.tsx (custom layouts, per-field components, etc.).
-import { Tag, TagInsertSchema } from "./Tag";
+import { Tag, TagInsertSchema, TagUpdateSchema } from "./Tag";
 import type { Tag as TagRow } from "./Tag";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface TagFormProps {
 export function TagForm(props: TagFormProps): ReactElement {
   const form = useEntityForm(
     Tag,
-    TagInsertSchema,
+    props.defaultValues !== undefined ? TagUpdateSchema : TagInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

server/typescript/packages/codegen-ts/test/golden/__snapshots__/package/shop/commerce/Order.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Order (shop::commerce::Order)
 // Customize via Order.extra.tsx (custom layouts, per-field components, etc.).
-import { Order, OrderInsertSchema } from "./Order";
+import { Order, OrderInsertSchema, OrderUpdateSchema } from "./Order";
 import type { Order as OrderRow } from "./Order";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface OrderFormProps {
 export function OrderForm(props: OrderFormProps): ReactElement {
   const form = useEntityForm(
     Order,
-    OrderInsertSchema,
+    props.defaultValues !== undefined ? OrderUpdateSchema : OrderInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

server/typescript/packages/codegen-ts/test/golden/__snapshots__/package/shop/commerce/Product.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Product (shop::commerce::Product)
 // Customize via Product.extra.tsx (custom layouts, per-field components, etc.).
-import { Product, ProductInsertSchema } from "./Product";
+import { Product, ProductInsertSchema, ProductUpdateSchema } from "./Product";
 import type { Product as ProductRow } from "./Product";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface ProductFormProps {
 export function ProductForm(props: ProductFormProps): ReactElement {
   const form = useEntityForm(
     Product,
-    ProductInsertSchema,
+    props.defaultValues !== undefined ? ProductUpdateSchema : ProductInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (

server/typescript/packages/codegen-ts/test/golden/__snapshots__/package/shop/users/Customer.form.tsx

@@ -1,7 +1,7 @@
 // @generated by @metaobjectsdev/codegen-ts — DO NOT EDIT.
 // Source metadata: Customer (shop::users::Customer)
 // Customize via Customer.extra.tsx (custom layouts, per-field components, etc.).
-import { Customer, CustomerInsertSchema } from "./Customer";
+import { Customer, CustomerInsertSchema, CustomerUpdateSchema } from "./Customer";
 import type { Customer as CustomerRow } from "./Customer";
 import { useEntityForm } from "@metaobjectsdev/react";
 import type { ReactElement } from "react";
@@ -27,7 +27,7 @@ export interface CustomerFormProps {
 export function CustomerForm(props: CustomerFormProps): ReactElement {
   const form = useEntityForm(
     Customer,
-    CustomerInsertSchema,
+    props.defaultValues !== undefined ? CustomerUpdateSchema : CustomerInsertSchema,
     props.defaultValues !== undefined ? { defaultValues: props.defaultValues } : {},
   );
   return (