test(client/web): fix happy-dom global-document setup (18 pre-existing fails → 0)

dmealing · claude · dmealing · commit 76bd44861d08 · 2026-05-27T20:46:55.000-04:00
The client/web test suite had 18 pre-existing failures when run from the
client/web/ root: every `@testing-library/dom` `screen.*` call threw
"a global document has to be available". Root cause: Bun only honours the
bunfig.toml in the cwd it is invoked from, so the per-package preloads that
install a JSDOM `document` never fired when `bun test` was run from
client/web/.

Fix:
- Added client/web/bunfig.toml that preloads the existing per-package JSDOM
  setup (reused from packages/react/ so that `jsdom` resolves through that
  package's node_modules).
- Made the per-package test/setup.ts files idempotent so the per-test-file
  `import "./setup.js"` does not replace globalThis.document after
  `@testing-library/dom`'s `screen` module has already captured it (which had
  been silently rebinding `screen` to an orphaned, empty document body).

Verified: `bun test` from client/web/ now reports 84 pass + 0 fail (was
66 pass + 18 fail). Each package's `bun test` continues to pass when run
from its own directory (react 12, tanstack 29, runtime-web 30, angular 13).
Purely test-infrastructure — no runtime behaviour change.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/client/web/bunfig.toml b/client/web/bunfig.toml
@@ -0,0 +1,11 @@
+[test]
+# Preload JSDOM setup so component tests have a real `document` available the
+# moment `@testing-library/dom`'s `screen` module is first evaluated. The
+# per-package bunfig.toml files cover running `bun test` from inside an
+# individual package; this root-level config covers running it from
+# client/web/.
+#
+# We reuse the react package's setup file because it already pulls JSDOM from
+# its own node_modules (Bun's isolated install does not hoist jsdom up to
+# client/web/, so a root-level setup.ts could not import it directly).
+preload = ["./packages/react/test/setup.ts"]
diff --git a/client/web/packages/react/test/setup.ts b/client/web/packages/react/test/setup.ts
@@ -1,5 +1,12 @@
 import { JSDOM } from "jsdom";
 
-const dom = new JSDOM("<!DOCTYPE html><html><body></body></html>");
-global.document = dom.window.document as any;
-global.window = dom.window as any;
+// Idempotent: if a global document has already been registered (e.g. by the
+// client/web root bunfig.toml preload), reuse it. Replacing globalThis.document
+// after `@testing-library/dom`'s `screen` module is evaluated leaves `screen`
+// bound to the previous, now-orphaned document.body — which makes every
+// `screen.*` query look at an empty body.
+if (typeof globalThis.document === "undefined") {
+  const dom = new JSDOM("<!DOCTYPE html><html><body></body></html>");
+  global.document = dom.window.document as any;
+  global.window = dom.window as any;
+}
diff --git a/client/web/packages/tanstack/test/setup.ts b/client/web/packages/tanstack/test/setup.ts
@@ -1,5 +1,12 @@
 import { JSDOM } from "jsdom";
 
-const dom = new JSDOM("<!DOCTYPE html><html><body></body></html>");
-global.document = dom.window.document as any;
-global.window = dom.window as any;
+// Idempotent: if a global document has already been registered (e.g. by the
+// client/web root bunfig.toml preload), reuse it. Replacing globalThis.document
+// after `@testing-library/dom`'s `screen` module is evaluated leaves `screen`
+// bound to the previous, now-orphaned document.body — which makes every
+// `screen.*` query look at an empty body.
+if (typeof globalThis.document === "undefined") {
+  const dom = new JSDOM("<!DOCTYPE html><html><body></body></html>");
+  global.document = dom.window.document as any;
+  global.window = dom.window as any;
+}
