Skip to content

Commit 78910a9

Browse files
dmealingclaude
andcommitted
refactor(omdb): cleanup-fix simplification pass (no behavior change)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 933c157 commit 78910a9

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

server/java/metadata/src/main/java/com/metaobjects/util/DataConverter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ public static Object toType( DataTypes dataType, Object val ) {
5353

5454
// Custom types are opaque to the generic converter; their JDBC binding is
5555
// handled by the per-type codec (e.g. TimeCodec for TimeField/LocalTime).
56-
// Pass the value through unchanged so the codec read path is not blocked.
5756
case CUSTOM: return val;
5857

5958
default: throw new IllegalStateException( "Unknown type (" + dataType + "), cannot convert object [" + val + "]" );

server/java/metadata/src/test/java/com/metaobjects/util/DataConverterTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -333,8 +333,8 @@ public void testToStringArray() {
333333

334334
/**
335335
* CUSTOM type is opaque to the generic converter; values must pass through unchanged.
336-
* This unblocks TimeField (which uses DataTypes.CUSTOM) from the OMDB read path:
337-
* TimeCodec.readInto calls MetaField.setObject → DataConverter.toType(CUSTOM, localTime).
336+
* This allows per-type codecs (e.g. TimeCodec for TimeField) to handle their own
337+
* JDBC binding without being blocked by the generic converter.
338338
*/
339339
@Test
340340
public void testCustomTypePassesThrough() {

server/java/omdb/src/test/java/com/metaobjects/manager/db/validator/MetaClassDBValidatorServiceTest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
11
/*
22
* Copyright (c) 2026 Doug Mealing LLC. All Rights Reserved.
3-
*
4-
* Fix B — verifies that MetaClassDBValidatorService.verifyMapping propagates
5-
* exceptions instead of swallowing them silently.
6-
*
7-
* Covers the bug where the empty catch block around validateDefinition() meant
8-
* that TableDoesNotExistException (thrown when autoCreate=false and the table is
9-
* absent) was discarded without any diagnostic or propagation.
103
*/
114
package com.metaobjects.manager.db.validator;
125

0 commit comments

Comments
 (0)