Commit 842c498
chore(java): minor deferred-followups — PendingExtends TODO + ErrorCode tagging
Two untagged throw sites + one missing TODO surfaced by the prior code review.
- MetaDataLoader.resolvePendingExtends: add a TODO Javadoc note about
cycle detection. Single-pass resolve matches TS reference behavior
(parity, not regression), but a cycle would land silently and only
surface at usage time. Add a one-pass cycle check when this becomes a
real-world hazard.
- CanonicalJsonParser.loadFromStream: the fall-through catch (Exception)
was throwing an untagged MetaDataException. Tag it with
ERR_MALFORMED_JSON so callers see a stable conformance code regardless
of which parse-time failure path fired.
- MetaDataRegistry.createInstance: the "Failed to create instance" throw
was untagged. Tag with ERR_UNKNOWN so registry-instantiation failures
carry a discoverable code.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 4f221a6 commit 842c498
2 files changed
Lines changed: 9 additions & 2 deletions
File tree
- server/java/metadata/src/main/java/com/metaobjects
- loader
- registry
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
166 | 171 | | |
167 | 172 | | |
168 | 173 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
298 | | - | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
299 | 301 | | |
300 | 302 | | |
301 | 303 | | |
| |||
0 commit comments