refactor(csharp): simplify isArray scalar/enum codegen branches

EntityGenerator.ScalarProperty: handle the array case with a single early
return (List<T> + [Column]) and compute required/isValue once for the scalar
path, removing the duplicated IsRequired/IsValueType calls and the abbreviated
req/iv locals introduced alongside the array branch.

DbContextGenerator: hoist the per-entity owner = Pascal(e.Name) above the field
loops instead of recomputing it in each. Emitted output is byte-identical.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: dmealing

server/csharp/MetaObjects.Codegen/Generators/DbContextGenerator.cs

@@ -34,11 +34,11 @@ public IEnumerable<EmittedFile> Generate(GenContext ctx)
         }
         foreach (var e in objects.Where(o => o.IsEntity() && !o.IsReadOnlyProjection()))
         {
+            var owner = CSharpNaming.Pascal(e.Name);
             foreach (var f in e.Fields().Where(f => f.SubType == FIELD_SUBTYPE_OBJECT))
                 if (OwnedTypeConfig(e, f, ctx) is { } cfg) modelLines.Add(cfg);
             foreach (var f in e.Fields().Where(f => f.SubType == FIELD_SUBTYPE_ENUM))
             {
-                var owner = CSharpNaming.Pascal(e.Name);
                 var prop = CSharpNaming.Pascal(f.Name);
                 if (f.IsArray)
                 {
@@ -57,7 +57,6 @@ public IEnumerable<EmittedFile> Generate(GenContext ctx)
             // .Property(...).ToJson() does not exist on PropertyBuilder<List<T>> (CS1061).
             foreach (var f in e.Fields().Where(f => f.IsArray && CSharpNaming.ScalarFor(f.SubType) is not null))
             {
-                var owner = CSharpNaming.Pascal(e.Name);
                 var prop = CSharpNaming.Pascal(f.Name);
                 modelLines.Add($"        modelBuilder.Entity<{owner}>().PrimitiveCollection(x => x.{prop});");
             }

server/csharp/MetaObjects.Codegen/Generators/EntityGenerator.cs

@@ -205,39 +205,35 @@ private static string ScalarProperty(MetaObject owner, MetaField field, IReadOnl
         var baseType = CSharpNaming.ScalarFor(field.SubType)!;
         var propName = CSharpNaming.Pascal(field.Name);
 
-        var sb = new StringBuilder();
-        if (withAttributes)
+        // Array fields: emit List<T> with an empty-list initializer and only a [Column]
+        // attribute — [Key]/[MaxLength]/[Required] are not meaningful for a List<T> jsonb
+        // column (arrays are never PKs, and the list itself is never null in C#).
+        if (field.IsArray)
         {
-            if (field.IsArray)
-            {
-                // Array fields: only [Column]; [Key]/[MaxLength]/[Required] are not
-                // meaningful for a List<T> jsonb column (arrays are never PKs).
-                sb.AppendLine($"    [Column(\"{CSharpNaming.Column(field)}\")]");
-            }
-            else
-            {
-                var required = CSharpNaming.IsRequired(owner, field);
-                var isValue = CSharpNaming.IsValueType(baseType);
-                if (pkFields.Count == 1 && pkFields[0] == field.Name)
-                    sb.AppendLine("    [Key]");
-                sb.AppendLine($"    [Column(\"{CSharpNaming.Column(field)}\")]");
-                if (baseType == "string" && field.MaxLength is long max)
-                    sb.AppendLine($"    [MaxLength({max})]");
-                if (required && !isValue)
-                    sb.AppendLine("    [Required]");
-            }
+            var arr = new StringBuilder();
+            if (withAttributes)
+                arr.AppendLine($"    [Column(\"{CSharpNaming.Column(field)}\")]");
+            arr.Append($"    public List<{baseType}> {propName} {{ get; set; }} = new();");
+            return arr.ToString();
         }
 
-        if (field.IsArray)
+        var required = CSharpNaming.IsRequired(owner, field);
+        var isValue = CSharpNaming.IsValueType(baseType);
+
+        var sb = new StringBuilder();
+        if (withAttributes)
         {
-            sb.Append($"    public List<{baseType}> {propName} {{ get; set; }} = new();");
-            return sb.ToString();
+            if (pkFields.Count == 1 && pkFields[0] == field.Name)
+                sb.AppendLine("    [Key]");
+            sb.AppendLine($"    [Column(\"{CSharpNaming.Column(field)}\")]");
+            if (baseType == "string" && field.MaxLength is long max)
+                sb.AppendLine($"    [MaxLength({max})]");
+            if (required && !isValue)
+                sb.AppendLine("    [Required]");
         }
 
-        var req = CSharpNaming.IsRequired(owner, field);
-        var iv = CSharpNaming.IsValueType(baseType);
-        var type = req ? baseType : baseType + "?";
-        var init = req && !iv ? " = default!;" : string.Empty;
+        var type = required ? baseType : baseType + "?";
+        var init = required && !isValue ? " = default!;" : string.Empty;
         sb.Append($"    public {type} {propName} {{ get; set; }}{init}");
         return sb.ToString();
     }