fix(codegen-ts): resolve effective package in template data dict + scope walks

entity.package is undefined for objects (object fqn() stays bare); read the
effective package via effectivePackage(resolutionKey()) so {package} and the
per-package grouping reflect the declared file package. Strengthen the data-dict
test to assert the real package (the prior assertion was tautological).

Author: dmealing

server/typescript/packages/codegen-ts/src/generators/template-generator.ts

@@ -22,6 +22,7 @@ import {
   buildEntityTemplateData,
   buildPackageTemplateData,
   buildModelTemplateData,
+  packageOf,
 } from "../template-codegen/template-data.js";
 
 /** The three built-in walk scopes (SP-1 §3.1). Same vocabulary as the engine
@@ -87,13 +88,13 @@ function scopeWalk(
     if (scope === "perEntity") {
       return concrete.map((e) => ({
         data: buildEntityTemplateData(e),
-        outputPath: expandOutputPattern(pattern, { name: e.name, package: e.package ?? "" }),
+        outputPath: expandOutputPattern(pattern, { name: e.name, package: packageOf(e) }),
       }));
     }
     if (scope === "perPackage") {
       const byPkg = new Map<string, MetaObject[]>();
       for (const o of concrete) {
-        const pkg = o.package ?? "";
+        const pkg = packageOf(o);
         let bucket = byPkg.get(pkg);
         if (bucket === undefined) { bucket = []; byPkg.set(pkg, bucket); }
         bucket.push(o);

server/typescript/packages/codegen-ts/src/template-codegen/template-data.ts

@@ -5,6 +5,14 @@
 // spec (and the conformance corpus).
 import type { MetaObject, MetaRoot, MetaField } from "@metaobjectsdev/metadata";
 import { FIELD_ATTR_VALUES, FIELD_SUBTYPE_ENUM } from "@metaobjectsdev/metadata";
+import { effectivePackage } from "../docs-paths.js";
+
+/** The effective package of an object — its own package OR the file-default
+ *  folded into `resolutionKey()`. `entity.package` alone is usually undefined
+ *  (object fqn() stays bare), so all package reads go through here. */
+export function packageOf(entity: MetaObject): string {
+  return effectivePackage(entity) ?? "";
+}
 
 export interface FieldTemplateData {
   name: string;
@@ -46,7 +54,7 @@ function fieldData(field: MetaField): FieldTemplateData {
 export function buildEntityTemplateData(entity: MetaObject): EntityTemplateData {
   return {
     name: entity.name,
-    package: entity.package ?? "",
+    package: packageOf(entity),
     fields: entity.fields().map(fieldData),
     identities: entity.identities().map((i) => ({ kind: i.subType, fields: [...i.fields] })),
     relationships: entity.relationships().map((r) => ({
@@ -68,7 +76,7 @@ export function buildModelTemplateData(root: MetaRoot): ModelTemplateData {
   const concrete = root.objects().filter((o) => o.isAbstract !== true);
   const byPkg = new Map<string, MetaObject[]>();
   for (const o of concrete) {
-    const pkg = o.package ?? "";
+    const pkg = packageOf(o);
     let bucket = byPkg.get(pkg);
     if (bucket === undefined) { bucket = []; byPkg.set(pkg, bucket); }
     bucket.push(o);

server/typescript/packages/codegen-ts/test/template-codegen/template-data.test.ts

@@ -17,7 +17,9 @@ describe("buildEntityTemplateData", () => {
     const entity = root.objects()[0]!;
     const data = buildEntityTemplateData(entity);
     expect(data.name).toBe(entity.name);
-    expect(data.package).toBe(entity.package ?? "");
+    // single-entity.json declares package "demo" on the root; the effective
+    // package must resolve (entity.package alone is undefined — object fqn stays bare).
+    expect(data.package).toBe("demo");
     expect(Array.isArray(data.fields)).toBe(true);
     for (const f of data.fields) {
       expect(typeof f.type).toBe("string");