test(codegen-ts): cover tryExtractLenient ok:false + optional-nested null/present at runtime

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: dmealing

server/typescript/packages/codegen-ts/test/extractor-codegen.test.ts

@@ -139,6 +139,22 @@ describe("Extractor codegen — import-and-RUN proof (bun dynamic import)", () =
     expect(order.tags.every((t: unknown) => typeof t === "string")).toBe(true);
     // optional scalar array present → null-filtered string[]
     expect(order.flags).toEqual(["fragile"]);
+    // optional single nested object `shipTo` ABSENT in this input → the `m.shipTo ? toStrictCustomer(...) : null`
+    // branch produces null at runtime (not undefined, not a partial object).
+    expect(order.shipTo).toBeNull();
+
+    // optional single nested object PRESENT → the null-guard recurses into toStrictCustomer and populates.
+    const withShipTo =
+      '{ "customer": { "name": "Ada" }, "lines": [ { "sku": "A", "qty": 2 } ], "tags": ["x"], "shipTo": { "name": "Grace" } }';
+    const shipped = ex.extractOrderOut(root, withShipTo);
+    expect(shipped.shipTo).not.toBeNull();
+    expect(shipped.shipTo.name).toBe("Grace");
+    // and when shipTo is genuinely absent on a separate clean input, it is null (re-confirm the branch)
+    const noShipTo = ex.extractOrderOut(
+      root,
+      '{ "customer": { "name": "Ada" }, "lines": [ { "sku": "A", "qty": 2 } ], "tags": ["x"] }',
+    );
+    expect(noShipTo.shipTo).toBeNull();
 
     // missing required `customer` → throws
     expect(() => ex.extractOrderOut(root, '{ "lines": [] }')).toThrow();

server/typescript/packages/codegen-ts/test/fr010-output-codegen.test.ts

@@ -300,6 +300,24 @@ describe("FR-010 codegen — import-and-RUN proof (bun dynamic import)", () => {
     // tryExtract gate: non-empty, no required lost → ok
     const gate = parser.tryExtractLenientTicketOut(dirty);
     expect(gate.ok).toBe(true);
+    // and the success wrapper still carries the full result (data + report)
+    expect(gate.result.data.subject).toBe("Cannot log in");
+    expect(gate.result.report.hasLostRequired()).toBe(false);
+
+    // ---- tryExtract gate ok:FALSE branch (run-asserted) ----
+    // (a) a payload that LOST a @required field (omit `subject`/`priority`/`score`/`tags`) →
+    //     ok === false because report.hasLostRequired() is true; the wrapper still carries the report.
+    const lostRequired = '{ "assignee": "Grace" }';
+    const lost = parser.tryExtractLenientTicketOut(lostRequired);
+    expect(lost.ok).toBe(false);
+    expect(lost.result.report.hasLostRequired()).toBe(true);
+    expect(lost.result.report.lostRequired()).toContain("subject");
+
+    // (b) empty/garbage input → ok === false because report.isEmpty() is true; report still present.
+    const empty = parser.tryExtractLenientTicketOut("   ");
+    expect(empty.ok).toBe(false);
+    expect(empty.result.report.isEmpty()).toBe(true);
+    expect(empty.result.report).toBeDefined();
 
     // ---- render*Format(): comment-free guide fragment ----
     const fragment: string = prompt.renderTicketOutFormat();