Commit faeac88
fix(java,python): pre-merge review — own-only vs effective + missing parens
Two surgical correctness fixes caught by the pre-merge code-review gate. Both
were latent against the current corpus but real:
1. ValidationPhase.validateDataGridLayout used getChildren(MetaField.class,
false) — own-only iteration. TS/C# use effective. A child entity with
`layout.dataGrid @defaultSortField: "createdAt"` (inherited from the
BaseEntity pattern CLAUDE.md actively recommends) would false-positive
ERR_BAD_DEFAULT_SORT_FIELD in Java only. Two-char flip false→true.
2. expected_schema._matching_relationship_actions accessed
child.object_ref and child.on_update as ATTRIBUTES, but they're METHODS
on MetaRelationship. The bound-method objects are truthy, so the
subsequent _strip_pkg(ref) would call .rfind on a method object and
AttributeError. The corpus never reaches this branch today
(relationships sit on parent entities, references on children), so the
bug is dormant — but blows up on the first same-entity
relationship+reference fixture. Add missing parens.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent c43e15c commit faeac88
2 files changed
Lines changed: 5 additions & 5 deletions
File tree
- server
- java/metadata/src/main/java/com/metaobjects/loader
- python/src/metaobjects/migrate
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
798 | 798 | | |
799 | 799 | | |
800 | 800 | | |
801 | | - | |
| 801 | + | |
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
| 250 | + | |
251 | 251 | | |
252 | 252 | | |
253 | 253 | | |
254 | | - | |
| 254 | + | |
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
277 | | - | |
| 277 | + | |
278 | 278 | | |
279 | 279 | | |
280 | 280 | | |
| |||
0 commit comments