Action_space dimensions formally too large

[kvas7andy]

Dear all,

With latest update, which allowed to increase the number of maximum nodes using kwargs dict inside registry(...) function, the default parameters are 100 nodes,

CyberBattleSim/cyberbattle/_env/cyberbattle_env.py

Line 390 in 4fd228b

maximum_node_count: int = 100,

, which makes action_space for local, remote and connect to be especially large.
Although, that does not change the logic of computing action_mask and set valid node id to be nax number of discovered nodes, internally vector is set to be too big.

1. Question: I want to ask for the logic of change from using max_node_count parameter here

   CyberBattleSim/cyberbattle/_env/cyberbattle_env.py

   Line 608 in 4fd228b

   max_node_count = self.bounds.maximum_node_count

   , why we want to have option to enlarge the maximum nodes count using registry and this we had to change the value from inferred form initial_network to the one included in bounds for registry function?
2. Solution: The workaround as I see can be simply to make this parameters maximum_node_count: int | None and then make if else logic for setting them equal to initial number of parameters from network (done in previous commits from main)

[blumu]

@kvas7andy To make sure I understand correctly the change you are proposing, could you submit a PR or share a diff here of the proposed change?