review comments

mridul-ms · npuvvada · commit 81180e351e60 · 2023-11-10T16:19:16.000+05:30
diff --git a/fixups/RegLegacyFixups/Logging.h b/fixups/RegLegacyFixups/Logging.h
@@ -481,15 +481,16 @@ std::string InterpretKeyPath(HKEY key)
         }
         else
             sret = "InterpretKeyPath failure1" + InterpretAsHex("status", (DWORD)status);
+
+        if (!sret.empty() && sret.back() == '\\')
+        {
+            sret.pop_back();
+        }
     }
     catch (...)
     {
         Log("InterpretKeyPath failure.");
     }
-    if (!sret.empty() && sret.back() == '\\')
-    {
-        sret.pop_back();
-    }
     return sret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -481,15 +481,16 @@ std::string InterpretKeyPath(HKEY key)`
`481`	`481`	`}`
`482`	`482`	`else`
`483`	`483`	`sret = "InterpretKeyPath failure1" + InterpretAsHex("status", (DWORD)status);`
	`484`	`+`
	`485`	`+ if (!sret.empty() && sret.back() == '\\')`
	`486`	`+ {`
	`487`	`+ sret.pop_back();`
	`488`	`+ }`
`484`	`489`	`}`
`485`	`490`	`catch (...)`
`486`	`491`	`{`
`487`	`492`	`Log("InterpretKeyPath failure.");`
`488`	`493`	`}`
`489`		`- if (!sret.empty() && sret.back() == '\\')`
`490`		`- {`
`491`		`- sret.pop_back();`
`492`		`- }`
`493`	`494`	`return sret;`
`494`	`495`	`}`
`495`	`496`