Enable updating the allowlisted apps after importing a db (#135)

* Enable updating the whitelisted apps after importing a db (#135)

* Change setup step to update table instead of inserting

The AADApp step can now be used in isolation after importing a database to update the whitelisted apps, both for scale units and the interAOS app.

* Rename whitelisting to applylisting

Complying with diversity policies

* Throw exception if user does not exist

No longer tries to identify old records based on the appName. If the appId is not in the table, then a new entry is created.

* Change location of error handling

Co-authored-by: Antonstockmarr <43210147+Antonstockmarr@users.noreply.github.com>

Author: faix

src/ScaleUnitManagement/DatabaseManager/AADAppAllowListing.cs

@@ -0,0 +1,38 @@
+using System;
+using ScaleUnitManagement.Utilities;
+
+namespace ScaleUnitManagement.DatabaseManager
+{
+    public class AADAppAllowListing
+    {
+        public void UpdateAADAppClientTable(string dbName, string userName, string appName, string appId)
+        {
+            string sqlQuery = $@"
+            USE {dbName};
+
+            IF NOT EXISTS (SELECT TOP 1 1 FROM USERINFO WHERE ID = '{userName}')
+                THROW 51000, 'No user exists named {userName}', 1
+            ELSE
+                IF NOT EXISTS (SELECT TOP 1 1 FROM SysAADClientTable WHERE AADClientId = '{appId}')
+                    INSERT INTO SysAADClientTable (AADClientId, UserId, Name) VALUES ('{appId}', '{userName}', '{appName}');
+            ";
+
+            var sqlQueryExecutor = new SqlQueryExecutor();
+
+            try
+            {
+                sqlQueryExecutor.Execute(sqlQuery);
+            }
+            catch (Exception ex)
+            {
+                if (ex.Message.Contains($"No user exists named {userName}"))
+                {
+                    Console.WriteLine($"\nUser \"{userName}\" does not exist, run Deployment.Setup.exe fullall sync to create it\n");
+                }
+                throw;
+            }
+
+
+        }
+    }
+}

src/ScaleUnitManagement/ScaleUnitFeatureManager/Common/AddToolClientToSysAADClientTable.cs

@@ -0,0 +1,46 @@
+using System;
+using System.Threading.Tasks;
+using ScaleUnitManagement.DatabaseManager;
+using ScaleUnitManagement.Utilities;
+
+namespace ScaleUnitManagement.ScaleUnitFeatureManager.Hub
+{
+    public sealed class AddToolToHubSysAADClientTable : IHubStep
+    {
+        public string Label()
+        {
+            return "Add CLI tool App to SysAADClientTable";
+        }
+
+        public float Priority()
+        {
+            return 6F;
+        }
+
+        public Task Run()
+        {
+            const string UserName = "ScaleUnitManagement";
+            string hubDb = Config.HubScaleUnit().AxDbName;
+            var allowListing = new AADAppAllowListing();
+
+            try
+            {
+                string interAOSAppId = Config.InterAOSAppId();
+                const string InterAOSAppName = "ScaleUnits";
+                allowListing.UpdateAADAppClientTable(hubDb, UserName, InterAOSAppName, interAOSAppId);
+
+                const string ScaleUnitAppName = "Scale Unit Management Tool";
+                ScaleUnitInstance scaleUnit = Config.FindScaleUnitWithId(ScaleUnitContext.GetScaleUnitId());
+                string scaleUnitAppId = scaleUnit.AuthConfiguration.AppId;
+                allowListing.UpdateAADAppClientTable(hubDb, UserName, ScaleUnitAppName, scaleUnitAppId);
+            }
+            catch (Exception ex)
+            {
+                Console.WriteLine(ex);
+                Console.WriteLine("\nFailed to add CLI tool App to SysAADClientTable.");
+            }
+
+            return Task.CompletedTask;
+        }
+    }
+}

src/ScaleUnitManagement/ScaleUnitFeatureManager/Hub/AddToolToHubSysAADClientTable.cs

@@ -0,0 +1,44 @@
+using System;
+using System.Threading.Tasks;
+using ScaleUnitManagement.DatabaseManager;
+using ScaleUnitManagement.Utilities;
+
+namespace ScaleUnitManagement.ScaleUnitFeatureManager.ScaleUnit
+{
+    public sealed class AddToolToScaleUnitSysAADClientTable : IScaleUnitStep
+    {
+        public string Label()
+        {
+            return "Add CLI tool App to SysAADClientTable";
+        }
+
+        public float Priority()
+        {
+            return 6F;
+        }
+
+        public Task Run()
+        {
+            const string UserName = "ScaleUnitManagement";
+            const string ScaleUnitAppName = "Scale Unit Management Tool";
+
+            ScaleUnitInstance scaleUnit = Config.FindScaleUnitWithId(ScaleUnitContext.GetScaleUnitId());
+            string scaleUnitAppId = scaleUnit.AuthConfiguration.AppId;
+            string dbName = scaleUnit.AxDbName;
+
+            var allowListing = new AADAppAllowListing();
+
+            try
+            {
+                allowListing.UpdateAADAppClientTable(dbName, UserName, ScaleUnitAppName, scaleUnitAppId);
+            }
+            catch (Exception ex)
+            {
+                Console.WriteLine(ex);
+                Console.WriteLine("\nFailed to add CLI tool App to SysAADClientTable.");
+            }
+
+            return Task.CompletedTask;
+        }
+    }
+}