Merge pull request #28418 from ajafff/internal-comments

sheetalkamat · web-flow · commit c0587191fc53 · 2018-11-08T14:58:33.000-08:00
remove even more internal comments
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -2921,7 +2921,6 @@ namespace ts {
         }
     }
 
-    /* @internal */
     export function isExportsOrModuleExportsOrAlias(sourceFile: SourceFile, node: Expression): boolean {
         return isExportsIdentifier(node) ||
             isModuleExportsPropertyAccessExpression(node) ||
@@ -3898,7 +3897,6 @@ namespace ts {
      *       For performance reasons, `computeTransformFlagsForNode` uses local constant values rather
      *       than calling this function.
      */
-    /* @internal */
     export function getTransformFlagsSubtreeExclusions(kind: SyntaxKind) {
         if (kind >= SyntaxKind.FirstTypeNode && kind <= SyntaxKind.LastTypeNode) {
             return TransformFlags.TypeExcludes;
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -2052,7 +2052,6 @@ namespace ts {
     }
 
     /** Represents a "prefix*suffix" pattern. */
-    /* @internal */
     export interface Pattern {
         prefix: string;
         suffix: string;
diff --git a/src/compiler/sourcemapDecoder.ts b/src/compiler/sourcemapDecoder.ts
@@ -150,14 +150,12 @@ namespace ts.sourcemaps {
         }
     }
 
-    /*@internal*/
     export interface MappingsDecoder extends Iterator<SourceMapSpan> {
         readonly decodingIndex: number;
         readonly error: string | undefined;
         readonly lastSpan: SourceMapSpan;
     }
 
-    /*@internal*/
     export function decodeMappings(map: SourceMapData): MappingsDecoder {
         const state: DecoderState = {
             encodedText: map.mappings,
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -5225,7 +5225,6 @@ namespace ts {
         useCaseSensitiveFileNames(): boolean;
         getCurrentDirectory(): string;
 
-        /* @internal */
         isSourceFileFromExternalLibrary(file: SourceFile): boolean;
         getLibFileFromReference(ref: FileReference): SourceFile | undefined;
 
diff --git a/src/compiler/watch.ts b/src/compiler/watch.ts
@@ -43,7 +43,6 @@ namespace ts {
         return false;
     }
 
-    /** @internal */
     export const screenStartingMessageCodes: number[] = [
         Diagnostics.Starting_compilation_in_watch_mode.code,
         Diagnostics.File_change_detected_Starting_incremental_compilation.code,
diff --git a/src/jsTyping/jsTyping.ts b/src/jsTyping/jsTyping.ts
@@ -24,13 +24,11 @@ namespace ts.JsTyping {
         version: Version;
     }
 
-    /* @internal */
     export function isTypingUpToDate(cachedTyping: CachedTyping, availableTypingVersions: MapLike<string>) {
         const availableVersion = new Version(getProperty(availableTypingVersions, `ts${versionMajorMinor}`) || getProperty(availableTypingVersions, "latest")!);
         return availableVersion.compareTo(cachedTyping.version) <= 0;
     }
 
-    /* @internal */
     export const nodeCoreModuleList: ReadonlyArray<string> = [
         "assert",
         "async_hooks",
@@ -70,7 +68,6 @@ namespace ts.JsTyping {
         "zlib"
     ];
 
-    /* @internal */
     export const nodeCoreModules = arrayToSet(nodeCoreModuleList);
 
     /**
diff --git a/src/jsTyping/shared.ts b/src/jsTyping/shared.ts
@@ -34,7 +34,6 @@ namespace ts.server {
             : undefined;
     }
 
-    /*@internal*/
     export function nowString() {
         // E.g. "12:34:56.789"
         const d = new Date();
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -204,7 +204,7 @@ namespace ts.server {
 
         /*@internal*/
         constructor(
-            /*@internal*/readonly projectName: string,
+            readonly projectName: string,
             readonly projectKind: ProjectKind,
             readonly projectService: ProjectService,
             private documentRegistry: DocumentRegistry,
diff --git a/src/server/scriptInfo.ts b/src/server/scriptInfo.ts
@@ -6,7 +6,6 @@ namespace ts.server {
 
     /* @internal */
     export class TextStorage {
-        /*@internal*/
         version: ScriptInfoVersion;
 
         /**
diff --git a/src/server/scriptVersionCache.ts b/src/server/scriptVersionCache.ts
@@ -382,7 +382,6 @@ namespace ts.server {
         }
     }
 
-    /* @internal */
     export class LineIndex {
         root: LineNode;
         // set this to true to check each edit for accuracy
diff --git a/src/server/utilities.ts b/src/server/utilities.ts
@@ -208,13 +208,11 @@ namespace ts.server {
 
     const indentStr = "\n    ";
 
-    /* @internal */
     export function indent(str: string): string {
         return indentStr + str.replace(/\n/g, indentStr);
     }
 
     /** Put stringified JSON on the next line, indented. */
-    /* @internal */
     export function stringifyIndented(json: {}): string {
         return indentStr + JSON.stringify(json);
     }
diff --git a/src/services/formatting/formatting.ts b/src/services/formatting/formatting.ts
@@ -334,7 +334,6 @@ namespace ts.formatting {
         return 0;
     }
 
-    /* @internal */
     export function formatNodeGivenIndentation(node: Node, sourceFileLike: SourceFileLike, languageVariant: LanguageVariant, initialIndentation: number, delta: number, formatContext: FormatContext): TextChange[] {
         const range = { pos: 0, end: sourceFileLike.text.length };
         return getFormattingScanner(sourceFileLike.text, languageVariant, range.pos, range.end, scanner => formatSpanWorker(
diff --git a/src/services/organizeImports.ts b/src/services/organizeImports.ts
@@ -146,7 +146,7 @@ namespace ts.OrganizeImports {
             : undefined;
     }
 
-    /* @internal */ // Internal for testing
+    // Internal for testing
     /**
      * @param importGroup a list of ImportDeclarations, all with the same module name.
      */
@@ -266,7 +266,7 @@ namespace ts.OrganizeImports {
         }
     }
 
-    /* @internal */ // Internal for testing
+    // Internal for testing
     /**
      * @param exportGroup a list of ExportDeclarations, all with the same module name.
      */
diff --git a/src/services/patternMatcher.ts b/src/services/patternMatcher.ts
@@ -461,11 +461,11 @@ namespace ts {
         };
     }
 
-    /* @internal */ export function breakIntoCharacterSpans(identifier: string): TextSpan[] {
+    export function breakIntoCharacterSpans(identifier: string): TextSpan[] {
         return breakIntoSpans(identifier, /*word:*/ false);
     }
 
-    /* @internal */ export function breakIntoWordSpans(identifier: string): TextSpan[] {
+    export function breakIntoWordSpans(identifier: string): TextSpan[] {
         return breakIntoSpans(identifier, /*word:*/ true);
     }
 
diff --git a/src/services/suggestionDiagnostics.ts b/src/services/suggestionDiagnostics.ts
@@ -140,13 +140,11 @@ namespace ts {
         return !!forEachReturnStatement(body, isReturnStatementWithFixablePromiseHandler);
     }
 
-    /* @internal */
     export function isReturnStatementWithFixablePromiseHandler(node: Node): node is ReturnStatement {
         return isReturnStatement(node) && !!node.expression && isFixablePromiseHandler(node.expression);
     }
 
     // Should be kept up to date with transformExpression in convertToAsyncFunction.ts
-    /* @internal */
     export function isFixablePromiseHandler(node: Node): boolean {
         // ensure outermost call exists and is a promise handler
         if (!isPromiseHandler(node) || !node.arguments.every(isFixablePromiseArgument)) {
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -1410,7 +1410,6 @@ namespace ts {
         return node.modifiers && find(node.modifiers, m => m.kind === kind);
     }
 
-    /* @internal */
     export function insertImport(changes: textChanges.ChangeTracker, sourceFile: SourceFile, importDecl: Statement): void {
         const lastImportDeclaration = findLast(sourceFile.statements, isAnyImportSyntax);
         if (lastImportDeclaration) {
@@ -1598,7 +1597,6 @@ namespace ts {
         return displayPart("\n", SymbolDisplayPartKind.lineBreak);
     }
 
-    /* @internal */
     export function mapToDisplayParts(writeDisplayParts: (writer: DisplayPartsSymbolWriter) => void): SymbolDisplayPart[] {
         try {
             writeDisplayParts(displayPartWriter);
@@ -1751,7 +1749,6 @@ namespace ts {
     /**
      * Sets EmitFlags to suppress leading and trailing trivia on the node.
      */
-    /* @internal */
     export function suppressLeadingAndTrailingTrivia(node: Node) {
         suppressLeadingTrivia(node);
         suppressTrailingTrivia(node);
@@ -1760,15 +1757,13 @@ namespace ts {
     /**
      * Sets EmitFlags to suppress leading trivia on the node.
      */
-    /* @internal */
     export function suppressLeadingTrivia(node: Node) {
         addEmitFlagsRecursively(node, EmitFlags.NoLeadingComments, getFirstChild);
     }
 
     /**
      * Sets EmitFlags to suppress trailing trivia on the node.
      */
-    /* @internal */
     export function suppressTrailingTrivia(node: Node) {
         addEmitFlagsRecursively(node, EmitFlags.NoTrailingComments, getLastChild);
     }
@@ -1783,7 +1778,6 @@ namespace ts {
         return node.forEachChild(child => child);
     }
 
-    /* @internal */
     export function getUniqueName(baseName: string, sourceFile: SourceFile): string {
         let nameText = baseName;
         for (let i = 1; !isFileLevelUniqueName(sourceFile, nameText); i++) {
@@ -1797,7 +1791,6 @@ namespace ts {
      * to be on the reference, rather than the declaration, because it's closer to where the
      * user was before extracting it.
      */
-    /* @internal */
     export function getRenameLocation(edits: ReadonlyArray<FileTextChanges>, renameFilename: string, name: string, preferLastLocation: boolean): number {
         let delta = 0;
         let lastPos = -1;

Original file line number	Diff line number	Diff line change
`@@ -2921,7 +2921,6 @@ namespace ts {`
`2921`	`2921`	`}`
`2922`	`2922`	`}`
`2923`	`2923`
`2924`		`- /* @internal */`
`2925`	`2924`	`export function isExportsOrModuleExportsOrAlias(sourceFile: SourceFile, node: Expression): boolean {`
`2926`	`2925`	`return isExportsIdentifier(node) \|\|`
`2927`	`2926`	`isModuleExportsPropertyAccessExpression(node) \|\|`
`@@ -3898,7 +3897,6 @@ namespace ts {`
`3898`	`3897`	* For performance reasons, `computeTransformFlagsForNode` uses local constant values rather
`3899`	`3898`	`* than calling this function.`
`3900`	`3899`	`*/`
`3901`		`- /* @internal */`
`3902`	`3900`	`export function getTransformFlagsSubtreeExclusions(kind: SyntaxKind) {`
`3903`	`3901`	`if (kind >= SyntaxKind.FirstTypeNode && kind <= SyntaxKind.LastTypeNode) {`
`3904`	`3902`	`return TransformFlags.TypeExcludes;`
Original file line number	Diff line number	Diff line change
`@@ -2052,7 +2052,6 @@ namespace ts {`
`2052`	`2052`	`}`
`2053`	`2053`
`2054`	`2054`	`/** Represents a "prefixsuffix" pattern. /`
`2055`		`- /* @internal */`
`2056`	`2055`	`export interface Pattern {`
`2057`	`2056`	`prefix: string;`
`2058`	`2057`	`suffix: string;`
Original file line number	Diff line number	Diff line change
`@@ -150,14 +150,12 @@ namespace ts.sourcemaps {`
`150`	`150`	`}`
`151`	`151`	`}`
`152`	`152`
`153`		`- /@internal/`
`154`	`153`	`export interface MappingsDecoder extends Iterator<SourceMapSpan> {`
`155`	`154`	`readonly decodingIndex: number;`
`156`	`155`	`readonly error: string \| undefined;`
`157`	`156`	`readonly lastSpan: SourceMapSpan;`
`158`	`157`	`}`
`159`	`158`
`160`		`- /@internal/`
`161`	`159`	`export function decodeMappings(map: SourceMapData): MappingsDecoder {`
`162`	`160`	`const state: DecoderState = {`
`163`	`161`	`encodedText: map.mappings,`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,6 @@ namespace ts {`
`43`	`43`	`return false;`
`44`	`44`	`}`
`45`	`45`
`46`		`- /** @internal */`
`47`	`46`	`export const screenStartingMessageCodes: number[] = [`
`48`	`47`	`Diagnostics.Starting_compilation_in_watch_mode.code,`
`49`	`48`	`Diagnostics.File_change_detected_Starting_incremental_compilation.code,`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,6 @@ namespace ts.server {`
`34`	`34`	`: undefined;`
`35`	`35`	`}`
`36`	`36`
`37`		`- /@internal/`
`38`	`37`	`export function nowString() {`
`39`	`38`	`// E.g. "12:34:56.789"`
`40`	`39`	`const d = new Date();`
Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,6 @@ namespace ts.server {`
`382`	`382`	`}`
`383`	`383`	`}`
`384`	`384`
`385`		`- /* @internal */`
`386`	`385`	`export class LineIndex {`
`387`	`386`	`root: LineNode;`
`388`	`387`	`// set this to true to check each edit for accuracy`