-
Notifications
You must be signed in to change notification settings - Fork 247
Expose apm-version as an import input on shared/apm.md #1829
Copy link
Copy link
Open
Labels
area/ci-cdGitHub workflows, merge queue, gh-aw integrations, release pipeline.GitHub workflows, merge queue, gh-aw integrations, release pipeline.status/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Description
Metadata
Metadata
Assignees
Labels
area/ci-cdGitHub workflows, merge queue, gh-aw integrations, release pipeline.GitHub workflows, merge queue, gh-aw integrations, release pipeline.status/acceptedDirection approved, safe to start work.Direction approved, safe to start work.status/triagedInitial agentic triage complete; pending maintainer ratification (silence = approval).Initial agentic triage complete; pending maintainer ratification (silence = approval).type/featureNew capability, new flag, new primitive.New capability, new flag, new primitive.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
In Progress
Summary
Consumers vendor
shared/apm.md(viagh aw add microsoft/apm/.github/workflows/shared/apm.md) and import it from their agentic workflows. The shared workflow pins the apm CLI version only throughmicrosoft/apm-action's built-in default — it does not exposeapm-versionas an import input. To run a newer apm CLI than the action's default, a consumer must hand-edit the vendoredshared/apm.md(theapm-versionon both the Pack and Restoreapm-actionsteps). That edit is fragile:gh aw updatere-merges from upstream and--no-mergereverts it outright.Please add
apm-versionto the import schema and thread it into bothapm-actioninvocations, so consumers can set it from their own workflow'swith:block.Why this matters
The apm CLI version is not cosmetic — it changes what
apm install/apm packdeliver. For example, older apm packs primitives only, while newer apm also carries package documentation/knowledge-base files that agents reference at runtime. Behavior fixes ship in the CLI too — e.g. skill-bundle relative-link rewriting (#1625, PR #1657) was broken for skills and fixed in a later release. Consumers who need any of this currently have no first-class way to opt into a newer CLI; they must patch a vendored file and re-patch it after every update.Current state
shared/apm.md'simport-schemaexposespackages,app-id/private-key/owner/repositories,apps, andtarget— but notapm-version. Bothapm-actionsteps (Pack and Restore) omit theapm-versioninput, so the CLI version falls through to the action's pinned default.Proposed change
import-schema:apm-actionsteps (they must match, so the pack and restore CLI versions can't skew):Consumers then set it cleanly in their import, with no vendored-file patching and no loss on
gh aw update:Prior art
apps:import input toshared/apm.md— precedent that the import schema is the right home for consumer-facing configuration, and that this kind of addition is accepted.shared/apm.mdto a newermicrosoft/apm-action— shows the action/CLI version is maintained here today, but only as a hardcoded edit, not a consumer-settable input.Note on the action ref
The
microsoft/apm-action@<tag>ref itself can't be parameterized the same way (gh-aw SHA-pins the literaluses:ref at compile time), so bumping the action still means editing the vendored file or pulling a newer upstreamshared/apm.md. Exposingapm-versioncovers the common case — a newer CLI on the existing action — without that edit, since the action accepts the input regardless.