refactor: split commands/marketplace.py into per-command modules

[sergio-sisternes-epam]

Summary

src/apm_cli/commands/marketplace.py has grown to 1,835 lines and contains 9 subcommands (init, build, validate, check, outdated, doctor, publish, plus the plugin subgroup wiring). This makes it the largest command file in the codebase and a bottleneck for code review.

Proposed structure

src/apm_cli/commands/marketplace/
  __init__.py          # Click group + shared helpers
  init.py              # marketplace init
  build.py             # marketplace build
  validate.py          # marketplace validate
  check.py             # marketplace check
  outdated.py          # marketplace outdated
  doctor.py            # marketplace doctor
  publish.py           # marketplace publish
  plugin/              # existing marketplace_plugin.py moves here
    __init__.py
    add.py
    set.py
    remove.py

Acceptance criteria

• Each subcommand lives in its own module
• Shared helpers (_render_build_table, _get_console, etc.) extracted to __init__.py or a _helpers.py
• All existing tests pass without modification (import paths preserved via re-exports)
• No functional changes -- pure structural refactor

Context

This was identified as merge condition C1 in the APM Expert Review Panel for PR #790. The Python Architect flagged it as a god-module that kills review velocity. The CEO ratified filing it as a follow-up issue rather than blocking the current PR.

Related: #722, #790

[shreejaykurhade]

I would like to work on this. Please assign to me.
/assign

[github-actions]

Triage decision

accept

Proposed labels

area/cli
type/refactor
status/accepted
good first issue
priority/low

Milestone

0.9.4

Suggested next action

Split src/apm_cli/commands/marketplace.py into per-command modules under src/apm_cli/commands/marketplace/ following the proposed directory structure in the issue body.

Suggested issue comment

Accepting this refactor. The marketplace command file at 1,835 lines is the largest command file in the codebase, and the Python Architect flagged it as a review-velocity bottleneck in the PR #790 panel review -- splitting it was a named merge condition.

The proposed structure is clear and the acceptance criteria (re-exports, no functional changes, all tests pass) are well-defined. This is a solid `good first issue` candidate: the work is mechanical, the impact for contributors reviewing the marketplace area is high, and there is zero risk of behavioral regression if the tests pass.

Starting point: `src/apm_cli/commands/marketplace.py`. Import paths in the current module can be preserved via `__init__.py` re-exports so no test changes are needed.

Per-lens notes (collapsed)

DevX UX Expert -- User-Need Reviewer

Code maintainability refactor with no user-facing changes. Splitting a 1,835-line god-module into per-command files directly improves contributor experience -- smaller files are faster to review, easier to navigate, and less likely to cause merge conflicts. Flagged as good first issue appropriately given the mechanical, well-scoped nature of the work.

Supply Chain Security Expert -- Risk-Surface Reviewer

No risk-surface implication. Pure code organization with no functional changes. No lockfile, marketplace resolution, auth, or signing behavior is altered. area/cli only; no product surface implication.

OSS Growth Hacker -- Contributor-Tone Reviewer

Not activated -- sergio-sisternes-epam is a COLLABORATOR with many prior interactions; standard contributor tone is appropriate.

Python Architect -- Architecture Reviewer

Not activated -- the proposed directory structure is fully specified in the issue body and the acceptance criteria are clear. This is a mechanical module-split following standard Python package conventions; no cross-cutting design decision is required before code lands.

Doc Writer -- Documentation Reviewer

Not activated -- this is a pure structural refactor with no user-facing changes and no new CLI surfaces, so no documentation updates are implied.

APM CEO -- Triage Arbiter

Clear accept at priority/low. The god-module split was an explicit condition from the PR #790 review panel; it is overdue. No theme needed (pure area/cli CLI-layer refactor with no product surface impact). Milestone 0.9.4 is appropriate for this maintenance item.

{
  "decision": "accept",
  "decision_detail": "",
  "theme": null,
  "areas": ["area/cli"],
  "type": "type/refactor",
  "status": "status/accepted",
  "priority": "priority/low",
  "preserved_labels": ["good first issue"],
  "milestone": "0.9.4",
  "next_action": "Split src/apm_cli/commands/marketplace.py into per-command modules under src/apm_cli/commands/marketplace/ following the proposed directory structure.",
  "comment_markdown": "Accepting this refactor. The marketplace command file at 1,835 lines is the largest command file in the codebase, and the Python Architect flagged it as a review-velocity bottleneck in the PR #790 panel review.\n\nThe proposed structure is clear and the acceptance criteria (re-exports, no functional changes, all tests pass) are well-defined. This is a solid `good first issue` candidate: mechanical work, high-impact for contributors, zero regression risk if tests pass.\n\nStarting point: `src/apm_cli/commands/marketplace.py`. Import paths can be preserved via `__init__.py` re-exports so no test changes are needed."
}

---

Triage status: agentic proposal pending human ratification.
Silence is approval. Maintainers can:

• Override any label or milestone above by editing it directly --
  human edits are authoritative and will not be reverted on
  subsequent runs.
• Re-trigger triage by applying the status/needs-triage label, or
  by removing status/triaged to enroll the issue in the next
  daily sweep.

Posted by the Triage Panel workflow. See .apm/skills/apm-triage-panel for the panel skill.

Generated by Triage Panel · ● 1.6M · ◷