From 9f232a2ebc8436d002152b0f20a0d17a99f5816c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 21:17:04 +0000 Subject: [PATCH 1/3] Initial plan From 3b89b04c071b883a9e81b1ba73325c03f6c1e09c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 21:19:07 +0000 Subject: [PATCH 2/3] Add Code Review Guidelines section with rules for consolidated review passes and avoiding stale comments Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com> --- .github/copilot-instructions.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 31621df5..08826e31 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -65,4 +65,11 @@ Unit tests should follow these guidelines: - Use the Moq library for mocking objects where possible. - Validate that each test actually tests the target behavior, e.g. we should not have tests that create a mock, call the mock and then verify that the mock was called, without the target code being involved. We also shouldn't have tests that test language features, e.g. something that the compiler would catch anyway. - Avoid adding excessive comments to tests. Instead favor clear easy to understand code. -- Follow the patterns in the unit tests in the same project or classes to which new tests are being added. \ No newline at end of file +- Follow the patterns in the unit tests in the same project or classes to which new tests are being added. + +## Code Review Guidelines + +When reviewing code, follow these guidelines: + +- Provide all review comments in a single review pass. Avoid scattering feedback across multiple partial reviews; consolidate findings into one coherent review round. +- Do not generate false-positive or already-resolved comments when new commits are pushed. Only surface issues that still apply after the latest changes, and avoid re-posting comments that have been addressed or are no longer relevant. \ No newline at end of file From 21ccb86bbadd7a8f26dd8f22a46671f0d62a5aa6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 3 Dec 2025 21:39:49 +0000 Subject: [PATCH 3/3] Add guideline for respecting user justifications in review comments Co-authored-by: YunchuWang <12449837+YunchuWang@users.noreply.github.com> --- .github/copilot-instructions.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 08826e31..8a289264 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -72,4 +72,5 @@ Unit tests should follow these guidelines: When reviewing code, follow these guidelines: - Provide all review comments in a single review pass. Avoid scattering feedback across multiple partial reviews; consolidate findings into one coherent review round. -- Do not generate false-positive or already-resolved comments when new commits are pushed. Only surface issues that still apply after the latest changes, and avoid re-posting comments that have been addressed or are no longer relevant. \ No newline at end of file +- Do not generate false-positive or already-resolved comments when new commits are pushed. Only surface issues that still apply after the latest changes, and avoid re-posting comments that have been addressed or are no longer relevant. +- Do not re-post a review comment if a user has directly responded to it with justification for why the code exists as written. Respect user explanations and avoid redundant feedback on justified code decisions. \ No newline at end of file