Skip to content

Commit 31218f3

Browse files
committed
remove public pull
1 parent 79e8c92 commit 31218f3

7 files changed

Lines changed: 30 additions & 237 deletions

File tree

durabletask-azuremanaged/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
1111
declaring DTS serverless activities and running a sandbox activity worker.
1212
- Changed serverless activity worker configuration to require explicit SDK
1313
parameters instead of reading DTS environment variables inside the SDK.
14-
- Changed serverless activity image declarations to pass through the
15-
`public_pull` option to DTS instead of enforcing it in the SDK.
1614
- Removed the serverless worker wakeup HTTP listener because ADC sandbox
1715
workers use outbound DTS registration and do not require an inbound probe
1816
endpoint.

durabletask-azuremanaged/durabletask/azuremanaged/extensions/serverless/client.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ def build_serverless_activity_declaration(
6868
repository: Optional[str] = None,
6969
tag: Optional[str] = None,
7070
image_digest: Optional[str] = None,
71-
public_pull: bool = True,
7271
cpu: str = DEFAULT_CPU,
7372
memory: str = DEFAULT_MEMORY,
7473
environment_variables: Optional[dict[str, str]] = None,
@@ -103,8 +102,7 @@ def build_serverless_activity_declaration(
103102
declaration = pb.ServerlessActivityDeclaration(
104103
worker_profile_id=worker_profile_id.strip(),
105104
image=pb.ServerlessActivityImage(
106-
image_ref=image_ref,
107-
public_pull=public_pull),
105+
image_ref=image_ref),
108106
resources=pb.ServerlessActivityResources(
109107
cpu=cpu.strip(),
110108
memory=memory.strip()),
@@ -200,7 +198,6 @@ def declare_serverless_activities(
200198
repository: Optional[str] = None,
201199
tag: Optional[str] = None,
202200
image_digest: Optional[str] = None,
203-
public_pull: bool = True,
204201
cpu: str = DEFAULT_CPU,
205202
memory: str = DEFAULT_MEMORY,
206203
environment_variables: Optional[dict[str, str]] = None,
@@ -215,7 +212,6 @@ def declare_serverless_activities(
215212
repository=repository,
216213
tag=tag,
217214
image_digest=image_digest,
218-
public_pull=public_pull,
219215
cpu=cpu,
220216
memory=memory,
221217
environment_variables=environment_variables,

durabletask-azuremanaged/durabletask/azuremanaged/internal/serverless_activities_service.proto

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ syntax = "proto3";
55

66
package microsoft.durabletask.serverless;
77

8-
import "google/protobuf/timestamp.proto";
9-
108
option csharp_namespace = "Microsoft.DurableTask.Protobuf.Serverless";
119

1210
service ServerlessActivities {
@@ -23,11 +21,6 @@ service ServerlessActivities {
2321
// for the specified worker profile. Existing workers are not terminated by this RPC.
2422
rpc RemoveServerlessActivityDeclaration(RemoveServerlessActivityDeclarationRequest) returns (RemoveServerlessActivityDeclarationResult);
2523

26-
// Lists DTS-managed sandboxes for a declared worker profile in the current task hub.
27-
rpc ListServerlessActivitySandboxes(ListServerlessActivitySandboxesRequest) returns (ListServerlessActivitySandboxesResult);
28-
29-
// Streams best-effort stdout/stderr log lines from a DTS-managed sandbox.
30-
rpc StreamSandboxLogs(SandboxLogStreamRequest) returns (stream SandboxLogLine);
3124
}
3225

3326
message ServerlessActivityWorkerMessage {
@@ -76,7 +69,6 @@ message ServerlessActivityDeclaration {
7669

7770
message ServerlessActivityImage {
7871
string image_ref = 1;
79-
bool public_pull = 2;
8072
}
8173

8274
message ServerlessActivityResources {
@@ -94,36 +86,6 @@ message RemoveServerlessActivityDeclarationRequest {
9486
message RemoveServerlessActivityDeclarationResult {
9587
}
9688

97-
message ListServerlessActivitySandboxesRequest {
98-
string worker_profile_id = 1;
99-
}
100-
101-
message ListServerlessActivitySandboxesResult {
102-
repeated ServerlessActivitySandbox sandboxes = 1;
103-
}
104-
105-
message ServerlessActivitySandbox {
106-
string dts_sandbox_identifier = 1;
107-
string worker_profile_id = 2;
108-
google.protobuf.Timestamp created_at = 3;
109-
string state = 4;
110-
}
111-
112-
message SandboxLogStreamRequest {
113-
// DTS-generated sandbox identifier injected into the worker as DTS_SANDBOX_ID.
114-
string dts_sandbox_identifier = 1;
115-
int32 tail = 2;
116-
}
117-
118-
message SandboxLogLine {
119-
string dts_sandbox_identifier = 1;
120-
google.protobuf.Timestamp timestamp = 2;
121-
string stream = 3;
122-
string tag = 4;
123-
string message = 5;
124-
string raw_line = 6;
125-
}
126-
12789
// Compute substrate executing the activity worker.
12890
enum SubstrateKind {
12991
SUBSTRATE_KIND_UNSPECIFIED = 0;

durabletask-azuremanaged/durabletask/azuremanaged/internal/serverless_activities_service_pb2.py

Lines changed: 27 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)