PR feedback

Author: andystaples

durabletask-azuremanaged/pyproject.toml

@@ -32,7 +32,7 @@ dependencies = [
 
 [project.optional-dependencies]
 azure-blob-payloads = [
-    "durabletask[azure-blob-payloads]>=1.4.0"
+    "durabletask[azure-blob-payloads]>=1.5.0"
 ]
 
 [project.urls]

eng/ci/release.yml

@@ -47,8 +47,13 @@ extends:
                   contentsource: "Folder"
                   folderlocation: "$(System.DefaultWorkingDirectory)/drop/buildoutputs/durabletask"
                   waitforreleasecompletion: true
-                  owners: "torosent@microsoft.com"
-                  approvers: "andystaples@microsoft.com;beverst@microsoft.com"
+                  # Auto-populate from the build queuer's identity so we don't
+                  # hardcode personal emails in source. ESRP will send the
+                  # release notification / approval link to whoever clicked
+                  # "Run pipeline". This matches the pattern used by
+                  # Azure/azure-sdk-for-python and microsoft/mcp pipelines.
+                  owners: $(Build.RequestedForEmail)
+                  approvers: $(Build.RequestedForEmail)
                   serviceendpointurl: "https://api.esrp.microsoft.com"
                   mainpublisher: "durabletask-java"
                   domaintenantid: "33e01921-4d64-4f8c-a055-5bdaffd5e33d"
@@ -78,8 +83,8 @@ extends:
                   contentsource: "Folder"
                   folderlocation: "$(System.DefaultWorkingDirectory)/drop/buildoutputs/durabletask-azuremanaged"
                   waitforreleasecompletion: true
-                  owners: "torosent@microsoft.com"
-                  approvers: "andystaples@microsoft.com;beverst@microsoft.com"
+                  owners: $(Build.RequestedForEmail)
+                  approvers: $(Build.RequestedForEmail)
                   serviceendpointurl: "https://api.esrp.microsoft.com"
                   mainpublisher: "durabletask-java"
                   domaintenantid: "33e01921-4d64-4f8c-a055-5bdaffd5e33d"

eng/templates/build.yml

@@ -1,5 +1,6 @@
 jobs:
-  - job:
+  - job: BuildAndSign
+    displayName: "Build and sign"
     templateContext:
       outputs:
         - output: pipelineArtifact
@@ -24,10 +25,10 @@ jobs:
         inputs:
           artifactFeeds: "internal/PythonSDK_Internal_PublicPackages"
 
-      # Install build + lint tooling
+      # Install build + lint + test tooling
       - script: |
           python -m pip install --upgrade pip
-          python -m pip install build flake8
+          python -m pip install build flake8 pytest pytest-asyncio aiohttp
         displayName: "Install build tooling"
 
       # Lint core SDK
@@ -55,3 +56,25 @@ jobs:
           ls -la $(Build.ArtifactStagingDirectory)/buildoutputs/durabletask
           ls -la $(Build.ArtifactStagingDirectory)/buildoutputs/durabletask-azuremanaged
         displayName: "List build outputs"
+
+      # Install the built wheels and run unit tests against them. We exclude
+      # tests marked `dts` (require the Durable Task Scheduler emulator) and
+      # `azurite` (require the Azurite blob emulator) since those external
+      # services aren't provisioned in this network-isolated pool. The full
+      # matrix (including emulator-backed tests) runs in GitHub Actions on
+      # PRs to main and main itself; this step is defense-in-depth to ensure
+      # the artifacts we're about to ship are at least importable and pass
+      # the pure-Python unit tests.
+      - script: |
+          set -e
+          python -m pip install $(Build.ArtifactStagingDirectory)/buildoutputs/durabletask/*.whl
+          python -m pip install $(Build.ArtifactStagingDirectory)/buildoutputs/durabletask-azuremanaged/*.whl
+        displayName: "Install built wheels"
+
+      - script: pytest -m "not dts and not azurite" --verbose
+        displayName: "pytest: durabletask (unit tests, no emulators)"
+        workingDirectory: tests/durabletask
+
+      - script: pytest -m "not dts" --verbose
+        displayName: "pytest: durabletask-azuremanaged (unit tests, no emulators)"
+        workingDirectory: tests/durabletask-azuremanaged