Commit 6467377
Address auto-generated code-quality review comments on PR #145
1. tests/durabletask/test_orchestration_e2e.py (test_suspend_and_resume):
Drop the unused `state =` assignment around the expected-timeout
`wait_for_orchestration_completion` call. The value is never read
because the next line asserts False and the only non-failing path
raises TimeoutError; `state` is reassigned a few lines down. Silences
the "variable defined multiple times" warning that CodeQL flagged
because this previously-untouched line was pulled into the diff by
the indent change.
2. tests/durabletask/test_client.py
(test_sync_client_context_manager_propagates_exception_and_calls_close):
Replace the nested `with pytest.raises(...): with client: raise ...`
pattern with an explicit try/except so CodeQL no longer reports the
post-block assertions as unreachable. Test intent (exception
propagation + cleanup verification) is preserved.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 752b383 commit 6467377
2 files changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
791 | 791 | | |
792 | 792 | | |
793 | 793 | | |
794 | | - | |
| 794 | + | |
| 795 | + | |
795 | 796 | | |
796 | 797 | | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
797 | 802 | | |
798 | 803 | | |
799 | 804 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
| 302 | + | |
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| |||
0 commit comments