update checkstyle to 8.29 (#321)

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>

Author: testforstephen

check_style.xml

@@ -40,6 +40,23 @@
         <property name="message" value="CRLF and CR line endings are prohibited, but this file uses them."/>
     </module>
 
+    <module name="LineLengthCheck">
+        <property name="fileExtensions" value="java" />
+        <!-- Checks if a line is too long. -->
+        <property name="max" value="${com.puppycrawl.tools.checkstyle.checks.sizes.LineLength.max}" default="160"/>
+        <property name="severity" value="error"/>
+
+        <!--
+          The default ignore pattern exempts the following elements:
+            - import statements
+            - long URLs inside comments
+        -->
+
+        <property name="ignorePattern"
+                  value="${com.puppycrawl.tools.checkstyle.checks.sizes.LineLength.ignorePattern}"
+                  default="^(package .*;\s*)|(import .*;\s*)|( *\* *https?://.*)$"/>
+    </module>
+
     <module name="TreeWalker">
         <!-- Default CheckStyle Whitespace rules seem reasonable to use. -->
         <module name="EmptyForIteratorPad"/>
@@ -92,10 +109,6 @@
             <property name="allowByTailComment" value="true"/>
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
-        <module name="LineLength">
-            <property name="max" value="160"/>
-            <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-        </module>
         <module name="AvoidStarImport"/>
         <module name="OneTopLevelClass"/>
         <module name="NoLineWrap"/>
@@ -226,6 +239,7 @@
             <property name="thirdPartyPackageRegExp" value="^com\."/>
             <property name="sortImportsInGroupAlphabetically" value="true"/>
             <property name="separateLineBetweenGroups" value="true"/>
+            <property name="severity" value="info"/>
         </module>
         <module name="MethodParamPad"/>
         <module name="ParenPad"/>
@@ -249,19 +263,16 @@
             <property name="forbiddenSummaryFragments"
                       value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/>
         </module>
-        <module name="JavadocParagraph"/>
+        <!-- <module name="JavadocParagraph"/> -->
         <module name="AtclauseOrder">
             <property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
             <property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
         </module>
         <module name="JavadocMethod">
             <property name="scope" value="public"/>
             <property name="allowMissingParamTags" value="true"/>
-            <property name="allowMissingThrowsTags" value="true"/>
             <property name="allowMissingReturnTag" value="true"/>
-            <property name="minLineCount" value="2"/>
             <property name="allowedAnnotations" value="Override, Test"/>
-            <property name="allowThrowsTagsForSubclasses" value="true"/>
         </module>
         <module name="MethodName">
             <property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9_]*$"/>

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java

@@ -545,7 +545,6 @@ public static List<String> parseArguments(String cmdStr) {
         return AdapterUtils.isWindows() ? parseArgumentsWindows(cmdStr) : parseArgumentsNonWindows(cmdStr);
     }
 
-
     /**
      * Parses the given command line into separate arguments for mac/linux platform.
      * This piece of code is mainly copied from
@@ -627,7 +626,6 @@ private static List<String> parseArgumentsNonWindows(String args) {
         return result;
     }
 
-
     /**
      * Parses the given command line into separate arguments for windows platform.
      * This piece of code is mainly copied from

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/AdapterUtils.java

@@ -263,7 +263,6 @@ public static DebugException createUserErrorDebugException(String message, Error
         return new DebugException(message, errorCode.getId(), true);
     }
 
-
     /**
      * Calculate SHA-256 Digest of given string.
      * @param content

com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/JdtUtils.java

@@ -180,7 +180,6 @@ public static boolean isTest(final IClasspathEntry classpathEntry) {
         return classpathEntry.isTest();
     }
 
-
     /**
      * Compute the possible source containers that the specified project could be associated with.
      * <p>

com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/LogUtils.java

@@ -21,7 +21,6 @@ public final class LogUtils {
     private static final Logger logger = Logger.getLogger(Configuration.LOGGER_NAME);
     private static final Logger usageDataLogger = Logger.getLogger(Configuration.USAGE_DATA_LOGGER_NAME);
 
-
     /**
      * Initialize logger for logger level and logger handler.
      * @param level the logger level for java debugger.

pom.xml

@@ -113,12 +113,12 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-checkstyle-plugin</artifactId>
-                    <version>2.17</version>
+                    <version>3.1.0</version>
                     <dependencies>
                         <dependency>
                             <groupId>com.puppycrawl.tools</groupId>
                             <artifactId>checkstyle</artifactId>
-                            <version>8.18</version>
+                            <version>8.29</version>
                         </dependency>
                         <dependency>
                             <groupId>com.github.sevntu-checkstyle</groupId>