From dc94fff60762abad0119c94b109f8ef58166b0ba Mon Sep 17 00:00:00 2001 From: Aayush Pandey Date: Sun, 26 Jul 2026 00:08:29 -0700 Subject: [PATCH] fix: emit Python enum members as strings --- src/Kiota.Builder/Writers/Python/CodeEnumWriter.cs | 2 +- .../Writers/Python/CodeEnumWriterTests.cs | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Kiota.Builder/Writers/Python/CodeEnumWriter.cs b/src/Kiota.Builder/Writers/Python/CodeEnumWriter.cs index 1d26d0a9e7..7d8f3858a1 100644 --- a/src/Kiota.Builder/Writers/Python/CodeEnumWriter.cs +++ b/src/Kiota.Builder/Writers/Python/CodeEnumWriter.cs @@ -26,7 +26,7 @@ public override void WriteCodeElement(CodeEnum codeElement, LanguageWriter write codeElement.Options.ToList().ForEach(x => { conventions.WriteInLineDescription(x, writer); - writer.WriteLine($"{x.Name} = \"{x.WireName.SanitizeDoubleQuote()}\","); + writer.WriteLine($"{x.Name} = \"{x.WireName.SanitizeDoubleQuote()}\""); }); } } diff --git a/tests/Kiota.Builder.Tests/Writers/Python/CodeEnumWriterTests.cs b/tests/Kiota.Builder.Tests/Writers/Python/CodeEnumWriterTests.cs index 1e4326db29..d74ab52a09 100644 --- a/tests/Kiota.Builder.Tests/Writers/Python/CodeEnumWriterTests.cs +++ b/tests/Kiota.Builder.Tests/Writers/Python/CodeEnumWriterTests.cs @@ -42,7 +42,8 @@ public void WritesEnum() var result = tw.ToString(); Assert.Contains("from enum import Enum", result); Assert.Contains("(str, Enum):", result); - Assert.Contains($"Option1 = \"{optionName}\"", result); + Assert.Contains($"Option1 = \"{optionName}\"{Environment.NewLine}", result); + Assert.DoesNotContain($"Option1 = \"{optionName}\",", result); Assert.DoesNotContain("pass", result); } [Fact] @@ -64,7 +65,8 @@ public void EscapesEnumWireValues() }); writer.Write(currentEnum); var result = tw.ToString(); - Assert.Contains("Option1 = \"line1\\\"\\nline2\",", result); + Assert.Contains($"Option1 = \"line1\\\"\\nline2\"{Environment.NewLine}", result); + Assert.DoesNotContain("Option1 = \"line1\\\"\\nline2\",", result); } [Fact] public void SanitizesEnumOptionDescriptionWithNewlines()