Commit ea05d34
committed
Address PR feedback: lock ordering, translate_ec comment, type-erasure assert
1. SetOptions: move HasBinaryMessageFragmentHandlers() before m_stateMutex
acquisition to eliminate latent m_stateMutex -> m_eventCallbacksMutex
nesting hazard.
2. wintls_socket translate_ec: add comment explaining that wintls::error_code
resolves to the lib::error_code identity overload (same type via
WINTLS_USE_STANDALONE_ASIO), so TLS errors propagate correctly.
3. websocketpp_client_base::impl<T>(): add debug-only type tag (typeid hash)
set at construction and asserted on access, catching config-type dispatch
mismatches at zero release cost.1 parent 7dad3d9 commit ea05d34
3 files changed
Lines changed: 22 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1790 | 1790 | | |
1791 | 1791 | | |
1792 | 1792 | | |
| 1793 | + | |
| 1794 | + | |
1793 | 1795 | | |
1794 | 1796 | | |
1795 | 1797 | | |
1796 | 1798 | | |
1797 | 1799 | | |
1798 | 1800 | | |
| 1801 | + | |
| 1802 | + | |
| 1803 | + | |
1799 | 1804 | | |
1800 | 1805 | | |
1801 | 1806 | | |
1802 | 1807 | | |
1803 | 1808 | | |
| 1809 | + | |
| 1810 | + | |
| 1811 | + | |
| 1812 | + | |
| 1813 | + | |
1804 | 1814 | | |
1805 | 1815 | | |
1806 | 1816 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
218 | 224 | | |
219 | 225 | | |
220 | 226 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
550 | 550 | | |
551 | 551 | | |
552 | 552 | | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
553 | 558 | | |
554 | 559 | | |
555 | 560 | | |
| |||
559 | 564 | | |
560 | 565 | | |
561 | 566 | | |
562 | | - | |
| 567 | + | |
563 | 568 | | |
564 | 569 | | |
565 | 570 | | |
| |||
0 commit comments