PHP 8.5 support

[Matt-PMCT]

Microsoft should provide timely support for PHP 8.5.

[lionslair]

Still no 8.4 version wouldn't hold your breath

[goozak]

See PHP 8.4 support

[NWASStephenFowles]

Before I start looking a alternatives for the databases, can we have at least a beta release of a driver that supports 8.5, or at least 8.4. I'm about to have a pen test, and I know I'm going to receive a minor issue at least for out-of-date php releases.

[CodeMuz]

+1

[jansor]

+1

[stancl]

Cannot guarantee this will be usable in production (you probably should wait for a proper release), but if you just need this to compile with PHP 8.5, e.g. for CI use, you can use something like this:

FROM php:8.5.0RC2-cli-bookworm
SHELL ["/bin/bash", "-c"]

RUN apt-get update

RUN apt-get install -y gnupg2 \
    && curl -fsSL https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor -o /usr/share/keyrings/microsoft-prod.gpg \
    && curl https://packages.microsoft.com/config/debian/12/prod.list > /etc/apt/sources.list.d/mssql-release.list \
    && apt-get update \
    && ACCEPT_EULA=Y apt-get install -y unixodbc-dev msodbcsql18

RUN mkdir sqlsrv \
    && cd sqlsrv \
    && pecl download pdo_sqlsrv-5.12.0 \
    && tar xzf pdo_sqlsrv-5.12.0.tgz \
    && cd pdo_sqlsrv-5.12.0 \
    && sed -i 's/= dbh->error_mode/= (enum pdo_error_mode) dbh->error_mode/' pdo_dbh.cpp \
    && sed -i 's/zval_ptr_dtor( &dbh->query_stmt_zval );/OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;/' php_pdo_sqlsrv_int.h \
    && phpize \
    && ./configure --with-php-config=$(which php-config) \
    && make -j$(nproc)

# /sqlsrv/pdo_sqlsrv-5.12.0/modules/pdo_sqlsrv.so

You can use that in a multi-stage build, just copy over the path in the comment. Note that you will still need the dependencies installed via apt. In a regular build, you could use something like this:

RUN if [[ "${PHP_VERSION}" == *"8.5"* ]]; then \
        mkdir sqlsrv \
        && cd sqlsrv \
        && pecl download pdo_sqlsrv-5.12.0 \
        && tar xzf pdo_sqlsrv-5.12.0.tgz \
        && cd pdo_sqlsrv-5.12.0 \
        && sed -i 's/= dbh->error_mode/= (enum pdo_error_mode) dbh->error_mode/' pdo_dbh.cpp \
        && sed -i 's/zval_ptr_dtor( &dbh->query_stmt_zval );/OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;/' php_pdo_sqlsrv_int.h \
        && phpize \
        && ./configure --with-php-config=$(which php-config) \
        && make -j$(nproc) \
        && cp modules/pdo_sqlsrv.so $(php -r 'echo ini_get("extension_dir");') \
        && cd / \
        && rm -rf /sqlsrv; \
    else \
        pecl install pdo_sqlsrv; \
    fi

RUN docker-php-ext-enable pdo_sqlsrv

If you do not use Docker, the process is basically just:

# clone repo, or rather download the latest tarball from pecl

# patch pdo_dbh.cpp per https://github.com/php/php-src/pull/17741
sed -i 's/= dbh->error_mode/= (enum pdo_error_mode) dbh->error_mode/' pdo_dbh.cpp

# patch php_pdo_sqlsrv_int.h per https://github.com/php/php-src/pull/17742
sed -i 's/zval_ptr_dtor( &dbh->query_stmt_zval );/OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;/' php_pdo_sqlsrv_int.h

# build as usual
phpize
./configure --with-php-config=$(which php-config)
make -j$(nproc)

# the extension is now in ./modules/
# we can copy it into the php extension_dir like this:
cp modules/pdo_sqlsrv.so $(php -r 'echo ini_get("extension_dir");')

I've opened a PR with these changes: #1543

[jochem-blok]

Please add support as soon as possible. We are in the process of upgrading php and would like to use the latest and greatest version. Not another php 8.4 episode please.

[GTS-MEGHNI]

Are we getting a support for php 8.5 ?

[sjayexec]

+1 for PHP 8.5 support. We are nearing PHP 8.5.0 GA, and there's no sign about whether this will be supported. @stancl 's PR #1543 and instructions to make it compile works. But hope we get official 8.5 support soon.

[David-Engel]

PHP 8.5 support will happen. There is a new team ramping up now. Given the current project state, a GA release is likely in late Jan or Feb.

[thirdwheel]

Thank you @stancl for your instructions, my PHP build process now builds the modules for 8.5.

I ran a regression test on 8.4.15 and it does not build with the changes.

In file included from /opt/php/8.4.15/include/php/Zend/zend_globals.h:36,
                 from /opt/php/8.4.15/include/php/Zend/zend_compile.h:845,
                 from /opt/php/8.4.15/include/php/Zend/zend_modules.h:24,
                 from /opt/php/8.4.15/include/php/Zend/zend_API.h:25,
                 from /opt/php/8.4.15/include/php/main/php.h:35,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv.h:23,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_init.cpp:21:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h: In function 'void pdo_reset_dbh_error(pdo_dbh_t*)':
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:26: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                          ^~~~~~~~~~~~~~
/opt/php/8.4.15/include/php/Zend/zend_objects_API.h:45:46: note: in definition of macro 'OBJ_RELEASE'
   45 | #define OBJ_RELEASE(obj) zend_object_release(obj)
      |                                              ^~~
In file included from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_init.cpp:24:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:47: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                                               ^~~~~~~~~~~~~~
      |                                               query_stmt
In file included from /opt/php/8.4.15/include/php/Zend/zend_globals.h:36,
                 from /opt/php/8.4.15/include/php/Zend/zend_compile.h:845,
                 from /opt/php/8.4.15/include/php/Zend/zend_modules.h:24,
                 from /opt/php/8.4.15/include/php/Zend/zend_API.h:25,
                 from /opt/php/8.4.15/include/php/main/php.h:35,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv.h:23,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_parser.cpp:23:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h: In function 'void pdo_reset_dbh_error(pdo_dbh_t*)':
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:26: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                          ^~~~~~~~~~~~~~
/opt/php/8.4.15/include/php/Zend/zend_objects_API.h:45:46: note: in definition of macro 'OBJ_RELEASE'
   45 | #define OBJ_RELEASE(obj) zend_object_release(obj)
      |                                              ^~~
In file included from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_parser.cpp:26:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:47: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                                               ^~~~~~~~~~~~~~
      |                                               query_stmt
In file included from /opt/php/8.4.15/include/php/Zend/zend_globals.h:36,
                 from /opt/php/8.4.15/include/php/Zend/zend_compile.h:845,
                 from /opt/php/8.4.15/include/php/Zend/zend_modules.h:24,
                 from /opt/php/8.4.15/include/php/Zend/zend_API.h:25,
                 from /opt/php/8.4.15/include/php/main/php.h:35,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv.h:23,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_stmt.cpp:21:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h: In function 'void pdo_reset_dbh_error(pdo_dbh_t*)':
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:26: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                          ^~~~~~~~~~~~~~
/opt/php/8.4.15/include/php/Zend/zend_objects_API.h:45:46: note: in definition of macro 'OBJ_RELEASE'
   45 | #define OBJ_RELEASE(obj) zend_object_release(obj)
      |                                              ^~~
In file included from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_stmt.cpp:24:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:47: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                                               ^~~~~~~~~~~~~~
      |                                               query_stmt
make: *** [Makefile:217: pdo_init.lo] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:211: pdo_parser.lo] Error 1
In file included from /opt/php/8.4.15/include/php/Zend/zend_globals.h:36,
                 from /opt/php/8.4.15/include/php/Zend/zend_compile.h:845,
                 from /opt/php/8.4.15/include/php/Zend/zend_modules.h:24,
                 from /opt/php/8.4.15/include/php/Zend/zend_API.h:25,
                 from /opt/php/8.4.15/include/php/main/php.h:35,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv.h:23,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_util.cpp:21:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h: In function 'void pdo_reset_dbh_error(pdo_dbh_t*)':
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:26: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                          ^~~~~~~~~~~~~~
/opt/php/8.4.15/include/php/Zend/zend_objects_API.h:45:46: note: in definition of macro 'OBJ_RELEASE'
   45 | #define OBJ_RELEASE(obj) zend_object_release(obj)
      |                                              ^~~
In file included from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_util.cpp:24:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:47: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                                               ^~~~~~~~~~~~~~
      |                                               query_stmt
In file included from /opt/php/8.4.15/include/php/Zend/zend_globals.h:36,
                 from /opt/php/8.4.15/include/php/Zend/zend_compile.h:845,
                 from /opt/php/8.4.15/include/php/Zend/zend_modules.h:24,
                 from /opt/php/8.4.15/include/php/Zend/zend_API.h:25,
                 from /opt/php/8.4.15/include/php/main/php.h:35,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv.h:23,
                 from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_dbh.cpp:21:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h: In function 'void pdo_reset_dbh_error(pdo_dbh_t*)':
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:26: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                          ^~~~~~~~~~~~~~
/opt/php/8.4.15/include/php/Zend/zend_objects_API.h:45:46: note: in definition of macro 'OBJ_RELEASE'
   45 | #define OBJ_RELEASE(obj) zend_object_release(obj)
      |                                              ^~~
In file included from /msphpsql-5.12.0/source/pdo_sqlsrv/pdo_dbh.cpp:24:
/msphpsql-5.12.0/source/pdo_sqlsrv/php_pdo_sqlsrv_int.h:304:47: error: 'pdo_dbh_t' {aka 'struct _pdo_dbh_t'} has no member named 'query_stmt_obj'; did you mean 'query_stmt'?
  304 |         OBJ_RELEASE(dbh->query_stmt_obj);dbh->query_stmt_obj=NULL;
      |                                               ^~~~~~~~~~~~~~
      |                                               query_stmt
make: *** [Makefile:220: pdo_stmt.lo] Error 1
make: *** [Makefile:214: pdo_util.lo] Error 1
make: *** [Makefile:208: pdo_dbh.lo] Error 1

[stancl]

That's because those changes are for PHP 8.5, these things were changed between the two versions so the old syntax works with PHP 8.4 and the new syntax works with PHP 8.5. If you take a look at the linked PR it uses version checks to determine which code to use. If you want to test building the PR on 8.5 and 8.4, it'd definitely be appreciated!

[thirdwheel]

Ah. I didn't scroll down far enough to see the link to the PR. Thanks!