diff --git a/src/Playwright.Tests/ScreencastTests.cs b/src/Playwright.Tests/ScreencastTests.cs index af34129a2..e1eb5f06d 100644 --- a/src/Playwright.Tests/ScreencastTests.cs +++ b/src/Playwright.Tests/ScreencastTests.cs @@ -281,4 +281,45 @@ await page.Screencast.StartAsync(new() } await context.CloseAsync(); } + + [PlaywrightTest()] + public async Task ShowOverlayAsync_ReturnsDisposableThatCompletesOnDispose() + { + var context = await Browser.NewContextAsync(); + var page = await context.NewPageAsync(); + + await using (var overlay = await page.Screencast.ShowOverlayAsync("
overlay
")) + { + Assert.IsNotNull(overlay); + } + + await context.CloseAsync(); + } + + [PlaywrightTest()] + public async Task ShowChapterAsync_CompletesWithTitleAndOptions() + { + var context = await Browser.NewContextAsync(); + var page = await context.NewPageAsync(); + + await page.Screencast.ShowChapterAsync("Chapter title", new() + { + Description = "Chapter description", + Duration = 500f, + }); + + await context.CloseAsync(); + } + + [PlaywrightTest()] + public async Task ShowOverlaysAsync_AndHideOverlaysAsync_Complete() + { + var context = await Browser.NewContextAsync(); + var page = await context.NewPageAsync(); + + await page.Screencast.HideOverlaysAsync(); + await page.Screencast.ShowOverlaysAsync(); + + await context.CloseAsync(); + } } diff --git a/src/Playwright/Core/Screencast.cs b/src/Playwright/Core/Screencast.cs index b396567ca..f31cbe245 100644 --- a/src/Playwright/Core/Screencast.cs +++ b/src/Playwright/Core/Screencast.cs @@ -96,17 +96,17 @@ await _page.WrapApiCallAsync(async () => public async Task ShowOverlayAsync(string html, ScreencastShowOverlayOptions? options = default) { - var result = await _page.SendMessageToServerAsync("overlayShow", new Dictionary + var result = await _page.SendMessageToServerAsync("screencastShowOverlay", new Dictionary { ["html"] = html, ["duration"] = options?.Duration, }).ConfigureAwait(false); var id = result!.Value.GetProperty("id").GetString(); - return new DisposableStub(() => _page.SendMessageToServerAsync("overlayRemove", new Dictionary { ["id"] = id })); + return new DisposableStub(() => _page.SendMessageToServerAsync("screencastRemoveOverlay", new Dictionary { ["id"] = id })); } public Task ShowChapterAsync(string title, ScreencastShowChapterOptions? options = default) - => _page.SendMessageToServerAsync("overlayChapter", new Dictionary + => _page.SendMessageToServerAsync("screencastChapter", new Dictionary { ["title"] = title, ["description"] = options?.Description, @@ -128,8 +128,8 @@ public Task HideActionsAsync() => _page.SendMessageToServerAsync("screencastHideActions"); public Task ShowOverlaysAsync() - => _page.SendMessageToServerAsync("overlaySetVisible", new Dictionary { ["visible"] = true }); + => _page.SendMessageToServerAsync("screencastSetOverlayVisible", new Dictionary { ["visible"] = true }); public Task HideOverlaysAsync() - => _page.SendMessageToServerAsync("overlaySetVisible", new Dictionary { ["visible"] = false }); + => _page.SendMessageToServerAsync("screencastSetOverlayVisible", new Dictionary { ["visible"] = false }); }