Skip to content

Commit ec78849

Browse files
committed
fix test
1 parent 6095058 commit ec78849

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

packages/http-client-python/generator/pygen/codegen/models/client.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,15 @@ def __init__(
8989

9090
@property
9191
def need_cloud_setting(self) -> bool:
92-
return bool(self.code_model.options["azure_arm"] and self.credential_scopes is not None)
92+
return bool(
93+
self.code_model.options["azure_arm"]
94+
and self.credential_scopes is not None
95+
and self.endpoint_parameter is not None
96+
)
97+
98+
@property
99+
def endpoint_parameter(self) -> Optional[Parameter]:
100+
return next((p for p in self.parameters.parameters if p.location == ParameterLocation.ENDPOINT_PATH), None)
93101

94102
def _build_request_builders(
95103
self,

packages/http-client-python/generator/pygen/codegen/serializers/client_serializer.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
# Licensed under the MIT License. See License.txt in the project root for
44
# license information.
55
# --------------------------------------------------------------------------
6-
from typing import List
6+
from typing import List, cast
77

88
from . import utils
9-
from ..models import Client, ParameterMethodLocation
9+
from ..models import Client, ParameterMethodLocation, Parameter
1010
from .parameter_serializer import ParameterSerializer, PopKwargType
1111
from ...utils import build_policies
1212

@@ -82,12 +82,13 @@ def initialize_config(self) -> List[str]:
8282
additional_signatures = []
8383
if self.client.need_cloud_setting:
8484
additional_signatures.append("credential_scopes=credential_scopes")
85+
endpoint_parameter = cast(Parameter, self.client.endpoint_parameter)
8586
retval.extend(
8687
[
8788
'_cloud = kwargs.pop("cloud_setting", None) or settings.current.azure_cloud # type: ignore',
8889
"_endpoints = get_arm_endpoints(_cloud)",
89-
"if not base_url:",
90-
' base_url = _endpoints["resource_manager"]',
90+
f"if not {endpoint_parameter.client_name}:",
91+
f' {endpoint_parameter.client_name} = _endpoints["resource_manager"]',
9192
'credential_scopes = kwargs.pop("credential_scopes", _endpoints["credential_scopes"])',
9293
]
9394
)

0 commit comments

Comments
 (0)