feat(ci): add reusable surface-lint workflow#1
Merged
Conversation
Adds yamllint, shellcheck, and actionlint configs so the .github repo can lint itself and serve as a reference for consumer repos. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Callable via workflow_call from any org repo. Runs yamllint, shellcheck, and actionlint with SHA-pinned actions. Accepts optional inputs for runner label, yamllint paths, and shellcheck scan directory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Calls the reusable surface-lint workflow on itself to dogfood the linting setup. Shellcheck no-ops cleanly since the repo has no scripts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove yamllint-file-or-dir, yamllint-config-file, and shellcheck-scandir inputs. Yamllint always scans "." and shellcheck always scans "./scripts". Add yamllint-ignore and shellcheck-ignore inputs for callers that need to exclude specific directories. Switch yamllint from the ibiqlik action to a run step with find+xargs since yamllint has no CLI ignore support — bash arrays handle the exclude patterns cleanly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Yamllint ignores belong in each repo's .yamllint.yml config (the tool's native ignore: directive), not in workflow inputs. Remove the yamllint-ignore input and the find+xargs shell implementation, restore the ibiqlik/action-yamllint action with file_or_dir hardcoded to ".". Only shellcheck-ignore remains as a workflow input since shellcheck's config format has no path-exclusion mechanism. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surface-lintworkflow callable viaworkflow_callfrom any org repo.using the repo's.yamllint.yml— ignores are configured in that config file via yamllint's nativeignore:directive./scripts— path exclusions viashellcheck-ignoreinput (shellcheck has no config-level path ignores)runs-on(defaultubuntu-latest) andshellcheck-ignore(default empty)ci.ymlthat dogfoods the reusable workflowConsumer usage
Test plan
yamllint -c .yamllint.yml .passes locally (warnings only, no errors)actionlintpasses locally🤖 Generated with Claude Code