fix(mqtt): re-subscribe on every connack to survive auto-reconnects#61
Merged
Conversation
Both init_client and the ConnAck Success arm of handle_event were issuing subscribe_sync followed by subscribe_ping with identical error handling. Bundle the pair into mqtt::device::subscribe_all so the worker calls it in one line. Adds three unit tests covering the helper's happy path, short-circuit-on-sync-error, and error-propagation-on-ping-error behaviors.
ben-miru
force-pushed
the
fix/mqtt-resubscribe-on-reconnect-main
branch
from
09f9cbd to
6aac544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of the v0.8.1 hotfix landing as #60 on
release/v0.8. Read the original PR #60 for more information.